UnexpectedValueException: Tried to submit link suggestion reviews which has already been reviewed.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.37.0-wmf.14
reqId: 8ec6e453-c2c0-4059-9087-0776c29d0211
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   UnexpectedValueException: Tried to submit link suggestion reviews for revision "53277132" which has already been reviewed.

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.14/extensions/GrowthExperiments/includes/NewcomerTasks/AddLink/AddLinkSubmissionHandler.php(103)
#0 /srv/mediawiki/php-1.37.0-wmf.14/extensions/GrowthExperiments/includes/VisualEditorHooks.php(83): GrowthExperiments\NewcomerTasks\AddLink\AddLinkSubmissionHandler->run(Title, User, integer, NULL, array)
#1 /srv/mediawiki/php-1.37.0-wmf.14/includes/HookContainer/HookContainer.php(160): GrowthExperiments\VisualEditorHooks->onVisualEditorApiVisualEditorEditPostSave(MediaWiki\Page\PageIdentityValue, User, string, array, array, array, array)
#2 /srv/mediawiki/php-1.37.0-wmf.14/extensions/VisualEditor/includes/VisualEditorHookRunner.php(50): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#3 /srv/mediawiki/php-1.37.0-wmf.14/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(488): MediaWiki\Extension\VisualEditor\VisualEditorHookRunner->onVisualEditorApiVisualEditorEditPostSave(MediaWiki\Page\PageIdentityValue, User, string, array, array, array, array)
#4 /srv/mediawiki/php-1.37.0-wmf.14/includes/api/ApiMain.php(1842): ApiVisualEditorEdit->execute()
#5 /srv/mediawiki/php-1.37.0-wmf.14/includes/api/ApiMain.php(821): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.37.0-wmf.14/includes/api/ApiMain.php(792): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.37.0-wmf.14/api.php(90): ApiMain->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.14/api.php(45): wfApiMain()
#9 /srv/mediawiki/w/api.php(3): require(string)
#10 {main}

Impact

only two errors ( both errors are on arwiki) are reported in logstash
a user will see the following warning

Screen Shot 2021-07-19 at 1.28.04 PM.png (1×1 px, 262 KB)

Details

Request URL: https://ar.wikipedia.org/w/api.php

	Subject	Repo	Branch	Lines +/-
	AddLink: Ensure revision has suggestions before saving	mediawiki/extensions/GrowthExperiments	master	+122 -6

Customize query in gerrit

Related Objects

Mentioned In: T283109: Add link: Edits on Add link articles are automatically removed by subsequent Add link edits
Mentioned Here: T283109: Add link: Edits on Add link articles are automatically removed by subsequent Add link edits

Event Timeline

Etonkovidova created this task.Jul 21 2021, 4:48 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 21 2021, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle added a project: GrowthExperiments.Jul 21 2021, 6:49 PM

Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.

• mewoph added a project: Add-Link.Jul 22 2021, 9:18 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• mewoph moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr mentioned this in T283109: Add link: Edits on Add link articles are automatically removed by subsequent Add link edits.Jul 26 2021, 3:54 PM

The patch for T283109: Add link: Edits on Add link articles are automatically removed by subsequent Add link edits would probably make this less frequent (and in any case add a hook which makes checking for the problem easier).

kostajh triaged this task as Medium priority.Aug 18 2021, 7:55 AM

Change 699410 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Ensure revision has suggestions before saving

https://gerrit.wikimedia.org/r/699410

gerritbot added a project: Patch-For-Review.Aug 18 2021, 7:56 AM

In T287103#7271881, @Tgr wrote:

The patch for T283109: Add link: Edits on Add link articles are automatically removed by subsequent Add link edits would probably make this less frequent (and in any case add a hook which makes checking for the problem easier).

Yeah that patch should prevent this issue. I've tagged this task from the patch and am moving this task into code review as well.

kostajh claimed this task.Aug 18 2021, 9:44 AM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 20 2021, 4:12 AM

Change 699410 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Ensure revision has suggestions before saving

https://gerrit.wikimedia.org/r/699410

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 20 2021, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 20 2021, 5:10 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 24 2021, 11:16 PM

Tested on testwiki wmf.20 for the scenario when the suggestion are not available for an article - "Back to suggested edits" message is displayed; the logstash doesn't have the errors present.

	F34558880: Screen Shot 2021-07-19 at 1.28.04 PM.png
	Jul 21 2021, 4:48 PM

UnexpectedValueException: Tried to submit link suggestion reviews which has already been reviewed.Closed, ResolvedPublicPRODUCTION ERRORActions