Page MenuHomePhabricator
Create Task
Maniphest T287209

GrowthExperiments: consolidate icon modules
Closed, ResolvedPublic
Actions

Description

In order to reduce the number of total modules, consolidate the following:

  • ext.growthExperiments.HelpPanel.icons
  • ext.growthExperiments.Homepage.icons
  • ext.growthExperiments.AddLink.icons

ext.growthExperiments.mobileMenu.icons is only used for mobile and has a different selector than the rest of the icon modules, so it may not make sense to consolidate this as well.

Audit: https://docs.google.com/spreadsheets/d/1_lqo9fLQgJDvVnzxgZBmPHcivLdCXfq9HOWsM7t0F0g/edit#gid=2052908803

Details

SubjectRepoBranchLines +/-
Consolidate HelpPanel, Homepage and Addlink icon modules into ext.growthExperiments.iconsmediawiki/extensions/GrowthExperimentsmaster+68 -83
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mewoph created this task.Jul 22 2021, 7:47 PM
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph updated the task description. (Show Details)Jul 22 2021, 8:29 PM
gerritbot added a comment.Jul 22 2021, 9:06 PM

Change 706757 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Consolidate HelpPanel, Homepage and Addlink icon modules into ext.growthExperiments.icons

https://gerrit.wikimedia.org/r/706757

gerritbot added a project: Patch-For-Review.Jul 22 2021, 9:06 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 22 2021, 9:07 PM
• mewoph mentioned this in T283221: GrowthExperiments adds 2.1K cost to Wikipedia pageviews [alert: Startup threshold exceeded].Jul 22 2021, 10:41 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 5 2021, 5:49 AM
gerritbot added a comment.Aug 5 2021, 6:12 AM

Change 706757 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Consolidate HelpPanel, Homepage and Addlink icon modules into ext.growthExperiments.icons

https://gerrit.wikimedia.org/r/706757

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 5 2021, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2021, 7:10 AM
Etonkovidova closed this task as Resolved.Aug 11 2021, 12:10 AM
Etonkovidova subscribed.

Checked on testwiki wmf.18 - no regression issues are found.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL