Page MenuHomePhabricator

Enable coverage on all WMF deployed and MW bundled skins
Closed, ResolvedPublic

Description

Forking to be seperate from T287913: Enable extension-coverage on most WMF deployed and all MW bundled extensions... As I don't know if we can just apply extension-coverage to all skins, or if we need to do more prep work? Creating skin versions of "mwext-phpunit-coverage-docker-publish" and "mwext-phpunit-coverage-patch-docker", and then putting them under a skin-coverage label?

And we probably want to add something similar to https://doc.wikimedia.org/cover-extensions/ for skins too?

Event Timeline

Change 709557 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/docroot@master] Add cover-skins/index.php

https://gerrit.wikimedia.org/r/709557

Vector has some phpunit tests for example...

Change 709557 merged by jenkins-bot:

[integration/docroot@master] Add cover-skins/index.php

https://gerrit.wikimedia.org/r/709557

Change 709575 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] WIP: Setup cover-skins jobs

https://gerrit.wikimedia.org/r/709575

Change 709744 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Add scripts to quibble-buster-php73-coverage for cover-skins

https://gerrit.wikimedia.org/r/709744

Change 709745 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] JJB changes for cover-skins

https://gerrit.wikimedia.org/r/709745

Change 710627 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Add skin-coverage jobs to all Wikimedia production skins

https://gerrit.wikimedia.org/r/710627

Change 709744 merged by jenkins-bot:

[integration/config@master] dockerfiles: [quibble-buster-php73-coverage] Add scripts for cover-skins

https://gerrit.wikimedia.org/r/709744

Mentioned in SAL (#wikimedia-releng) [2021-08-06T23:53:13Z] <James_F> Docker: Publishing quibble-buster-php73-coverage 1.1.0 for T287918

Change 709745 merged by jenkins-bot:

[integration/config@master] jjb: Add jobs for generating MediaWiki skin PHP code coverage reports

https://gerrit.wikimedia.org/r/709745

Change 709575 merged by jenkins-bot:

[integration/config@master] Zuul: Provide a skin-coverage template

https://gerrit.wikimedia.org/r/709575

Mentioned in SAL (#wikimedia-releng) [2021-08-07T00:27:10Z] <James_F> Zuul: Provide a skin-coverage template T287918

Change 710627 merged by jenkins-bot:

[integration/config@master] Zuul: Add skin-coverage jobs to all Wikimedia production skins

https://gerrit.wikimedia.org/r/710627

Mentioned in SAL (#wikimedia-releng) [2021-08-07T00:29:51Z] <James_F> Zuul: Add skin-coverage jobs to all Wikimedia production skins T287918

Change 710629 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] tests: Assert that all Wikimedia production things have a coverage job

https://gerrit.wikimedia.org/r/710629

Change 710629 merged by jenkins-bot:

[integration/config@master] tests: Assert that all Wikimedia production things have a coverage job

https://gerrit.wikimedia.org/r/710629

Change 710632 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] docker: [quibble-buster-php73-coverage] Add cover-skin argument to phpunit-suit-edit.py

https://gerrit.wikimedia.org/r/710632

Change 710633 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Bump quibble-buster-php73-coverage users to 1.1.1

https://gerrit.wikimedia.org/r/710633

Change 710632 merged by jenkins-bot:

[integration/config@master] docker: [quibble-buster-php73-coverage] Add cover-skin argument to phpunit

https://gerrit.wikimedia.org/r/710632

Mentioned in SAL (#wikimedia-releng) [2021-08-07T00:48:32Z] <James_F> Docker: Publish quibble-buster-php73-coverage 1.1.1 for T287918.

Change 710633 merged by jenkins-bot:

[integration/config@master] jjb: Bump quibble-buster-php73-coverage users to 1.1.1

https://gerrit.wikimedia.org/r/710633

Jdforrester-WMF assigned this task to Reedy.

OK, this is now live for all production skins, and I've triggered builds for all of them via zuul-test-repo mediawiki/skins/MinervaNeue postmerge etc..

(Note that most skins don't have a tests/phpunit.php file, so they don't get a report; the three that do are Vector, MinervaNeue and WikimediaApiPortal.)