| ppelberg | |
| Aug 6 2021, 12:21 AM |
| F34585746: Screen Shot 2021-08-05 at 5.18.51 PM.png | |
| Aug 6 2021, 12:21 AM |
| F34585740: Screen Shot 2021-08-05 at 5.17.55 PM.png | |
| Aug 6 2021, 12:21 AM |
Actual
Expected
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Only show the empty state on talk namespaces | mediawiki/extensions/DiscussionTools | master | +5 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T276497 Scale DiscussionTools to all projects | |||
| Open | None | T251207 [Epic] Scale DiscussionTools to all Wikipedias | |||
| Open | None | T233446 [Epic] New Discussion Tool | |||
| Resolved | None | T275256 Make New Topic Tool (desktop) available as opt-out feature at all wikis | |||
| Resolved | • LZaman | T271964 [Release ticket] Make New Discussion Tool available as opt-out feature at partner wikis | |||
| Resolved | DLynch | T288317 Talk page empty state appearing in project namespace |
It's appearing in any namespace where discussiontools would apply. You'll note that Wikipedia: pages get reply links, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Village_pump911
If we don't want it to appear on a page like this, we'll need to come up with some new heuristic.
I've thought that we intended to add the empty state only for "real" talk pages (that is, the "Talk" and "Blah talk" namespaces). The copy seems to assume that as well, since it refers to the subject page.
T274832 did have a list. I think I can approximate the correct result by checking for "discussion enabled" + $title->isTalkPage()
Change 710611 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/DiscussionTools@master] Only show the empty state on talk namespaces
Change 710611 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Only show the empty state on talk namespaces