| ovasileva | |
| Aug 10 2021, 4:41 PM |
| F34630873: Screen Shot 2021-09-03 at 6.38.09 AM.png | |
| Sep 3 2021, 1:39 PM |
| F34630871: Screen Shot 2021-09-03 at 6.36.37 AM.png | |
| Sep 3 2021, 1:39 PM |
| F34627765: Screen Shot 2021-09-01 at 5.27.43 AM.png | |
| Sep 3 2021, 1:33 PM |
| F34618149: Screen Shot 2021-08-23 at 3.10.53 PM.png | |
| Aug 23 2021, 7:11 PM |
| F34607451: Screen Shot 2021-08-19 at 7.14.07 PM.png | |
| Aug 19 2021, 11:17 PM |
| F34607448: image.png | |
| Aug 19 2021, 11:17 PM |
| F34590798: image.png | |
| Aug 11 2021, 7:23 PM |
| F34590596: Screen Shot 2021-08-11 at 10.59.20 AM.png | |
| Aug 11 2021, 3:02 PM |
Currently the Uploads menu item on Commons is missing an icon.
Icon to use: imageGallery
https://doc.wikimedia.org/oojs-ui/master/demos/dist/themes/wikimediaui/images/icons/imageGallery.svg
| Wikipedia | Commons |
|---|---|
 |  |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T288541#7330929 |
| 2 | ✅ | T288541#7330929 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T288541#7330939 |
| 2 | ✅ | T288541#7330939 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T266536 [EPIC] Consolidate user links into a single menu | |||
| Resolved | BUG REPORT | ovasileva | T288541 [User links] Add/replace icon for "Uploads" menu item |
This is an issue in the extension UploadsLink (not sure who maintains that)
The menu item doew not specify an icon key, and when that happens, we do not show an icon, so this is working as expected, but easy enough to fix:
https://gerrit.wikimedia.org/g/mediawiki/extensions/UploadsLink/+/4d9da4ba15af0e85717041f10aaf8b1e4cd6cf11/includes/UploadsLinkHooks.php#37
What icon should be shown here?
https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons&theme=wikimediaui&direction=ltr&platform=desktop
@Jdlrobson I'm looking at the differences between the Uploaded media item in Wikipedia user menu, and the Uploads item in the Commons user menu. They both seem to lead to the same page, though the URLs are slightly different:
| from Wikipedia | from Commons |
| https://commons.wikimedia.org/wiki/Special:ListFiles/AHollender_(WMF) | https://commons.wikimedia.org/w/index.php?title=Special:ListFiles/AHollender_(WMF)&ilshowall=1 |
On Wikipedia we use the Commons logo for that menu item:
| legacy Vector | Vector |
 |  |
In Legacy vector there isn't an icon for the menu item on Commons.
@mwilliams curious what you think might be best here? Some options I see:
I'm not sure if I have all the right context here and I'm having some trouble reproducing everything on my own but my initial reaction is either your first or third option Alex.
• Use the Commons icon on Wikipedia, and the standard Upload icon on Commons
• Use the standard Upload icon on both Wikipedia & Commons
Using the Commons icon to mean something while already on Commons seems like a stretch. I don't mind it not being consistent between the two with option 1, since it could help folks know that uploaded media happens on Commons. Also makes me wonder if we need any indication that this link will open up a new page/site. Option 3 seems like a safe and consistent approach.
Would imageGallery make sense?
@AntiCompositeNumber imageGallery makes sense to me, and I imagine is more meaningful to newcomers than the Commons logo. Here is how it looks:
| Wikipedia | Commons |
|---|---|
| |
@mwilliams thoughts?
Change 714603 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/extensions/ContentTranslation@master] Update 'Uploaded media' menu link icon from logoWikimediaCommons to imageGallery
Change 714602 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Add imageGallery icon for UploadsLink and ContentTranslation menu links
Change 714600 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/extensions/UploadsLink@master] Define an icon so the UploadsLink displays properly in Vector's user menu
Change 714602 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add imageGallery icon for UploadsLink and ContentTranslation menu links
Change 714603 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Update 'Uploaded media' menu link icon from logoWikimediaCommons to imageGallery
Change 714600 merged by jenkins-bot:
[mediawiki/extensions/UploadsLink@master] Define an icon so the UploadsLink displays properly in Vector's user menu
Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
add an icon to Uploads menu item on Commons
update the icon for the Uploaded media in the Wikipedia so it matches
Icon to use: imageGallery
https://doc.wikimedia.org/oojs-ui/master/demos/dist/themes/wikimediaui/images/icons/imageGallery.svg
⬜ AC1: Wikipedia
Not available on beta. Alex says Jon may have to change something on beta. Low design risk so prod test is acceptable.
✅ AC2: Commons
Status: ✅ PASS
Environment: enwiki, commons
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
add an icon to Uploads menu item on Commons
update the icon for the Uploaded media in the Wikipedia so it matches
Icon to use: imageGallery
https://doc.wikimedia.org/oojs-ui/master/demos/dist/themes/wikimediaui/images/icons/imageGallery.svg
✅ AC1: Wikipedia
✅ AC2: Commons
