(screenshot from T271673#7271224)
- General investigate of what is happening here... and from there, should we remove infobox from mobile or should we fix it?
Outcomes
- tl;dr: T288718#7562543
- T288718#7562836
• Prtksxna | |
Aug 12 2021, 5:14 AM |
F34877004: 1.png | |
Dec 10 2021, 1:49 PM |
F34877005: 2.png | |
Dec 10 2021, 1:49 PM |
F34876956: 1.png | |
Dec 10 2021, 12:37 PM |
F34590035: Screen Shot 2021-08-10 at 10.30.43 PM.png | |
Aug 12 2021, 5:14 AM |
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
DNM: infobox: Make infobox work on the mobile site | mediawiki/extensions/IPInfo | master | +17 -4 |
In a way, this was fixed by @TThoabala in T293011: Infobox (accordion) is inserted before partial block notice [M] 🎉 In that task we started inserting the infobox via the SpecialContributionsBeforeMainOutput hook. The mobile site's version of the contributions page doesn't fire that hook and so the broken infobox no longer appears on the mobile site:
Change 745835 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/IPInfo@master] DNM: infobox: Make infobox work on the mobile site
Change 745835 abandoned by Phuedx:
[mediawiki/extensions/IPInfo@master] DNM: infobox: Make infobox work on the mobile site
Reason:
Change 745835 restored by Phuedx:
[mediawiki/extensions/IPInfo@master] DNM: infobox: Make infobox work on the mobile site
Change 745835 abandoned by Phuedx:
[mediawiki/extensions/IPInfo@master] DNM: infobox: Make infobox work on the mobile site
Reason:
Following on from my comment above, I decided to revert @TThoabala's patch for T293011: Infobox (accordion) is inserted before partial block notice [M] and document the steps we'd need to take to get the infobox working-ish on the mobile site with as few modifications as possible. What follows are a couple of screenshots of my local development wiki and notes on how I got it to that state:
Collapsed | Expanded |
---|---|
var revId = $( '.mw-contributions-list [data-mw-revid]' ).first().attr( 'data-mw-revid' ); // Support Special:Contributions on the mobile site if ( !revId ) { revId = $( '.page-list .page-summary a.title' ) .first() .attr( 'href' ) .split( '/' ) .pop(); }
1 & 2 are easy lifts. 3, on the other hand presents us with an opportunity to tidy up the infobox init script. We could and should consider:
To summarise: we can get this working on mobile. With a few small fixes it would look like the screenshots in T288718#7562836.
@Prtksxna If you could confirm whether the infobox should be available on mobile, and if so, what it should look like, we can create some tasks and get working on it.
Yes, we should have the box on mobile - I've added started adding some details on T268177: Make IPInfo available on mobile