Page MenuHomePhabricator
Create Task
Maniphest T288852

Drop user links feature flag
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Aug 13 2021, 6:30 PM
Tags
Referenced Files
F34649812: Screen Shot 2021-09-21 at 6.46.54 AM.png
Sep 21 2021, 1:47 PM
F34649810: Screen Shot 2021-09-21 at 6.46.11 AM.png
Sep 21 2021, 1:47 PM
F34649814: Screen Shot 2021-09-21 at 6.47.04 AM.png
Sep 21 2021, 1:47 PM
F34649808: Screen Shot 2021-09-21 at 6.45.52 AM.png
Sep 21 2021, 1:47 PM
F34626868: Screen Shot 2021-08-31 at 9.52.08 AM.png
Aug 31 2021, 4:56 PM
F34626866: Screen Shot 2021-08-31 at 9.50.46 AM.png
Aug 31 2021, 4:56 PM
F34626870: Screen Shot 2021-08-31 at 9.52.36 AM.png
Aug 31 2021, 4:56 PM
F34626872: Screen Shot 2021-08-31 at 9.52.24 AM.png
Aug 31 2021, 4:56 PM
Subscribers
Aklapper
bwang
cjming
Edtadros
Jdlrobson

Description

Now that user links is enabled everywhere, we can drop the associated feature flag and code. This will simplify the code and our ability to test, and reduce the amount of CSS/JS we ship to end users.

Risk: Be careful not to turn the user links into a drop down in legacy Vector.

A/C

  • Drop VectorConsolidateUserLinks config flag.
  • Skin::shouldConsolidateUserLinks is removed. In some cases replace the code with $this->isLegacy()
  • Drop any unused CSS relating to supporting modern Vector without user links into legacy mode.
  • Drop references to is-consolidated-user-links template variable
  • Retain vector-search-box-collapses and vector-search-box-show-thumbnail classes.

QA

  • Make sure legacy Vector still shows the user links as a flat horizontal list of links
  • Make sure modern Vector shows the dropdown

QA Results - Beta

ACStatusDetails
1✅T288852#7322331
2✅T288852#7322331

QA Results - Prod

ACStatusDetails
1✅T288852#7369018
2✅T288852#7369018

Details

SubjectRepoBranchLines +/-
[refactor] Remove common UserLinks codemediawiki/skins/Vectormaster+12 -37
Remove user links feature flagmediawiki/skins/Vectormaster+82 -430
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 13 2021, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2021, 6:30 PM
Jdlrobson triaged this task as High priority.Aug 13 2021, 6:31 PM
Jdlrobson mentioned this in T287637: [GOAL] Deploy the new user links feature to all wikis.
ovasileva lowered the priority of this task from High to Medium.Aug 16 2021, 5:37 PM
LGoto set the point value for this task to 3.Aug 16 2021, 5:39 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming claimed this task.Aug 18 2021, 12:28 AM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson merged a task: T286737: Remove user links feature flag.Aug 19 2021, 10:30 PM
Jdlrobson added a subscriber: cjming.
gerritbot added a comment.Aug 24 2021, 9:39 PM

Change 714639 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Remove user links feature flag

https://gerrit.wikimedia.org/r/714639

gerritbot added a project: Patch-For-Review.Aug 24 2021, 9:39 PM
cjming removed cjming as the assignee of this task.Aug 24 2021, 9:57 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Aug 25 2021, 1:08 AM
cjming claimed this task.Aug 25 2021, 1:39 AM
cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming removed cjming as the assignee of this task.Aug 25 2021, 2:17 PM
cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Aug 25 2021, 4:45 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Aug 25 2021, 10:27 PM
cjming removed Jdlrobson as the assignee of this task.Aug 26 2021, 4:51 PM
cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang claimed this task.Aug 26 2021, 5:01 PM
Jdlrobson added a comment.Aug 26 2021, 6:35 PM

Remaining work:

  • We need to address the FIXME resources/skins.vector.styles/components/UserLinks.less
  • Once the code above is deployed we'll need to cleanup mediawiki-config to remove the rules $wgVectorConsolidateUserLinks (we can file a follow up task for that as part of sign off)
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Aug 26 2021, 6:35 PM
gerritbot added a comment.Aug 26 2021, 6:49 PM

Change 714639 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove user links feature flag

https://gerrit.wikimedia.org/r/714639

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 26 2021, 7:00 PM
bwang removed bwang as the assignee of this task.Aug 26 2021, 7:01 PM
bwang assigned this task to Jdlrobson.
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang subscribed.
Maintenance_bot removed a project: Patch-For-Review.Aug 26 2021, 7:10 PM
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Aug 30 2021, 5:49 PM
Jdlrobson removed Jdlrobson as the assignee of this task.EditedAug 30 2021, 6:45 PM
Jdlrobson moved this task from Doing to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

I'm addressing the rest of the clean up inside T283757.

Worth running the two smoke tests in description as part of QA.

Jdlrobson assigned this task to Edtadros.Aug 30 2021, 6:46 PM
Jdlrobson moved this task from Ready for Signoff to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.EditedAug 31 2021, 4:56 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Make sure legacy Vector still shows the user links as a flat horizontal list of links

Screen Shot 2021-08-31 at 9.50.46 AM.png (225×1 px, 79 KB)

Screen Shot 2021-08-31 at 9.52.08 AM.png (225×1 px, 87 KB)

✅ AC2: Make sure modern Vector shows the dropdown

Screen Shot 2021-08-31 at 9.52.36 AM.png (364×1 px, 72 KB)

Screen Shot 2021-08-31 at 9.52.24 AM.png (364×1 px, 112 KB)

Edtadros updated the task description. (Show Details)Aug 31 2021, 4:57 PM
Jdlrobson moved this task from QA in Prod to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 2 2021, 10:05 PM
gerritbot added a comment.Sep 2 2021, 10:06 PM

Change 716585 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [refactor] Remove common UserLinks code

https://gerrit.wikimedia.org/r/716585

gerritbot added a project: Patch-For-Review.Sep 2 2021, 10:06 PM
Jdlrobson added a comment.Sep 2 2021, 10:06 PM

I found something else that can be cleaned up so moving back to code review ^^^

Jdlrobson removed Edtadros as the assignee of this task.Sep 2 2021, 10:07 PM
Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: Edtadros.
bwang claimed this task.Sep 3 2021, 4:58 PM
gerritbot added a comment.Sep 7 2021, 4:31 PM

Change 716585 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [refactor] Remove common UserLinks code

https://gerrit.wikimedia.org/r/716585

Jdlrobson reassigned this task from bwang to Edtadros.Sep 7 2021, 4:40 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.23; 2021-09-13); removed MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Sep 7 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 5:11 PM
Edtadros reassigned this task from Edtadros to ovasileva.Sep 21 2021, 1:47 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Make sure legacy Vector still shows the user links as a flat horizontal list of links

Screen Shot 2021-09-21 at 6.45.52 AM.png (491×1 px, 299 KB)

Screen Shot 2021-09-21 at 6.47.04 AM.png (491×1 px, 379 KB)

✅ AC2: Make sure modern Vector shows the dropdown

Screen Shot 2021-09-21 at 6.46.11 AM.png (491×1 px, 260 KB)

Screen Shot 2021-09-21 at 6.46.54 AM.png (491×1 px, 294 KB)

Edtadros updated the task description. (Show Details)Sep 21 2021, 1:48 PM
ovasileva closed this task as Resolved.Sep 21 2021, 4:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL