Add tags parameter to WikibaseLexeme editing APIs
Closed, ResolvedPublic
Actions

Description

All the WikibaseLexeme APIs that make edits should have a tags parameter to apply tags to the edit:

wbladdform
wblremoveform
wbleditformelements
wbladdsense
wblremovesense
wbleditsenseelements
wblmergelexemes

Compare T286778: Add tags parameter to wbmergeitems API for a similar task in Wikibase.

Details

Subject	Repo	Branch	Lines +/-
Add missing i18n messages for new tags params	mediawiki/extensions/WikibaseLexeme	master	+14 -0
Add tags parameter to editing api modules	mediawiki/extensions/WikibaseLexeme	master	+216 -22
Use lastrevid from base response if existing	mediawiki/extensions/Wikibase	master	+3 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	Manuel	T343037 [EPIC] Segmentation of Wikidata editing clients [up to milestone 2]
Resolved	Manuel	T236893 Tag all edits made via Wikibase View and Wikibase Client
Resolved	Lucas_Werkmeister_WMDE	T290951 Add tags parameter to WikibaseLexeme editing APIs

Event Timeline

Manuel created this task.Sep 14 2021, 9:42 AM

• toan claimed this task.Sep 14 2021, 2:33 PM

• toan moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

• toan removed • toan as the assignee of this task.Sep 14 2021, 2:40 PM

• toan moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

• toan subscribed.

• toan claimed this task.Sep 14 2021, 2:46 PM

• toan moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Lucas_Werkmeister_WMDE renamed this task from Add tags support to WikibaseLexeme extension to Add tags parameter to WikibaseLexeme editing APIs.Sep 14 2021, 3:20 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

matej_suchanek unsubscribed.Sep 14 2021, 3:59 PM

Change 721278 had a related patch set uploaded (by Tobias Andersson; author: Tobias Andersson):

[mediawiki/extensions/Wikibase@master] Use lastrevid from base response if existing

https://gerrit.wikimedia.org/r/721278

gerritbot added a project: Patch-For-Review.Sep 15 2021, 11:05 AM

Change 721020 had a related patch set uploaded (by Tobias Andersson; author: Tobias Andersson):

[mediawiki/extensions/WikibaseLexeme@master] Add tags parameter to editing api modules

https://gerrit.wikimedia.org/r/721020

• toan moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 15 2021, 12:54 PM

Change 721278 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use lastrevid from base response if existing

https://gerrit.wikimedia.org/r/721278

Change 721020 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add tags parameter to editing api modules

https://gerrit.wikimedia.org/r/721020

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 16 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2021, 6:10 PM

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 16 2021, 8:40 PM

Will be verifiable on test at some point

https://test.wikidata.org/w/api.php?action=help&modules=wbladdform
https://test.wikidata.org/w/api.php?action=help&modules=wbladdsense
https://test.wikidata.org/w/api.php?action=help&modules=wbleditformelements
https://test.wikidata.org/w/api.php?action=help&modules=wbleditsenseelements
https://test.wikidata.org/w/api.php?action=help&modules=wblremoveform
https://test.wikidata.org/w/api.php?action=help&modules=wblremovesense
https://test.wikidata.org/w/api.php?action=help&modules=wblmergelexemes

Addshore reassigned this task from • toan to Manuel.Sep 21 2021, 2:12 PM

Lucas_Werkmeister_WMDE merged a task: T229919: Add tags parameter to WikibaseLexeme APIs that edit entities.Sep 21 2021, 3:59 PM

Lucas_Werkmeister_WMDE mentioned this in T290950: Tag edits made via WikibaseLexeme .

it seems tags parameter does not have i18n message set properly: https://test.wikidata.org/w/api.php?action=help&modules=wbladdform

Lucas_Werkmeister_WMDE claimed this task.Sep 22 2021, 8:11 AM

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 722821 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add missing i18n messages for new tags params

https://gerrit.wikimedia.org/r/722821

gerritbot added a project: Patch-For-Review.Sep 22 2021, 8:20 AM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 22 2021, 8:20 AM

In T290951#7371210, @gerritbot wrote:

Change 722821 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add missing i18n messages for new tags params

https://gerrit.wikimedia.org/r/722821

We decided in the daily meeting that we probably don’t need to backport this (as it would require a “full scap”, if I’m not mistaken).

Change 722821 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add missing i18n messages for new tags params

https://gerrit.wikimedia.org/r/722821

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 22 2021, 11:06 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 11:10 AM

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.2; 2021-09-28); removed MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 22 2021, 12:00 PM

Addshore closed this task as Resolved.Oct 18 2021, 8:50 AM