Page MenuHomePhabricator

On MentorDashboard the Message to your mentees is not used if the mentor is on the manual list
Closed, ResolvedPublicBUG REPORT


List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • The "Message to your mentees" will show the project default message

What should have happened instead?:

  • The message you declared on the mentor list should be shown

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Note sure what the "best" answer is if there is a collision (i.e. the mentor exists on both lists)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh subscribed.

I suppose what needs to happen is for getCustomMentorIntroText and getMentorsPageContent in includes/Mentorship/MentorPageMentorManager.php to also check the contents of the manual listing page.

Technically speaking, the mentor dashboard displays the "right" information: the newcomer homepage is consistent, and the message is not being used there as well. Retagging with GrowthExperiments-Mentorship instead, as it's not something the mentor dashboard does incorrectly.

T264343: Have a special page for mentors to sign up is likely the ideal/dream way of solving this issue (and similar ones). It's much easier to consume the message from a structurred data source.

Change 823124 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WikitextMentorProvider: Recognize mentor message in manual mentor list

Urbanecm_WMF raised the priority of this task from Low to High.

Noticed again when working on T310906: Review existing wikitext-based mentor lists for inconsistencies/errors. We plan to switch to structured mentor list soon, and fixing this bug will help with that (to ensure the message is not lost as the list is migrated). This is not a blocker for rollout to pilots, as it only affects arwiki (which has two affected mentors => easily fixable during rollout), but it is a blocker for a wider rollout.

Urbanecm_WMF changed the task status from Open to In Progress.Aug 15 2022, 5:50 PM
Tgr changed the task status from In Progress to Open.Aug 16 2022, 1:57 AM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 823124 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] WikitextMentorProvider: Recognize mentor message in manual mentor list