Page MenuHomePhabricator
Create Task
Maniphest T291718

Change meaning of "hidden" prop in ApiQueryAbuseLog
Closed, ResolvedPublic
Actions

Description

The API module QueryAbuseLog has "hidden" amongst the props available in "aflprop". Currently, for a given AbuseLog entry, its value is:

  1. None (absent in the response) if the entry is visible
  2. "true" if the entry was specifically suppressed by an oversighter
  3. "implicit" if the entry wasn't suppressed, but it refers to a revision that was deleted/suppressed

The latter is something that we don't want to be there, because it complicates maintenance; hence, it's going to be removed. Users can still do the revision check on their own if they need to.

Additionally, if the "hidden" prop was requested, it will always be included in the response, so in case 1. above it will have value "false".

Details

SubjectRepoBranchLines +/-
Remove SpecialAbuseLog::isHiddenmediawiki/extensions/AbuseFiltermaster+20 -33
Customize query in gerrit

Event Timeline

Daimona created this task.Sep 25 2021, 1:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2021, 1:39 AM
Daimona moved this task from To Triage to Announce in next Tech/News on the User-notice board.Sep 25 2021, 1:39 AM
gerritbot added a comment.Sep 25 2021, 1:39 AM

Change 721398 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@master] Remove SpecialAbuseLog::isHidden

https://gerrit.wikimedia.org/r/721398

gerritbot added a project: Patch-For-Review.Sep 25 2021, 1:39 AM
Daimona claimed this task.Sep 25 2021, 1:39 AM
Jdforrester-WMF moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Sep 25 2021, 2:04 AM
Jdforrester-WMF subscribed.

https://meta.wikimedia.org/w/index.php?title=Tech/News/2021/40&diff=22067615&oldid=22066958&diffmode=source

• Suran38 added a subtask: T291730: Remove javascript config setting wgCommentByteLimit.Sep 25 2021, 8:23 AM
DannyS712 removed a subtask: T291730: Remove javascript config setting wgCommentByteLimit.Sep 25 2021, 8:43 AM
Daimona updated the task description. (Show Details)Sep 25 2021, 10:32 AM
Daimona added a comment.Sep 25 2021, 10:35 AM

Updated the task description for another change to the prop (done in the same patch), and updated tech news accordingly: https://meta.wikimedia.org/w/index.php?title=Tech/News/2021/40&diff=22068332&oldid=22067615

Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Oct 7 2021, 7:41 PM
MdsShakil subscribed.Oct 8 2021, 8:01 PM

Can this change cause problems for any user gadget (ex. Twinkle)?

Aklapper added a comment.Oct 10 2021, 12:06 PM

@MdsShakil: Why would you ask that? :) Please share your train of thoughts. Thanks.

Daimona added a comment.Oct 11 2021, 1:38 PM
In T291718#7413442, @MdsShakil wrote:

Can this change cause problems for any user gadget (ex. Twinkle)?

Yes, if such user scripts are using the afl_hidden property of the queryabuselog API module.

MdsShakil added a comment.Oct 11 2021, 1:53 PM
In T291718#7415162, @Aklapper wrote:

@MdsShakil: Why would you ask that? :) Please share your train of thoughts. Thanks.

I asked after seeing this change in weekly tech news because Bengali Wikipedia Twinkle was not working suddenly. But Twinkle's problem was due to this Mediawiki change.(https://www.mediawiki.org/wiki/MediaWiki_1.37/Deprecation_of_legacy_API_token_parameters)

gerritbot added a comment.Mar 27 2022, 6:27 PM

Change 721398 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Remove SpecialAbuseLog::isHidden

https://gerrit.wikimedia.org/r/721398

Daimona closed this task as Resolved.Mar 27 2022, 6:29 PM
Daimona removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 27 2022, 7:00 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL