Page MenuHomePhabricator

Change meaning of "hidden" prop in ApiQueryAbuseLog
Open, Needs TriagePublic

Description

The API module QueryAbuseLog has "hidden" amongst the props available in "aflprop". Currently, for a given AbuseLog entry, its value is:

  1. None (absent in the response) if the entry is visible
  2. "true" if the entry was specifically suppressed by an oversighter
  3. "implicit" if the entry wasn't suppressed, but it refers to a revision that was deleted/suppressed

The latter is something that we don't want to be there, because it complicates maintenance; hence, it's going to be removed. Users can still do the revision check on their own if they need to.

Additionally, if the "hidden" prop was requested, it will always be included in the response, so in case 1. above it will have value "false".

Event Timeline

Change 721398 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@master] Remove SpecialAbuseLog::isHidden

https://gerrit.wikimedia.org/r/721398

Updated the task description for another change to the prop (done in the same patch), and updated tech news accordingly: https://meta.wikimedia.org/w/index.php?title=Tech/News/2021/40&diff=22068332&oldid=22067615

Can this change cause problems for any user gadget (ex. Twinkle)?

@MdsShakil: Why would you ask that? :) Please share your train of thoughts. Thanks.

Can this change cause problems for any user gadget (ex. Twinkle)?

Yes, if such user scripts are using the afl_hidden property of the queryabuselog API module.

@MdsShakil: Why would you ask that? :) Please share your train of thoughts. Thanks.

I asked after seeing this change in weekly tech news because Bengali Wikipedia Twinkle was not working suddenly. But Twinkle's problem was due to this Mediawiki change.(https://www.mediawiki.org/wiki/MediaWiki_1.37/Deprecation_of_legacy_API_token_parameters)