Page MenuHomePhabricator

When I make a link to [[w:es:Jimmy Wales]], don't turn that into [[es:Jimmy Wales]]
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Create a link to a page at another wiki in the visual mode by opening the link box and typing w:es:Jimmy Wales
  • Post comment.
  • Wonder why w:es:Jimmy Wales isn't visible in the posted comment.

What happens?:

The software twisted the link into [[es:Jimmy Wales|w:es:Jimmy Wales]], which is the wrong kind of link. Interwiki and interlanguage links are not interchangeable in practice.

Example

Related Objects

Event Timeline

Perhaps-interestingly, I can't reproduce this in the API sandbox.

requestresponse
on page
image.png (268×1 px, 35 KB)
image.png (80×656 px, 8 KB)
in sandbox
image.png (206×1 px, 39 KB)
image.png (166×666 px, 17 KB)

I'll also confirm that although this was demonstrated in DiscussionTools, you can also reproduce it in regular old VisualEditor.

I have a vague memory about an old bug about this same thing that Sherry had filed, and I thought we had fixed it.

Arlolra triaged this task as Medium priority.EditedSep 30 2021, 8:22 PM
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Arlolra subscribed.

VE gives,

<a href="./W:es:Jimmy%20Wales" rel="mw:WikiLink">w:es:Jimmy Wales</a>

which Parsoid turns into,

[[es:Jimmy Wales|w:es:Jimmy Wales]]

https://github.com/wikimedia/parsoid/commit/7188438cfe is a patch where Parsoid gains a preference for language prefixes, but that maybe needs refining based on the link content.

Change 731211 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/services/parsoid@master] Fix serializing links using local interwiki plus language link

https://gerrit.wikimedia.org/r/731211

Change 731211 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix serializing links using local interwiki plus language link

https://gerrit.wikimedia.org/r/731211

Change 744807 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a12

https://gerrit.wikimedia.org/r/744807

Change 744807 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a12

https://gerrit.wikimedia.org/r/744807

Change 744800 had a related patch set uploaded (by C. Scott Ananian; author: Subramanya Sastry):

[mediawiki/vendor@wmf/1.38.0-wmf.12] Bump wikimedia/parsoid to 0.15.0-a12

https://gerrit.wikimedia.org/r/744800

Change 744800 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.38.0-wmf.12] Bump wikimedia/parsoid to 0.15.0-a12

https://gerrit.wikimedia.org/r/744800

Screenshot 2021-12-16 at 17.18.16.png (512×950 px, 78 KB)
produces
Screenshot 2021-12-16 at 17.19.29.png (395×1 px, 50 KB)
with visible link.

Screenshot 2021-12-16 at 17.22.41.png (262×994 px, 38 KB)
as expected.