Page MenuHomePhabricator

No notification for reply to mentor question without ping
Closed, DuplicatePublicBUG REPORT

Description

I did a small test of the feature for asking my mentor a question. My test account asked my mentor (conveniently myself) a question. Then my mentor (me) replied, but without mentioning/pinging my test account's username. This did not result in a notification for my test account, but I'm pretty sure mentees would expect a notification regardless – especially since the software tells you to expect a notification when there is a reply.

List of steps to reproduce (step by step, including full links if applicable):

  • Ask a question to your mentor from Special:Homepage
  • Have the mentor reply without pinging (mentioning) the mentee

What happens?: No notification for the mentee.

What should have happened instead?: Notification for the mentee.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc: MediaWiki 1.38.0-wmf.3, GrowthExperiments cc698e9

My suggestion would be to somehow integrate the mentee question thread that is created with the awesome new subscribe feature from the DiscussionTools extension.

Event Timeline

jhsoby updated the task description. (Show Details)

Thank you for reporting this,@jhsoby. We already have a task about it. We will soon start working on consolidating mentor features, including this feature request.

kostajh added subscribers: RHo, kostajh.

Moving to needs discussion / analysis. As far as I can tell, what we would want to do is switch the help panel / mentorship question ask feature to use ApiDiscussionToolsEdit, and then we'd get the subscribe functionality for free (and also remove our custom ApiHelpPanelPostQuestion.php code). Sounds like a win-win to me. We'd need to add on the change tag for the help / mentorship panel, but that shouldn't be hard.

@MMiller_WMF @RHo do you have any product concerns with using DiscussionTools API for creating the new section on a mentor's talk page when a question is asked via the help panel?

Moving to needs discussion / analysis. As far as I can tell, what we would want to do is switch the help panel / mentorship question ask feature to use ApiDiscussionToolsEdit, and then we'd get the subscribe functionality for free (and also remove our custom ApiHelpPanelPostQuestion.php code). Sounds like a win-win to me. We'd need to add on the change tag for the help / mentorship panel, but that shouldn't be hard.

@MMiller_WMF @RHo do you have any product concerns with using DiscussionTools API for creating the new section on a mentor's talk page when a question is asked via the help panel?

hiya - same as my comment at T272146#7423107 - this sounds like a fab idea and mainly would like check iwith @Urbanecm_WMF in case it causes issues with mentor dashboard, and to fix those as well if so.