Focus lost when tabbing into a VE surface
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• ppelberg
	Oct 26 2021, 11:06 PM

Description

This task is about adjusting what part of the New Discussion Tool comes into focus when pressing the ⇥ key.

Behavior

Visit a talk page on a wiki where you have the New Discussion Tool enabled. E.g. https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats .
Open the New Discussion Tool by clicking the Add topic affordance at the top of the talk page
Notice the New Discussion Tool opens, with your cursor/browser's focus in the Title field
Press ⇥
Notice the Source tab above the Description field comes into focus (you should see a square box around it)
Press ⇥

Expected

✅ Your cursor is shown within the New Discussion Tool's Description frield

Actual

❗️The New Discussion Tool becomes "out of focus." Said another way: no part of the New Discussion Tool is shown in active state.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (2cd3eb52d)	mediawiki/extensions/VisualEditor	master	+1 -1
	Follow-up I61b477d1: Use setTimeout instead of afterLoopOne	VisualEditor/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T294873: Unable to "Change text" for link in thumbnail caption
T294701: (Regression) VisualEditor/2017 source editor text cursor keeps going inactive
Mentioned Here: T293661: Clicking from text to a link in iOS Safari doesn't open the link context
rGVED6f310f990c6d: Prevent iOS Safari from re-focusing the doc when clicking on links

Event Timeline

• ppelberg created this task.Oct 26 2021, 11:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2021, 11:06 PM

• ppelberg moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.Oct 26 2021, 11:06 PM

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

Note: the default mode should be visual for this bug to surface. If the default mode is source (as is the global default for this beta wiki), it works as expected. (At least for me, logged out, in a private window.)

It affects source mode also, but only if the enhanced editor is enabled ("Enable editing tools in source mode").

Apparently that's disabled on the beta cluster, which seems wrong to me (it's enabled on all production wikis). But that's a separate problem. (fixing in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/735014)

Caused by this VisualEditor change: rGVED6f310f990c6d: Prevent iOS Safari from re-focusing the doc when clicking on links (@Esanders).

In T294394#7461776, @matmarex wrote:

Caused by this VisualEditor change: rGVED6f310f990c6d: Prevent iOS Safari from re-focusing the doc when clicking on links (@Esanders).

..which is T293661

Change 735402 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I61b477d1: Use setTimeout instead of afterLoopOne

https://gerrit.wikimedia.org/r/735402

gerritbot added a project: Patch-For-Review.Oct 28 2021, 3:14 PM

Esanders moved this task from Upcoming to Code Review on the Editing-team (Kanban Board) board.Oct 28 2021, 3:18 PM

Esanders added projects: VisualEditor, VisualEditor-ContentEditable.

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Change 735402 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I61b477d1: Use setTimeout instead of afterLoopOne

https://gerrit.wikimedia.org/r/735402

Change 735448 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2cd3eb52d)

https://gerrit.wikimedia.org/r/735448

Aklapper added a project: Accessibility.Oct 28 2021, 8:53 PM

Change 735448 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2cd3eb52d)

https://gerrit.wikimedia.org/r/735448

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2021, 9:10 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 28 2021, 9:47 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Oct 28 2021, 10:00 PM

This works fine. I opened the New Discussion Tool by clicking the New Section link at the top of the page and got the expected result. I have attached screenshots for reference.

Screenshot 2021-10-30 at 11.05.59.png (902×1 px, 142 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Oct 30 2021, 10:19 AM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

matmarex mentioned this in T294701: (Regression) VisualEditor/2017 source editor text cursor keeps going inactive.Oct 31 2021, 8:56 PM

matmarex mentioned this in T294873: Unable to "Change text" for link in thumbnail caption.Nov 4 2021, 3:42 PM

• ppelberg closed this task as Resolved.Nov 6 2021, 12:38 AM

• ppelberg claimed this task.

	F34716540: Screenshot 2021-10-30 at 11.12.30.png
	Oct 30 2021, 10:19 AM

	F34716525: Screenshot 2021-10-30 at 11.05.59.png
	Oct 30 2021, 10:19 AM

Focus lost when tabbing into a VE surfaceClosed, ResolvedPublicBUG REPORTActions