Page MenuHomePhabricator
Create Task
Maniphest T293661

Clicking from text to a link in iOS Safari doesn't open the link context
Closed, ResolvedPublic
Actions

Description

  1. Open VE Mobile in iOS Safari
  2. Click in plain text bringing up the keyboard
  3. Click on a link

Expected

  1. The link context opens

Observed

  1. The link becomes active (white), no link context is shown and no keyboard is shown either.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (0a909d09a)mediawiki/extensions/VisualEditormaster+1 -1
Follow-up I61b477d1f: Only remove native ranges if the are inside the documentVisualEditor/VisualEditormaster+1 -1
Prevent iOS Safari from re-focusing the doc when clicking on linksVisualEditor/VisualEditormaster+7 -0
Update VE core submodule to master (7e8550432)mediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Oct 18 2021, 3:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2021, 3:48 PM
Esanders mentioned this in T274068: Can't place cursor to the right of a link at the end of paragraph (beyond the cartouche/nail) by clicking..Oct 18 2021, 3:52 PM
gerritbot added a comment.Oct 18 2021, 3:55 PM

Change 731776 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Prevent iOS Safari from re-focusing the doc when clicking on links

https://gerrit.wikimedia.org/r/731776

gerritbot added a project: Patch-For-Review.Oct 18 2021, 3:55 PM
Esanders added a project: Editing-team (Kanban Board).Oct 18 2021, 3:55 PM
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
Esanders moved this task from To Triage to Triaged on the VisualEditor board.
dchan subscribed.Oct 19 2021, 10:22 AM

Hmm, can't reproduce the behaviour on iOS 12. Can you give a specific minimal example (exactly what content, where to click etc)?

matmarex subscribed.Oct 20 2021, 7:11 PM

I can reproduce on iOS 14.8, testing on https://en.wikipedia.org/wiki/The_Fighting_Temeraire. I'm pretty sure this did not occur on some earlier versions.

IMG_0683.MOV2 MBDownload

Note how upon the tap on "oil painting", I get a text cursor (but no keyboard). Afterwards after tapping on different links I get the link context.

matmarex renamed this task from Clicking from text to a link in iOS Safari doesn't open the link inspector to Clicking from text to a link in iOS Safari doesn't open the link context.Oct 20 2021, 7:12 PM
matmarex updated the task description. (Show Details)
gerritbot added a comment.Oct 21 2021, 5:41 PM

Change 731776 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Prevent iOS Safari from re-focusing the doc when clicking on links

https://gerrit.wikimedia.org/r/731776

Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 21 2021, 5:59 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 6:10 PM
gerritbot added a comment.Oct 21 2021, 6:26 PM

Change 732758 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e8550432)

https://gerrit.wikimedia.org/r/732758

gerritbot added a project: Patch-For-Review.Oct 21 2021, 6:26 PM
gerritbot added a comment.Oct 21 2021, 6:53 PM

Change 732758 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e8550432)

https://gerrit.wikimedia.org/r/732758

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 21 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 7:10 PM
Esanders mentioned this in T294394: Focus lost when tabbing into a VE surface.Oct 28 2021, 3:05 PM
matmarex added a project: Editing QA.Oct 28 2021, 8:44 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Oct 30 2021, 10:30 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Nov 6 2021, 12:38 AM
ppelberg claimed this task.
matmarex mentioned this in T295403: Impossible to edit table with VisualEditor in mobile article.Nov 16 2021, 10:03 PM
gerritbot added a comment.Jul 2 2022, 12:02 PM

Change 810455 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I61b477d1f: Only remove native ranges if the are inside the document

https://gerrit.wikimedia.org/r/810455

gerritbot added a project: Patch-For-Review.Jul 2 2022, 12:02 PM
Esanders mentioned this in T311904: Find and replace input not focused when pressing ctrl+f a second time.Jul 4 2022, 9:30 AM
gerritbot added a comment.Jul 4 2022, 12:48 PM

Change 810455 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I61b477d1f: Only remove native ranges if the are inside the document

https://gerrit.wikimedia.org/r/810455

Maintenance_bot removed a project: Patch-For-Review.Jul 4 2022, 1:31 PM
gerritbot added a comment.Jul 4 2022, 2:58 PM

Change 810939 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a909d09a)

https://gerrit.wikimedia.org/r/810939

gerritbot added a project: Patch-For-Review.Jul 4 2022, 2:58 PM
gerritbot added a comment.Jul 4 2022, 3:11 PM

Change 810939 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0a909d09a)

https://gerrit.wikimedia.org/r/810939

Maintenance_bot removed a project: Patch-For-Review.Jul 4 2022, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits