We want to apply these business rules to displaying the images during the caption step.

• For an image that has a width in pixels narrower than the screen, show that image at original size (but no farther) and letterbox the rest.
• For an image that has a width in pixels wider than the screen, shrink the image to fit at fit-width on the screen.

We also potentially need there to be a minimum height for the space that a tiny image goes in so that the "View image details" footer doesn't cover it up.

One more open question: should the letterbox background be gray or white or something else? We don't want users to think that the gray part is part of the image that they're inserting.

@RHo @Etonkovidova @mewoph can continue the discussion.

Change 739665 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Add an image: Take into account the image's original width for caption thumbnail

https://gerrit.wikimedia.org/r/739665

@RHo Here's what the existing implementation looks like with the rendered image constrained by the original width (with some minimum height to avoid view image details covering the entire image). Let us know what you prefer re: the background.

Inserting the image File:Arrow_for_fossil_range_17x9.png with VE:

Testing notes (to check after the fix) - check the suggested image sizes to see if the caption box stays proper width:

This is how the image will look in wikitext:

In T295922#7515850, @Tgr wrote:

This is how the image will look in wikitext:

As far as I can see there is no way around this. (If there is no / very little caption, it looks less ridiculous, but still not great.)
I think showing a "no suggestion" error will be the lesser evil here.

Agree this makes sense for iteration 1, and have filed T296218: Add image: Set a minimum width for image suggestions per team discussion today.

I do think that the work @mewoph has done so far on this with setting a minimim height and always making the caption input full-width is still valid, and have captured this in the Figma spec

@mewoph -- it's up to you whether the change on this task should be merged, given that the users won't actually encounter tiny images in their experience because of the work on T296218.

In T295922#7522189, @MMiller_WMF wrote:

@mewoph -- it's up to you whether the change on this task should be merged, given that the users won't actually encounter tiny images in their experience because of the work on T296218.

This is still valid regardless of T296218 because there would still be occasions where an image smaller than the screen width appears for which we would still want the caption inut to be full width.

Change 739665 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Take into account the image's original width for caption thumbnail

https://gerrit.wikimedia.org/r/739665