Page MenuHomePhabricator
Create Task
Maniphest T296323

[Sticky header] update styling of language button
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
• alexhollender_WMF
Nov 23 2021, 6:27 PM
Tags
Referenced Files
F34796338: Screen Shot 2021-11-30 at 12.06.12 PM.png
Nov 30 2021, 5:06 PM
F34796337: Screen Shot 2021-11-30 at 12.06.03 PM.png
Nov 30 2021, 5:06 PM
F34762326: Screen Shot 2021-11-22 at 4.53.38 PM.png
Nov 23 2021, 6:27 PM
F34762327: Screen Shot 2021-11-22 at 4.53.28 PM.png
Nov 23 2021, 6:27 PM
Subscribers
Aklapper
• alexhollender_WMF
bwang
cjming
Jdlrobson
Jdrewniak
• nray
ovasileva

Description

Description

When the language menu is open the language button has a dark gray background. This is incorrect. It should match the user menu:

Screen Shot 2021-11-22 at 4.53.28 PM.png (443×956 px, 52 KB)
Screen Shot 2021-11-22 at 4.53.38 PM.png (327×244 px, 37 KB)

Details

SubjectRepoBranchLines +/-
Update style for language button in sticky headermediawiki/skins/Vectormaster+7 -0
Disable language button background color on modern Vectormediawiki/extensions/UniversalLanguageSelectormaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Nov 23 2021, 6:27 PM
• alexhollender_WMF added a parent task: T283505: [EPIC] Fixed "sticky" site header.Nov 23 2021, 6:29 PM
LGoto triaged this task as High priority.Nov 23 2021, 6:40 PM
LGoto moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.
LGoto set the point value for this task to 2.Nov 24 2021, 5:42 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang added a comment.Nov 24 2021, 5:53 PM

The background color is a style from the ULS extension, this should be a simple override for the sticky header ULS.

cjming claimed this task.Nov 24 2021, 8:59 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Nov 24 2021, 9:10 PM

Change 741725 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update style for language button in sticky header

https://gerrit.wikimedia.org/r/741725

gerritbot added a project: Patch-For-Review.Nov 24 2021, 9:10 PM
cjming removed cjming as the assignee of this task.Nov 24 2021, 9:10 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Nov 29 2021, 6:15 PM
gerritbot added a comment.Nov 29 2021, 10:47 PM

Change 742572 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Disable language button background color on modern Vector

https://gerrit.wikimedia.org/r/742572

gerritbot added a comment.Nov 30 2021, 5:15 AM

Change 742572 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Disable language button background color on modern Vector

https://gerrit.wikimedia.org/r/742572

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 30 2021, 6:00 AM
Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 30 2021, 2:59 PM
Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Nov 30 2021, 4:53 PM

Can be tested on beta cluster https://en.wikipedia.beta.wmflabs.org/wiki/Dog

Move to sign off if happy with the change, or needs more work if not.

gerritbot added a comment.Nov 30 2021, 4:53 PM

Change 741725 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Update style for language button in sticky header

Reason:

Fixed in https://gerrit.wikimedia.org/r/c/742572

https://gerrit.wikimedia.org/r/741725

• alexhollender_WMF removed • alexhollender_WMF as the assignee of this task.Nov 30 2021, 5:06 PM
• alexhollender_WMF moved this task from Design Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

@Jdlrobson it is an improvement but it seems to still be missing a focused state:

language button (focused)user menu button (focused)
Screen Shot 2021-11-30 at 12.06.12 PM.png (431×452 px, 39 KB)
Screen Shot 2021-11-30 at 12.06.03 PM.png (345×295 px, 20 KB)
Maintenance_bot removed a project: Patch-For-Review.Nov 30 2021, 5:11 PM
Jdlrobson added a comment.Nov 30 2021, 5:25 PM

@alexhollender, right.. the issue here is the button doesn't have the focus. The search input inside the ULS dialog has the focus.

• alexhollender_WMF assigned this task to ovasileva.Nov 30 2021, 6:07 PM
• alexhollender_WMF moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
In T296323#7538164, @Jdlrobson wrote:

@alexhollender, right.. the issue here is the button doesn't have the focus. The search input inside the ULS dialog has the focus.

gotcha thanks for explaining, all set for now then

• alexhollender_WMF mentioned this in T294924: Sticky header: full feature design review.Dec 1 2021, 5:05 PM
ovasileva closed this task as Resolved.Dec 1 2021, 5:26 PM

Looks good, resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL