Page MenuHomePhabricator
Create Task
Maniphest T296379

GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found
Closed, ResolvedPublicBUG REPORT
Actions

Description

What is the problem?

Since yesterday, I am seeing a lot of exceptions in the beta logs of the form:

2021-11-24 11:10:35 [f58cdbd09cdba94246333700] deployment-mwmaint02 testwiki 1.38.0-alpha exception ERROR: [f58cdbd09cdba94246333700] [no req]   Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. in BaseModule.less {"exception_url":"[no req]","reqId":"f58cdbd09cdba94246333700","caught_by":"other"} 
[Exception Less_Exception_Parser] (/srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php:2668) File `resources/lib/ooui/wikimedia-ui-base.less` not found. in BaseModule.less
  #0 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php(446): Less_Parser->Error(string)
  #1 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(265): Less_Parser->parseFile(string, string, boolean)
  #2 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(190): Less_Tree_Import->ParseImport(string, string, Less_Environment)
  #3 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(239): Less_Tree_Import->compile(Less_Environment)
  #4 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(227): Less_Tree_Ruleset->evalImports(Less_Environment)
  #5 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(69): Less_Tree_Ruleset->PrepareRuleset(Less_Environment)
  #6 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php(190): Less_Tree_Ruleset->compile(Less_Environment)
  #7 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1170): Less_Parser->getCss()
  #8 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1038): ResourceLoaderFileModule->compileLessString(string, string, DerivativeResourceLoaderContext)
  #9 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1014): ResourceLoaderFileModule->processStyle(string, string, string, DerivativeResourceLoaderContext)
  #10 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(991): ResourceLoaderFileModule->readStyleFile(string, DerivativeResourceLoaderContext)
  #11 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(420): ResourceLoaderFileModule->readStyleFiles(array, DerivativeResourceLoaderContext)
  #12 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(796): ResourceLoaderFileModule->getStyles(DerivativeResourceLoaderContext)
  #13 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(747): ResourceLoaderModule->buildContent(DerivativeResourceLoaderContext)
  #14 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(1139): ResourceLoaderModule->getModuleContent(DerivativeResourceLoaderContext)
  #15 /srv/mediawiki/php-master/extensions/WikimediaMaintenance/blameStartupRegistry.php(137): ResourceLoader->makeModuleResponse(DerivativeResourceLoaderContext, array)
  #16 /srv/mediawiki/php-master/maintenance/doMaintenance.php(108): BlameStartupRegistry->execute()
  #17 /srv/mediawiki/php-master/extensions/WikimediaMaintenance/blameStartupRegistry.php(332): require_once(string)
  #18 /srv/mediawiki/multiversion/MWScript.php(116): require_once(string)
  #19 {main}

It should be noted that this does not just affect the BaseModule.less file, it occurs for loads of other files including:

File `resources/lib/ooui/wikimedia-ui-base.less` not found. in campaign.less
File `resources/lib/ooui/wikimedia-ui-base.less` not found. in ve.ui.CodeMirror.init.less

Details

SubjectRepoBranchLines +/-
Use ForeignResourceManager to download wikimedia-ui-base.lessmediawiki/extensions/GrowthExperimentsmaster+589 -29
Use local copy of wikimedia ui less variablesmediawiki/extensions/GrowthExperimentsmaster+319 -2
Use local ui less variables in all stylesmediawiki/extensions/GrowthExperimentsmaster+28 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

dom_walden created this task.Nov 24 2021, 11:35 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptNov 24 2021, 11:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dom_walden updated the task description. (Show Details)Nov 24 2021, 11:36 AM
Krinkle added a project: GrowthExperiments.Nov 24 2021, 7:40 PM
Krinkle subscribed.

This appears to be due to an invalid import in GrowthExperiments/modules/ext.growthExperiments.MentorDashboard/BaseModule.less:

@import 'resources/lib/ooui/wikimedia-ui-base.less';

The only supported imports are from the exposed mediawiki.less directory and any overlay/override from the skins theme directory.

This appears to work by accident from (some?) web server contexts due to $IP being the current working directory in those cases, but it's nonetheless a private file that isn't exposed for direct importing in this way.

Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 24 2021, 7:40 PM
Krinkle edited projects, added Performance-Team (Radar); removed MediaWiki-ResourceLoader, Performance-Team.Nov 24 2021, 7:41 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Krinkle added a parent task: T293952: 1.38.0-wmf.11 deployment blockers.

Tentatively blocking train as I'd expect blameStartupRegistry.php to fail in production in the same way.

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Nov 25 2021, 1:17 PM
kostajh added subscribers: Urbanecm_WMF, kostajh.

cc @Urbanecm_WMF, looks like this particular code was added in rEGREc49129b46b5e: Mentor dashboard: Add subheader style. Although, we have this @import 'resources/lib/ooui/wikimedia-ui-base.less'; statement all over our LESS files.

kostajh triaged this task as High priority.Nov 25 2021, 1:17 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 26 2021, 10:30 AM

Change 742113 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Use local copy of wikimedia ui less variables

https://gerrit.wikimedia.org/r/742113

gerritbot added a project: Patch-For-Review.Nov 26 2021, 10:30 AM
gerritbot added a comment.Nov 26 2021, 10:41 AM

Change 742116 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Use local ui less variables in all styles

https://gerrit.wikimedia.org/r/742116

Sgs subscribed.EditedNov 26 2021, 10:42 AM
In T296379#7529369, @kostajh wrote:

cc @Urbanecm_WMF, looks like this particular code was added in rEGREc49129b46b5e: Mentor dashboard: Add subheader style. Although, we have this @import 'resources/lib/ooui/wikimedia-ui-base.less'; statement all over our LESS files.

I have pushed a possible patch for this. The problem was somehow mentioned in T295183: LESS variables and Import OOUI base styles mechanism. We would like to take steps forward to improve the current status of our styles imports. But as @kostajh says it is used all over our code base. I changed all the imports on this second patch, still doing some manual testing since it affects many files. All the imports have been changed in a single patch.

Sgs mentioned this in T295183: LESS variables and Import OOUI base styles mechanism.Nov 26 2021, 10:50 AM
gerritbot added a comment.Nov 26 2021, 11:14 AM

Change 742120 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Use local copy of wikimedia ui less variables

https://gerrit.wikimedia.org/r/742120

gerritbot added a comment.Nov 26 2021, 11:15 AM

Change 742116 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] Use local ui less variables in all styles

Reason:

squashed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/742120

https://gerrit.wikimedia.org/r/742116

gerritbot added a comment.Nov 26 2021, 11:15 AM

Change 742113 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] Use local copy of wikimedia ui less variables

Reason:

squashed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/742120

https://gerrit.wikimedia.org/r/742113

Sgs claimed this task.Nov 26 2021, 11:17 AM
Sgs moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 26 2021, 5:38 PM

Change 742120 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use ForeignResourceManager to download wikimedia-ui-base.less

https://gerrit.wikimedia.org/r/742120

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 26 2021, 5:40 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 26 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 26 2021, 6:10 PM
Sgs closed this task as Resolved.Nov 29 2021, 10:23 AM
dom_walden added a comment.Nov 29 2021, 2:48 PM

@Sgs Even after this change, I am seeing on beta:

2021-11-29 14:43:58 [319306f2d6453ce850098d42] deployment-mwmaint02 zhwiki 1.38.0-alpha exception ERROR: [319306f2d6453ce850098d42] [no req]   Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. in ve.ui.CodeMirror.init.less {"exception_url":"[no req]","reqId":"319306f2d6453ce850098d42","caught_by":"other"} 
[Exception Less_Exception_Parser] (/srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php:2668) File `resources/lib/ooui/wikimedia-ui-base.less` not found. in ve.ui.CodeMirror.init.less
  #0 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php(446): Less_Parser->Error(string)
  #1 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(265): Less_Parser->parseFile(string, string, boolean)
  #2 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(190): Less_Tree_Import->ParseImport(string, string, Less_Environment)
  #3 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(239): Less_Tree_Import->compile(Less_Environment)
  #4 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(227): Less_Tree_Ruleset->evalImports(Less_Environment)
  #5 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(69): Less_Tree_Ruleset->PrepareRuleset(Less_Environment)
  #6 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php(190): Less_Tree_Ruleset->compile(Less_Environment)
  #7 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1170): Less_Parser->getCss()
  #8 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1038): ResourceLoaderFileModule->compileLessString(string, string, DerivativeResourceLoaderContext)
  #9 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1014): ResourceLoaderFileModule->processStyle(string, string, string, DerivativeResourceLoaderContext)
  #10 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(991): ResourceLoaderFileModule->readStyleFile(string, DerivativeResourceLoaderContext)
  #11 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(420): ResourceLoaderFileModule->readStyleFiles(array, DerivativeResourceLoaderContext)
  #12 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(796): ResourceLoaderFileModule->getStyles(DerivativeResourceLoaderContext)
  #13 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(747): ResourceLoaderModule->buildContent(DerivativeResourceLoaderContext)
  #14 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(1139): ResourceLoaderModule->getModuleContent(DerivativeResourceLoaderContext)
  #15 /srv/mediawiki/php-master/extensions/WikimediaMaintenance/blameStartupRegistry.php(137): ResourceLoader->makeModuleResponse(DerivativeResourceLoaderContext, array)
  #16 /srv/mediawiki/php-master/maintenance/doMaintenance.php(108): BlameStartupRegistry->execute()
  #17 /srv/mediawiki/php-master/extensions/WikimediaMaintenance/blameStartupRegistry.php(332): require_once(string)
  #18 /srv/mediawiki/multiversion/MWScript.php(116): require_once(string)
  #19 {main}

Is this a different bug? In VE perhaps?

kostajh added a comment.Nov 29 2021, 2:50 PM
In T296379#7533964, @dom_walden wrote:

@Sgs Even after this change, I am seeing on beta:

2021-11-29 14:43:58 [319306f2d6453ce850098d42] deployment-mwmaint02 zhwiki 1.38.0-alpha exception ERROR: [319306f2d6453ce850098d42] [no req]   Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. in ve.ui.CodeMirror.init.less {"exception_url":"[no req]","reqId":"319306f2d6453ce850098d42","caught_by":"other"} 
[Exception Less_Exception_Parser] (/srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php:2668) File `resources/lib/ooui/wikimedia-ui-base.less` not found. in ve.ui.CodeMirror.init.less
  #0 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php(446): Less_Parser->Error(string)
  #1 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(265): Less_Parser->parseFile(string, string, boolean)
  #2 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(190): Less_Tree_Import->ParseImport(string, string, Less_Environment)
  #3 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(239): Less_Tree_Import->compile(Less_Environment)
  #4 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(227): Less_Tree_Ruleset->evalImports(Less_Environment)
  #5 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(69): Less_Tree_Ruleset->PrepareRuleset(Less_Environment)
  #6 /srv/mediawiki/php-master/vendor/wikimedia/less.php/lib/Less/Parser.php(190): Less_Tree_Ruleset->compile(Less_Environment)
  #7 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1170): Less_Parser->getCss()
  #8 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1038): ResourceLoaderFileModule->compileLessString(string, string, DerivativeResourceLoaderContext)
  #9 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1014): ResourceLoaderFileModule->processStyle(string, string, string, DerivativeResourceLoaderContext)
  #10 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(991): ResourceLoaderFileModule->readStyleFile(string, DerivativeResourceLoaderContext)
  #11 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(420): ResourceLoaderFileModule->readStyleFiles(array, DerivativeResourceLoaderContext)
  #12 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(796): ResourceLoaderFileModule->getStyles(DerivativeResourceLoaderContext)
  #13 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(747): ResourceLoaderModule->buildContent(DerivativeResourceLoaderContext)
  #14 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(1139): ResourceLoaderModule->getModuleContent(DerivativeResourceLoaderContext)
  #15 /srv/mediawiki/php-master/extensions/WikimediaMaintenance/blameStartupRegistry.php(137): ResourceLoader->makeModuleResponse(DerivativeResourceLoaderContext, array)
  #16 /srv/mediawiki/php-master/maintenance/doMaintenance.php(108): BlameStartupRegistry->execute()
  #17 /srv/mediawiki/php-master/extensions/WikimediaMaintenance/blameStartupRegistry.php(332): require_once(string)
  #18 /srv/mediawiki/multiversion/MWScript.php(116): require_once(string)
  #19 {main}

Is this a different bug? In VE perhaps?

@dom_walden that looks like an issue with MediaWiki-extensions-CodeMirror, as the Less_Exception_Parser: File resources/lib/ooui/wikimedia-ui-base.less` not found. in ve.ui.CodeMirror.init.less` message is about that extension and not GrowthExperiments. I think a new task for that extension would make sense.

kostajh renamed this task from Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found to GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found.Nov 29 2021, 2:50 PM
dom_walden mentioned this in T296639: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. in ve.ui.CodeMirror.init.less.Nov 29 2021, 3:02 PM
Krinkle added a comment.Nov 29 2021, 7:29 PM

Thanks for the quick fix.

In the short-mid term these can probably be replaced with mediawiki.skin.variables (T112747, T265941) which has as the posterchild use case something that looks a lot like what GrowthExperiments needed. Be sure to reach out to Volker if you have any questions or are unsure of which variables to use or might need additional ones to be standardised within core in skin-agnostic way.

kostajh mentioned this in T297008: Replace wikimedia-ui imports with mediawiki.skin.variables.Dec 3 2021, 1:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL