Page MenuHomePhabricator

[cswiki-wmf.9] Add image - the image inspector is not present for some articles
Closed, ResolvedPublic

Description

per @MMiller_WMF

Go to an article with image recommendations - some articles won't show the image inspector.
(click on the animated gif)

no add image.gif (640×390 px, 1 MB)

Note: after rotating a device to a horizontal orientation, the image inspector does appear (per @mewoph finding).

Event Timeline

Etonkovidova renamed this task from [cswiki=wmf.9] Add image - the image inspector is not present to [cswiki-wmf.9] Add image - the image inspector is not present .Dec 7 2021, 12:51 AM
Etonkovidova renamed this task from [cswiki-wmf.9] Add image - the image inspector is not present to [cswiki-wmf.9] Add image - the image inspector is not present for some articles.
MMiller_WMF added subscribers: DMburugu, RHo.

If this is common, it may be one of the reasons why we see many edits that don't add images (T296818). Because when I arrive on an article and can't see the inspector, the only apparent thing I can do is use the edit toggle to switch to VE.

On these videos (both this and the one shown by @MMiller_WMF) the suggested edit interface does load (there is a "Suggestions" bar on top) but the drawer with the controls does not come up. This is unlikely to be related to T296818 (which could happen if the structured edits module fails to load, but then you'd see normal VE controls).

Maybe it's this bug -> user taps on X and exits editor -> user opens normal edit mode -> edit gets recorded as structured edit, but in theory we have code to prevent the last step (as this control flow could happen regardless of whether the inspector shows up).

I was finally able to reproduce once on a real device (iPhone 12 mini, running iOS 15.1.1) on cswiki. When this happens, $('.mw-ge-recommendedImageToolbarDialog').height() is 0, upon rotating the device, the height becomes 339.

Change 744891 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: return a delay from the dialog's setup process

https://gerrit.wikimedia.org/r/744891

Change 744891 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: return a delay from the dialog's setup process

https://gerrit.wikimedia.org/r/744891

@mewoph - there is one puzzling issue: in the animated gif an add image article is opened right from the Homepage. I was testing on wmf.13 and it was not the case. On mobile Homepage clicking on an article won't open the article page, but redirects to SE module from which the article will be open. Is it a sort of regression?

For the issue in the task - I checked wmf.13, all seems fine.

Hi @Etonkovidova, I think the animated gif loops so it looks like the article is opened from the homepage (it starts with the article without the image inspector and then goes back to the homepage). That being said, the change to open the task directly from the mobile preview is coming up soon T264460: Enable users to open the first suggested article directly from the mobile task preview

Hi @Etonkovidova, I think the animated gif loops so it looks like the article is opened from the homepage (it starts with the article without the image inspector and then goes back to the homepage). That being said, the change to open the task directly from the mobile preview is coming up soon T264460: Enable users to open the first suggested article directly from the mobile task preview

Thanks! I was wondering whether the task for opening an article directly from mobile Homepage (T264460) has been done already.