Page MenuHomePhabricator

Unable to subscribe when there is no signature in section but a signature present in subsection
Closed, ResolvedPublicFeature

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
Subscribe button absent.

What should have happened instead?:
Subscribe button present.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
enwiki on 04:29, January 4, 2022. 1.38.0-wmf.13 (rMW2255bfd28097)

Event Timeline

Reproduced and explained:

https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&oldid=1063957769

The section you're referring to has no content. It can thus not be subscribed to.

Not even text content suffices: The section must contain a signature to become subscribable.

https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&direction=prev&oldid=1063957736

I'm afraid this works as intended.

Novem_Linguae renamed this task from Subscribe button not appearing on [[en:WP:AE]] page to Ability to subscribe when no signature in section but signature present in subsection.Jan 6 2022, 2:55 AM

@ToBeFree, thanks for the explanation. In that case, I'd still like to be able to subscribe to [[en:WP:AE]] sections, and the subsections contain signatures, so I have renamed this to "Ability to subscribe when no signature in section but signature present in subsection".

Aklapper changed the subtype of this task from "Bug Report" to "Feature Request".Jan 9 2022, 9:53 AM

Why it works like this:

  1. We only allow subscribing to level 2 headings, because allowing sub-sections would require a complex user interface (particularly in managing subscriptions when multiple subscriptions with different states could overlap), so we gave up on it.
  2. We require the section to have comments, because we track sections across renames/moves by using the author and time of the oldest comment.
  3. We don't count comments in sub-sections, because we were worried that if we counted them, then merging sections (e.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_193#Performance_issue_with_syntax_highlighting) would cause subscriptions to be lost, if the added sub-section was older.

We could probably handle #3 there differently, and remove this limitation. There are already some obvious cases where it doesn't work well.

I think that if T299657: Ensure notifications are sent when someone closes a discussion you are subscribed to was implemented, in such a way that we'd generate a notification when sections are merged that way, then we could just count the comments in sub-sections too, which would make these sections subscribable.

Change 811348 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Fix fetching of oldest comment in a thread

https://gerrit.wikimedia.org/r/811348

Esanders renamed this task from Ability to subscribe when no signature in section but signature present in subsection to Ability subscribing when there is no signature in section but a signature present in subsection.Jul 24 2022, 11:49 AM
matmarex renamed this task from Ability subscribing when there is no signature in section but a signature present in subsection to Unable to subscribe when there is no signature in section but a signature present in subsection.Aug 2 2022, 12:23 AM
matmarex reassigned this task from matmarex to Esanders.

Change 811348 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix fetching of oldest comment in a thread

https://gerrit.wikimedia.org/r/811348