Thanks, yes-- I'm not sure how to display finger taps in the video, but I tap the first result and the second result gets highlighted. Sorry for any confusion; I updated with the correct address including m

@Jdlrobson - I can reproduce on an iphone 11, Safari 15. @Edtadros - can you try with your physical iphone 12?

I believe this is happening at least partially due to Safari's behavior of automatically scrolling the webpage when opening/closing the keyboard. It happens very fast, but you can reproduce by clicking on a search result with the keyboard open:

1. the keyboard will close
2. the page will scroll up slightly
3. your click will go through and likely hit the next search result.

This issue doesn't happen if you close the keyboard before clicking a result, or if you make sure to click to very top of a search result (because the amount the page scrolls up is small). However, I'm unsure why the click is being affected by the scroll. When looking at medium's search on small browser, you also see the scroll happening on keyboard close, but it doesn't impact the click. Perhaps our overlay implementation, our use of fixed position, or the particularities of how our input is unfocused could be impacting this?

Others have tried to deal with this Safari behavior, (1, 2, 3), and it seems hypothetically we should be able to write some JS to counteract this. However, I haven't been able to test how feasible that is, as I haven't yet figured out how to get my localhost on my phone yet. More research is needed here

@bwang Agree 100% with your assessment

I noticed that medium.com/search doesn't close the keyboard when you tap "return" (And for that matter, the button says "return" on medium but "Search" on Wikipedia). Maybe this makes the difference.

Also, the search gets really crazy if you tap Search within pages and then go back. But this is probably a separate bug.

@SCEhardt I filed another task to capture the Search within pages issue. https://phabricator.wikimedia.org/T304445

Change 773362 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] [search] Prevent scroll when keyboard opened

https://gerrit.wikimedia.org/r/773362

I managed to get a physical device and it's as you say it is @bwang. With some Safari debugging I've worked out that if we stopPropagation for touchstart events on these clicks the problem will go away. Moving to estimation.

Voted this as a M mostly due to work involved in actually replicating this (need an iPhone) but also because there may be unintended side effects involved with stopPropagation or preventDefault

For whoever picks this up, this guide was helpful for getting localhost and web inspector on an iPhone.
In order to get localhost on your iPhone you also need to set $wgServer in LocalSettings.php to be your IP address

Change 773362 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] [search] Fix bugs

https://gerrit.wikimedia.org/r/773362