Page MenuHomePhabricator

Newcomer tasks: Enable filter changes directly on the post-edit dialog when there no suggested edits
Open, MediumPublic

Description

Initally raised in design updates to the post-edit dialog in T301603#7775289

Problem

An edge case scenario can occur in the post-edit dialog where there is no article available to do as a next suggestion due to the topic and/or interest filters set on a users task feed.

User job story for post-edit dialogs

When I finish an edit and want to do more, I want to find another suggested edit interesting to me directly after that edit, so that I quickly keep going without having to spend time going elsewhere to look for the next task.

Proposed solution

Instead of only allows users to go back to the suggested edits feed, provide users with the option to change filters directly from that article page so they bring up more suggested edits directly.

Notes on design:

  • Filters are added on all states of the post-edit dialog - with and without suggestions
  • Selecting the filters will bring up the respective filter dialogs for updating selections.

image.png (420×1 px, 86 KB)

Link on Figma: https://www.figma.com/file/fOa1x7hw6EM9VnaMJv7vib/Positive-reinforcement?node-id=900%3A38437

Event Timeline

kostajh subscribed.

@RHo should this go into the current sprint? If so, is it ready for development?

@RHo should this go into the current sprint? If so, is it ready for development?

Thanks for the ping @kostajh - It is ready for development, but I want to run this by @MMiller_WMF as it is not so urgent. While you are looking at this though, do you have an estimate of the effort for this to be implemented?

@RHo should this go into the current sprint? If so, is it ready for development?

Thanks for the ping @kostajh - It is ready for development, but I want to run this by @MMiller_WMF as it is not so urgent. While you are looking at this though, do you have an estimate of the effort for this to be implemented?

"Medium" amount of work, I'd say? @mewoph, perhaps you could comment on what's involved as you've been exploring some of this in T303985?

Hi @kostajh @RHo, once T303985: Suggested edits: make task feed reusable, this should be fairly straightforward. If it's not so urgent, perhaps we could leave this in incoming and then move to ready for development once the refactoring is done?

kostajh changed the task status from Open to Stalled.Mar 24 2022, 9:27 PM

Hi @kostajh @RHo, once T303985: Suggested edits: make task feed reusable, this should be fairly straightforward. If it's not so urgent, perhaps we could leave this in incoming and then move to ready for development once the refactoring is done?

Thanks @mewoph. Placing it in incoming sounds fine to me. Marking as stalled until T303985 is done.

kostajh changed the task status from Stalled to Open.Jun 2 2022, 1:49 PM

T303985: Suggested edits: make task feed reusable is done, so no longer stalled on that.

@KStoller-WMF , could you please confirm if this is something that should be prioritized soon or should we move this task out of the current sprint board?

Moving this task out of the current sprint as I don't believe we'll be able to pull this in immediately and it's an edge case issue that doesn't impact many users.