Page MenuHomePhabricator
Create Task
Maniphest T305161

Hard-deprecate and remove @deprecated methods from ParserOutput
Open, Needs TriagePublic
Actions

Description

I expect to hard-deprecate everything marked @deprecated before 1.39 is released, and then actually remove the hard-deprecated methods in 1.40 (just after the 1.39 LTS).

To hard deprecate:

  • ::getOutputHooks()
  • ::addOutputHook()
  • ::addJsConfigVars()
  • ::setFlag() (hard deprecated in 1.41)
  • ::getFlag() (hard deprecated in 1.41)
  • ::getCategories() (hard deprecated in 1.41)

To remove:

  • ::getCategoryLinks()
  • ::setCategoryLinks()
  • ::getOutputHooks()
  • ::addOutputHook()
  • ::addWarning()
  • ::addJsConfigVars()
  • ::addTrackingCategory()
  • ::hideNewSection()
  • ::setFlag() (no sooner than 1.42)
  • ::getFlag() (no sooner than 1.42)
  • ::setProperty()
  • ::getProperty()
  • ::unsetProperty()
  • ::getProperties()
  • ::hasDynamicContent()
  • ::preventClickjacking()
  • ::getTOCHTML() (hard-deprecated in 1.40)
  • ::setTOCHTML() (hard-deprecated in 1.40)

Details

SubjectRepoBranchLines +/-
ParserOutput: remove getFlag()/setFlag(), deprecated since 1.38mediawiki/coremaster+2 -21
ParserOutput: Remove a few hard-deprecated methodsmediawiki/coremaster+14 -97
Hard-deprecate ParserOutput::addJsConfigVars(), deprecated in 1.38mediawiki/coremaster+10 -5
Assign UUIDs to Scribunto errors independent of page parse ordermediawiki/extensions/Scribuntomaster+34 -24
ParserOutput::hasTOCHTML(): Remove old back-compat codemediawiki/coremaster+4 -25
Hard-deprecate ParserOutput::getCategories(), deprecated in 1.40mediawiki/coremaster+46 -23
Bump wikimedia/parsoid to 0.18.0-a26mediawiki/vendormaster+542 -1 K
Avoid using deprecated ParserOutput::getCategories()mediawiki/services/parsoidmaster+18 -8
Replace use of ParserOutput::getCategories(), deprecated in 1.38mediawiki/extensions/Babelmaster+4 -6
Use ParserOutput::getCategoryNames() instead of ::getCategories()mediawiki/extensions/FileImportermaster+4 -5
Avoid use of deprecated ParserOutput::getCategories()mediawiki/extensions/Kartographermaster+2 -2
Replace use of deprecated ParserOutput::getCategories() methodmediawiki/extensions/FlaggedRevsmaster+3 -3
Remove usage of ParserOutput::getCategories(), deprecated in 1.38mediawiki/extensions/PageTriagemaster+4 -4
Remove ParserOutput::addOutputHook() and related codemediawiki/coremaster+5 -164
Remove ParserOutput::{get,set}CategoryLinks(), deprecated since 1.38mediawiki/coremaster+2 -18
Remove ParserOutput::addTrackingCategory(), deprecated since 1.38mediawiki/coremaster+17 -56
Remove ParserOutput::{get,unset,set}Property and ::getProperties()mediawiki/coremaster+5 -45
Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38mediawiki/extensions/Scribuntomaster+1 -1
Remove {ParserOutput,OutputPage}::preventClickjacking, deprecated since 1.38mediawiki/coremaster+12 -46
Remove ParserOutput::hasDynamicContent(), deprecated since 1.38mediawiki/coremaster+1 -11
Remove ParserOutput::addWarning, deprecated since 1.38mediawiki/coremaster+14 -13
Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38mediawiki/extensions/Wikibasemaster+37 -47
Hard-deprecate ParserOutput::{get,set}Flag()mediawiki/coremaster+14 -9
ParserOutput::addModules,addModuleStyles(): first arg must be arraymediawiki/coremaster+4 -14
Remove ParserOutput::hideNewSection, deprecated since 1.38mediawiki/coremaster+1 -9
WIP: Remove $wgTrackingCategories, deprecated since 1.25mediawiki/coremaster+3 -62
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Mar 31 2022, 3:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2022, 3:19 PM
cscott added a subtask: T292321: Remove ParserOutput::addOutputHook().Mar 31 2022, 3:22 PM
Zabe moved this task from Blocker to To deprecate or remove on the MW-1.39-release board.May 29 2022, 7:33 PM
Jdforrester-WMF edited projects, added MW-1.40-release; removed MW-1.39-release.Dec 6 2022, 9:24 PM
Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.40-release board.
Jdforrester-WMF subscribed.

1.39.0 is now out. Let's get this done?

gerritbot added a comment.Jun 9 2023, 9:35 PM

Change 928956 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] ParserOutput: Remove a few hard-deprecated methods

https://gerrit.wikimedia.org/r/928956

gerritbot added a project: Patch-For-Review.Jun 9 2023, 9:35 PM
gerritbot added a comment.Jul 27 2023, 8:05 PM

Change 942499 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::addOutputHook() and related code

https://gerrit.wikimedia.org/r/942499

gerritbot added a comment.Jul 27 2023, 10:32 PM

Change 942516 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::addTrackingCategory(), deprecated since 1.38

https://gerrit.wikimedia.org/r/942516

gerritbot added a comment.Jul 27 2023, 10:32 PM

Change 942517 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: Remove $wgTrackingCategories, deprecated since 1.25

https://gerrit.wikimedia.org/r/942517

gerritbot added a comment.Jul 27 2023, 10:42 PM

Change 942520 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::preventClickjacking, deprecated since 1.38

https://gerrit.wikimedia.org/r/942520

gerritbot added a comment.Jul 27 2023, 10:42 PM

Change 942521 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::{hideNewSection,hasDynamicContent}, deprecated since 1.38

https://gerrit.wikimedia.org/r/942521

cscott updated the task description. (Show Details)Jul 27 2023, 10:49 PM
gerritbot added a comment.Jul 27 2023, 10:54 PM

Change 942522 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::addWarning, deprecated since 1.38

https://gerrit.wikimedia.org/r/942522

gerritbot added a comment.Jul 27 2023, 10:54 PM

Change 942523 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::hideNewSection, deprecated since 1.38

https://gerrit.wikimedia.org/r/942523

gerritbot added a comment.Jul 27 2023, 10:54 PM

Change 942524 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::{get,unset,set}Property and ::getProperties()

https://gerrit.wikimedia.org/r/942524

gerritbot added a comment.Jul 27 2023, 10:54 PM

Change 942525 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Hard-deprecate ParserOutput::{get,set}Flag()

https://gerrit.wikimedia.org/r/942525

cscott added a subtask: T293515: Migrate ParserOutput::addWarning() to ::addWarningMsg().Jul 28 2023, 8:18 PM
gerritbot added a comment.Jul 30 2023, 2:23 PM

Change 942523 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::hideNewSection, deprecated since 1.38

https://gerrit.wikimedia.org/r/942523

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 30 2023, 3:00 PM
cscott updated the task description. (Show Details)Jul 31 2023, 10:24 PM
gerritbot added a comment.Jul 31 2023, 10:28 PM

Change 943641 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::{get,set}CategoryLinks(), deprecated since 1.38

https://gerrit.wikimedia.org/r/943641

cscott updated the task description. (Show Details)Jul 31 2023, 10:30 PM
gerritbot added a comment.Jul 31 2023, 10:41 PM

Change 943642 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Hard-deprecate ParserOutput::addJsConfigVars(), deprecated in 1.38

https://gerrit.wikimedia.org/r/943642

gerritbot added a comment.Jul 31 2023, 10:45 PM

Change 943643 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput::addModules,addModuleStyles(): first arg must be array

https://gerrit.wikimedia.org/r/943643

gerritbot added a comment.Aug 2 2023, 2:24 PM

Change 943643 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput::addModules,addModuleStyles(): first arg must be array

https://gerrit.wikimedia.org/r/943643

gerritbot added a comment.Aug 2 2023, 2:44 PM

Change 944922 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/944922

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 2 2023, 3:00 PM
gerritbot added a comment.Aug 2 2023, 5:48 PM

Change 942525 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate ParserOutput::{get,set}Flag()

https://gerrit.wikimedia.org/r/942525

gerritbot added a comment.Aug 7 2023, 10:13 PM

Change 946633 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/946633

gerritbot added a comment.Aug 9 2023, 3:22 PM

Change 944922 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/944922

gerritbot added a comment.Aug 9 2023, 10:56 PM

Change 942522 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::addWarning, deprecated since 1.38

https://gerrit.wikimedia.org/r/942522

gerritbot added a comment.Sep 11 2023, 4:55 PM

Change 946633 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/946633

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.26; 2023-09-12); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Sep 11 2023, 5:00 PM
gerritbot added a comment.Sep 11 2023, 5:21 PM

Change 942520 merged by jenkins-bot:

[mediawiki/core@master] Remove {ParserOutput,OutputPage}::preventClickjacking, deprecated since 1.38

https://gerrit.wikimedia.org/r/942520

gerritbot added a comment.Sep 11 2023, 5:21 PM

Change 942521 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::hasDynamicContent(), deprecated since 1.38

https://gerrit.wikimedia.org/r/942521

gerritbot added a comment.Sep 11 2023, 9:50 PM

Change 956511 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@master] Assign UUIDs to Scribunto errors independent of page parse order

https://gerrit.wikimedia.org/r/956511

gerritbot added a comment.Sep 18 2023, 5:54 PM

Change 942516 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::addTrackingCategory(), deprecated since 1.38

https://gerrit.wikimedia.org/r/942516

gerritbot added a comment.Sep 18 2023, 5:54 PM

Change 942524 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::{get,unset,set}Property and ::getProperties()

https://gerrit.wikimedia.org/r/942524

gerritbot added a comment.Sep 18 2023, 5:56 PM

Change 942499 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::addOutputHook() and related code

https://gerrit.wikimedia.org/r/942499

gerritbot added a comment.Sep 18 2023, 5:57 PM

Change 943641 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::{get,set}CategoryLinks(), deprecated since 1.38

https://gerrit.wikimedia.org/r/943641

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 18 2023, 6:01 PM
cscott updated the task description. (Show Details)Sep 21 2023, 4:30 PM

Got most of this done in 1.41; get/setFlag will have to wait until 1.42, and hard-deprecation of ::addJsConfigVars() is still awaiting review.

cscott updated the task description. (Show Details)Sep 21 2023, 4:39 PM
gerritbot added a comment.Sep 21 2023, 5:19 PM

Change 959817 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Avoid using deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959817

gerritbot added a comment.Sep 21 2023, 5:23 PM

Change 959818 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Kartographer@master] Avoid use of deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959818

gerritbot added a comment.Sep 21 2023, 5:29 PM

Change 959819 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/FlaggedRevs@master] Replace use of deprecated ParserOutput::getCategories() method

https://gerrit.wikimedia.org/r/959819

gerritbot added a comment.Sep 21 2023, 5:33 PM

Change 959821 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Babel@master] Replace use of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959821

gerritbot added a comment.Sep 21 2023, 5:39 PM

Change 959824 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/PageTriage@master] Remove usage of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959824

gerritbot added a comment.Sep 21 2023, 5:39 PM

Change 959825 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Hard-deprecate ParserOutput::getCategories(), deprecated in 1.40

https://gerrit.wikimedia.org/r/959825

gerritbot added a comment.Sep 22 2023, 5:32 PM

Change 959824 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove usage of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959824

gerritbot added a comment.Sep 22 2023, 5:32 PM

Change 959818 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Avoid use of deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959818

gerritbot added a comment.Sep 22 2023, 5:32 PM

Change 959819 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace use of deprecated ParserOutput::getCategories() method

https://gerrit.wikimedia.org/r/959819

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 22 2023, 6:00 PM
gerritbot added a comment.Sep 22 2023, 9:40 PM

Change 960140 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/FileImporter@master] Use ParserOutput::getCategoryNames() instead of ::getCategories()

https://gerrit.wikimedia.org/r/960140

gerritbot added a comment.Sep 23 2023, 9:08 AM

Change 960140 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Use ParserOutput::getCategoryNames() instead of ::getCategories()

https://gerrit.wikimedia.org/r/960140

gerritbot added a comment.Sep 25 2023, 5:29 PM

Change 959821 merged by jenkins-bot:

[mediawiki/extensions/Babel@master] Replace use of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959821

gerritbot added a comment.Sep 27 2023, 3:17 PM

Change 959817 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Avoid using deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959817

gerritbot added a comment.Oct 2 2023, 9:11 PM

Change 962706 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

gerritbot added a comment.Oct 2 2023, 10:28 PM

Change 962706 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

gerritbot added a comment.Oct 3 2023, 8:59 PM

Change 959825 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate ParserOutput::getCategories(), deprecated in 1.40

https://gerrit.wikimedia.org/r/959825

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.30; 2023-10-10); removed MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Oct 3 2023, 9:00 PM
gerritbot added a comment.Oct 12 2023, 2:29 PM

Change 965524 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput::hasTOCHTML(): Remove old back-compat code

https://gerrit.wikimedia.org/r/965524

cscott updated the task description. (Show Details)Oct 12 2023, 2:29 PM
gerritbot added a comment.Oct 12 2023, 2:32 PM

Change 965525 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput: remove getFlag()/setFlag(), deprecated since 1.38

https://gerrit.wikimedia.org/r/965525

gerritbot added a comment.Oct 13 2023, 2:06 PM

Change 965524 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput::hasTOCHTML(): Remove old back-compat code

https://gerrit.wikimedia.org/r/965524

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 13 2023, 3:00 PM
gerritbot added a comment.Oct 13 2023, 4:16 PM

Change 956511 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Assign UUIDs to Scribunto errors independent of page parse order

https://gerrit.wikimedia.org/r/956511

gerritbot added a comment.Oct 26 2023, 7:58 PM

Change 928956 abandoned by Jforrester:

[mediawiki/core@master] ParserOutput: Remove a few hard-deprecated methods

Reason:

Done in other patches.

https://gerrit.wikimedia.org/r/928956

gerritbot added a comment.Nov 28 2023, 9:34 PM

Change 965525 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: remove getFlag()/setFlag(), deprecated since 1.38

https://gerrit.wikimedia.org/r/965525

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 2023-12-12); removed MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Nov 28 2023, 10:00 PM
cscott closed subtask T292321: Remove ParserOutput::addOutputHook() as Resolved.Dec 7 2023, 4:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL