Page MenuHomePhabricator

Hard-deprecate and remove @deprecated methods from ParserOutput
Open, Needs TriagePublic

Description

I expect to hard-deprecate everything marked @deprecated before 1.39 is released, and then actually remove the hard-deprecated methods in 1.40 (just after the 1.39 LTS).

To hard deprecate:
All done.

To remove:

  • ::getCategoryLinks()
  • ::setCategoryLinks()
  • ::getOutputHooks()
  • ::addOutputHook()
  • ::addWarning()
  • ::addTrackingCategory()
  • ::hideNewSection()
  • ::setProperty()
  • ::getProperty()
  • ::unsetProperty()
  • ::getProperties()
  • ::hasDynamicContent()
  • ::preventClickjacking()
  • ::getOutputHooks()
  • ::addOutputHook()
  • ::getTOCHTML() (hard-deprecated in 1.40)
  • ::setTOCHTML() (hard-deprecated in 1.40)
  • ::setFlag() (hard deprecated in 1.41)
  • ::getFlag() (hard deprecated in 1.41)
  • ::getCategories() (hard deprecated in 1.41)
  • ::addJsConfigVars() (hard deprecated in 1.43; no sooner than 1.44)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/extensions/Scribuntomaster+34 -24
mediawiki/coremaster+10 -5
mediawiki/coremaster+2 -21
mediawiki/coremaster+14 -97
mediawiki/coremaster+4 -25
mediawiki/coremaster+46 -23
mediawiki/vendormaster+542 -1 K
mediawiki/services/parsoidmaster+18 -8
mediawiki/extensions/Babelmaster+4 -6
mediawiki/extensions/FileImportermaster+4 -5
mediawiki/extensions/Kartographermaster+2 -2
mediawiki/extensions/FlaggedRevsmaster+3 -3
mediawiki/extensions/PageTriagemaster+4 -4
mediawiki/coremaster+5 -164
mediawiki/coremaster+2 -18
mediawiki/coremaster+17 -56
mediawiki/coremaster+5 -45
mediawiki/extensions/Scribuntomaster+1 -1
mediawiki/coremaster+12 -46
mediawiki/coremaster+1 -11
mediawiki/coremaster+14 -13
mediawiki/extensions/Wikibasemaster+37 -47
mediawiki/coremaster+14 -9
mediawiki/coremaster+4 -14
mediawiki/coremaster+1 -9
mediawiki/coremaster+3 -62
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
OpenNone
Resolvedcscott
Resolvedcscott
Openihurbain
ResolvedPRODUCTION ERRORmatmarex
OpenNone
Resolvedihurbain
Resolvedihurbain
Resolvedcscott
Resolvedihurbain
Resolvedcscott
Resolvedihurbain
OpenNone
Opencscott
OpenBUG REPORTNone
Openihurbain
Resolvedihurbain
Resolvedihurbain
Openihurbain
Resolvedcscott
Openihurbain
OpenNone
ResolvedPRODUCTION ERRORcscott
Openihurbain

Event Timeline

Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.40-release board.
Jdforrester-WMF subscribed.

1.39.0 is now out. Let's get this done?

Change 928956 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] ParserOutput: Remove a few hard-deprecated methods

https://gerrit.wikimedia.org/r/928956

Change 942499 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::addOutputHook() and related code

https://gerrit.wikimedia.org/r/942499

Change 942516 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::addTrackingCategory(), deprecated since 1.38

https://gerrit.wikimedia.org/r/942516

Change 942517 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: Remove $wgTrackingCategories, deprecated since 1.25

https://gerrit.wikimedia.org/r/942517

Change 942520 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::preventClickjacking, deprecated since 1.38

https://gerrit.wikimedia.org/r/942520

Change 942521 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::{hideNewSection,hasDynamicContent}, deprecated since 1.38

https://gerrit.wikimedia.org/r/942521

Change 942522 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::addWarning, deprecated since 1.38

https://gerrit.wikimedia.org/r/942522

Change 942523 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::hideNewSection, deprecated since 1.38

https://gerrit.wikimedia.org/r/942523

Change 942524 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::{get,unset,set}Property and ::getProperties()

https://gerrit.wikimedia.org/r/942524

Change 942525 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Hard-deprecate ParserOutput::{get,set}Flag()

https://gerrit.wikimedia.org/r/942525

Change 942523 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::hideNewSection, deprecated since 1.38

https://gerrit.wikimedia.org/r/942523

Change 943641 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove ParserOutput::{get,set}CategoryLinks(), deprecated since 1.38

https://gerrit.wikimedia.org/r/943641

Change 943642 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Hard-deprecate ParserOutput::addJsConfigVars(), deprecated in 1.38

https://gerrit.wikimedia.org/r/943642

Change 943643 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput::addModules,addModuleStyles(): first arg must be array

https://gerrit.wikimedia.org/r/943643

Change 943643 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput::addModules,addModuleStyles(): first arg must be array

https://gerrit.wikimedia.org/r/943643

Change 944922 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/944922

Change 942525 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate ParserOutput::{get,set}Flag()

https://gerrit.wikimedia.org/r/942525

Change 946633 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/946633

Change 944922 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/944922

Change 942522 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::addWarning, deprecated since 1.38

https://gerrit.wikimedia.org/r/942522

Change 946633 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace use of ParserOutput::addJsConfigVars(), deprecated since 1.38

https://gerrit.wikimedia.org/r/946633

Change 942520 merged by jenkins-bot:

[mediawiki/core@master] Remove {ParserOutput,OutputPage}::preventClickjacking, deprecated since 1.38

https://gerrit.wikimedia.org/r/942520

Change 942521 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::hasDynamicContent(), deprecated since 1.38

https://gerrit.wikimedia.org/r/942521

Change 956511 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@master] Assign UUIDs to Scribunto errors independent of page parse order

https://gerrit.wikimedia.org/r/956511

Change 942516 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::addTrackingCategory(), deprecated since 1.38

https://gerrit.wikimedia.org/r/942516

Change 942524 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::{get,unset,set}Property and ::getProperties()

https://gerrit.wikimedia.org/r/942524

Change 942499 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::addOutputHook() and related code

https://gerrit.wikimedia.org/r/942499

Change 943641 merged by jenkins-bot:

[mediawiki/core@master] Remove ParserOutput::{get,set}CategoryLinks(), deprecated since 1.38

https://gerrit.wikimedia.org/r/943641

Got most of this done in 1.41; get/setFlag will have to wait until 1.42, and hard-deprecation of ::addJsConfigVars() is still awaiting review.

Change 959817 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Avoid using deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959817

Change 959818 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Kartographer@master] Avoid use of deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959818

Change 959819 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/FlaggedRevs@master] Replace use of deprecated ParserOutput::getCategories() method

https://gerrit.wikimedia.org/r/959819

Change 959821 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Babel@master] Replace use of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959821

Change 959824 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/PageTriage@master] Remove usage of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959824

Change 959825 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Hard-deprecate ParserOutput::getCategories(), deprecated in 1.40

https://gerrit.wikimedia.org/r/959825

Change 959824 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove usage of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959824

Change 959818 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Avoid use of deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959818

Change 959819 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace use of deprecated ParserOutput::getCategories() method

https://gerrit.wikimedia.org/r/959819

Change 960140 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/FileImporter@master] Use ParserOutput::getCategoryNames() instead of ::getCategories()

https://gerrit.wikimedia.org/r/960140

Change 960140 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Use ParserOutput::getCategoryNames() instead of ::getCategories()

https://gerrit.wikimedia.org/r/960140

Change 959821 merged by jenkins-bot:

[mediawiki/extensions/Babel@master] Replace use of ParserOutput::getCategories(), deprecated in 1.38

https://gerrit.wikimedia.org/r/959821

Change 959817 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Avoid using deprecated ParserOutput::getCategories()

https://gerrit.wikimedia.org/r/959817

Change 962706 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

Change 962706 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

Change 959825 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate ParserOutput::getCategories(), deprecated in 1.40

https://gerrit.wikimedia.org/r/959825

Change 965524 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput::hasTOCHTML(): Remove old back-compat code

https://gerrit.wikimedia.org/r/965524

Change 965525 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput: remove getFlag()/setFlag(), deprecated since 1.38

https://gerrit.wikimedia.org/r/965525

Change 965524 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput::hasTOCHTML(): Remove old back-compat code

https://gerrit.wikimedia.org/r/965524

Change 956511 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Assign UUIDs to Scribunto errors independent of page parse order

https://gerrit.wikimedia.org/r/956511

Change 928956 abandoned by Jforrester:

[mediawiki/core@master] ParserOutput: Remove a few hard-deprecated methods

Reason:

Done in other patches.

https://gerrit.wikimedia.org/r/928956

Change 965525 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: remove getFlag()/setFlag(), deprecated since 1.38

https://gerrit.wikimedia.org/r/965525

This didn't get done before the release of MW 1.40.

Change #943642 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate ParserOutput::addJsConfigVars(), deprecated in 1.38

https://gerrit.wikimedia.org/r/943642