Page MenuHomePhabricator

Build 'Find in page' functionality for new talk pages detail page
Closed, ResolvedPublic

Description

Derived from T303254 per @Dbrant’s request to create a separate task for 'Find in page' in today’s 1:1 👇

Talk pages redesign-1.png (1×720 px, 131 KB)

  • The overflow menu (05) contains a 'Find in page' option to let users quickly find words in a specific thread
  • Works the same way as searching notifications, outlined in T288068
  • Expand all threads when using 'Find in page' and highlighting search results
  • Update per @cooltey’s request in T297617 (May 23, 2022) 👇

In T297617#7944696, @scblr wrote:

Thanks @cooltey

01) To me it’s a bit unclear why certain topics are displayed when performing a search, see the example below where the search term toc is likely part of a reply in subjects listed as a search result:

Screenshot_20220520-153910.png (2×1 px, 194 KB)

To make this more clear: Can we highlight the term on the subject page after users tapped an item, e.g. with 'Find in page' enabled that you are building in T307378?


APK: https://github.com/wikimedia/apps-android-wikipedia/pull/3343

Event Timeline

LGoto triaged this task as Low priority.May 3 2022, 4:26 PM
LGoto moved this task from Needs Triage to Up Next on the Wikipedia-Android-App-Backlog board.

Hi @scblr

The function has been added. Please download the APK from the ticket description, thanks!

Thanks @cooltey

01) Per our previous discussion on slack, please add a find in page shortcut here 👇

Screenshot_20220524-175159.png (2×1 px, 173 KB)

Also, change the icon’s label to 'Find in talk page topic'.

02) Change the label to 'Find in talk page topic'

Screenshot_20220524-175513.png (2×1 px, 211 KB)