Page MenuHomePhabricator

[regression] settings link missing from anonymous user experience
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Open an incognito window
  • OPen sidebar

What happens?:

No settings in menu

Screen Shot 2022-05-05 at 8.11.43 AM.png (862×1 px, 154 KB)

What should have happened instead?:

Settings is supposed to be available for anonymous users. It's not clear when and how this broke but we should fix it.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

QA Results - Beta

ACStatusDetails
1T307696#7959122

QA Results - Prod

ACStatusDetails
1T307696#7981706

Event Timeline

I think this is for some reason being controlled by $wgMinervaAdvancedMainMenu when it shouldn't be. It appears when I set that flag along with other menu items:

Screen Shot 2022-05-06 at 12.20.12 PM.png (996×1 px, 96 KB)

Change 791421 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Add preference menu item for anon users

https://gerrit.wikimedia.org/r/791421

bwang removed bwang as the assignee of this task.May 12 2022, 6:24 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang subscribed.

Change 791421 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Add settings menu item for anon users

https://gerrit.wikimedia.org/r/791421

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Settings should be available in sidebar as anonymous user on Mobile.

Screen Shot 2022-05-25 at 8.03.21 PM.png (628×915 px, 84 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Settings should be available in sidebar as anonymous user on Mobile.

Screen Shot 2022-06-05 at 5.45.40 PM.png (475×692 px, 93 KB)