1.39.0-wmf.16 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Assigned To

Authored By

	thcipriani
	May 10 2022, 9:53 PM

Details

Backup Train Conductor: • dduvall
Release Version: 1.39.0-wmf.16
Release Date: Jun 13 2022, 12:00 AM

2022 week 24 1.39-wmf.16 Changes wmf/1.39.0-wmf.16

This MediaWiki Train Deployment is scheduled for the week of Monday, June 13th:

Monday June 13th	Tuesday, June 14th	Wednesday, June 15th	Thursday, June 16th	Friday
Backports only.	Branch `wmf.16` and deploy to Group 0 Wikis.	Deploy `wmf.16` to Group 1 Wikis.	Deploy `wmf.16` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.16 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.39.0-wmf.15

Next: 1.39.0-wmf.17

Subject	Repo	Branch	Lines +/-
all wikis to 1.39.0-wmf.16	operations/mediawiki-config	master	+323 -323
group1 wikis to 1.39.0-wmf.16	operations/mediawiki-config	master	+529 -529
group0 wikis to 1.39.0-wmf.16	operations/mediawiki-config	master	+128 -128

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	brennen	T308069 1.39.0-wmf.16 deployment blockers
Resolved	PRODUCTION ERROR	Krinkle	T310532 Investigate McRouter GET request spike from wmf.15
Resolved	PRODUCTION ERROR	Zabe	T310747 TypeError: Argument 1 passed to MediaWiki\User\UserFactory::newFromName() must be of the type string, null given

Event Timeline

thcipriani created this task.May 10 2022, 9:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2022, 9:53 PM

thcipriani assigned this task to brennen.May 10 2022, 10:08 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: jeena.

thcipriani set the point value for this task to 5.

thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).

Jdlrobson added a subtask: T310401: [MediaSearch] 'ownKeys' on proxy: trap result did not include 'length'.Jun 10 2022, 9:50 PM

Regarding T310401

The problem was only occurring on a single repeated search query.

The issue stopped of its own accord at 1800 and nothing went out on this week's train with MediaSearch.

I’m not immediately aware of any degradation of user experience.

I'm going to drop the priority and remove this as a blocker from the train for the time being but I have tasked an engineer to look at this on Monday.

Since the error isn’t occurring any further it may be difficult to replicate.

thcipriani updated Other Assignee, added: • dduvall; removed: jeena.Jun 13 2022, 3:10 PM

brennen added a project: User-brennen.Jun 13 2022, 5:36 PM

brennen moved this task from Backlog to Doing on the User-brennen board.

After the 1.39.0-wmf.16 branch cut happened, @tstarling deployed a change to the AbuseFilter extension (see T212129). The change does not seem to have been merged on the new deployment branch though, only on master and wmf/1.39.0-wmf.15. Will it be necessary to merge this change into the new deployment branch, since apparently it is needed for a configuration change that was made in InitialiseSettings.php?

Yes, it is necessary. Reverting it would overload the x2 cluster.

In T308069#8002312, @tstarling wrote:

Yes, it is necessary. Reverting it would overload the x2 cluster.

Marked as a blocker and cherry-picked https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/805361; sorry, am in meetings so can't deploy for you.

Marked as a blocker and cherry-picked https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/805361; sorry, am in meetings so can't deploy for you.

+2'd - php-1.39.0-wmf.16 doesn't yet exist on deployment box, so shouldn't require a separate deployment step.

brennen removed a subtask: T212129: Move MainStash out of Redis to a simpler multi-dc aware solution.Jun 14 2022, 4:37 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-14T17:12:58Z] <brennen> train 1.39.0-wmf.16 (T308069): train is blocked - will sync to testwikis and hold there for resolution of T310532

Stashbot mentioned this in T310532: Investigate McRouter GET request spike from wmf.15.Jun 14 2022, 5:12 PM

Mentioned in SAL (#wikimedia-releng) [2022-06-14T17:18:03Z] <brennen> starting 1.39.0-wmf.16 (T308069) transcript in deploy1002:~brennen/1.39.0-wmf.16.log

tstarling closed subtask T310532: Investigate McRouter GET request spike from wmf.15 as Resolved.Jun 15 2022, 2:30 AM

Mentioned in SAL (#wikimedia-operations) [2022-06-15T16:54:48Z] <brennen> train 1.39.0-wmf.16 (T308069): no current blockers - rolling to group0

Change 805866 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.16

https://gerrit.wikimedia.org/r/805866

Change 805866 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.16

https://gerrit.wikimedia.org/r/805866

Mentioned in SAL (#wikimedia-operations) [2022-06-15T17:03:29Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.39.0-wmf.16 refs T308069

Change 805877 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.16

https://gerrit.wikimedia.org/r/805877

Change 805877 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.16

https://gerrit.wikimedia.org/r/805877

Mentioned in SAL (#wikimedia-operations) [2022-06-15T18:06:58Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.39.0-wmf.16 refs T308069

Mentioned in SAL (#wikimedia-operations) [2022-06-15T18:10:42Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.39.0-wmf.16 refs T308069 (duration: 03m 43s)

Mainframe98 mentioned this in T310440: Attempting to delete a translation page using Special:PageTranslationDeletePage shows an internal error.Jun 15 2022, 6:25 PM

brennen mentioned this in T310747: TypeError: Argument 1 passed to MediaWiki\User\UserFactory::newFromName() must be of the type string, null given.Jun 15 2022, 9:34 PM

Noting T310742: Editing tasks results in "You cannot add more than 0 objects to the relationship" error here - if you need to add a blocker task before we get that fix out, please mark it UBN and mention here. I'll track manually.

Blocking on T310747.

brennen added a subtask: T310747: TypeError: Argument 1 passed to MediaWiki\User\UserFactory::newFromName() must be of the type string, null given.Jun 16 2022, 5:58 PM

brennen closed subtask T310747: TypeError: Argument 1 passed to MediaWiki\User\UserFactory::newFromName() must be of the type string, null given as Resolved.Jun 16 2022, 6:43 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-16T18:44:29Z] <brennen> train 1.39.0-wmf.16 (T308069): no current blockers - rolling to all wikis

Change 806278 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] all wikis to 1.39.0-wmf.16

https://gerrit.wikimedia.org/r/806278

Change 806278 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.39.0-wmf.16

https://gerrit.wikimedia.org/r/806278

Mentioned in SAL (#wikimedia-operations) [2022-06-16T18:49:57Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.39.0-wmf.16 refs T308069

Stable at all wikis for a couple of hours. Optimistically resolving.

1.39.0-wmf.16 deployment blockersClosed, ResolvedPublic5 Estimated Story PointsReleaseActions