Horizontal scroll appears on add a link card when there's a long server name.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• iamjessklein
	May 28 2022, 4:23 PM

Description

Issue: When there's an extra long server name, an obtrusive horizontal scroll appears in the Add a Link card. This makes it difficult for contributors to parse the information in the card.

This was observed in usability test B (UT-4)

Screen_Shot_2022-05-13_at_9.40.25_AM.png (356×493 px, 109 KB)

Possible Solution: Truncate the long server name with an ellipsis so that the horizontal scroll won't appear.

Details

	Subject	Repo	Branch	Lines +/-
	ve.ui.MWLinkAnnotationInspector: Prevent long sitenames from messing up the layout	mediawiki/extensions/VisualEditor	master	+6 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T366095 Deploy comment thanking to all wikis
Open	None	T310959 Scale Usability Improvements to all projects
Open	Trizek-WMF	T319146 [Release Ticket] Offer Usability Improvements as default-on feature at all projects (desktop)
Resolved	ppelberg	T302547 [Usability Improvements] Deploy as Beta Feature at all wikis (desktop)
Resolved	ppelberg	T282639 [Release ticket] Deploy Topic Containers as Beta Feature at Partner Wikis
Open	None	T249579 [EPIC] Usability improvements: make the actions, activity and content within talk pages easier to understand
Open	None	T269963 [EPIC] Talk Page Frame
Resolved	ppelberg	T293524 Page Frame: Validate usability
Open	None	T293522 [EPIC] Clearer Talking Affordances
Open	None	T293523 Talking Affordances: Validate usability
Resolved	• iamjessklein	T293520 [Junior and Senior Contributors] Validate usability & usefulness of all Usability Improvements
Resolved	• iamjessklein	T307842 Run Test B (Senior visits Junior's empty user talk to share guidance) and synthesize findings
Resolved	matmarex	T309443 Horizontal scroll appears on add a link card when there's a long server name.

Event Timeline

• iamjessklein created this task.May 28 2022, 4:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2022, 4:23 PM

Probably not relevant in production, but it seems like an easy fix and it would make future tests easier to set up.

Change 802206 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] ve.ui.MWLinkAnnotationInspector: Prevent long sitenames from messing up the layout

https://gerrit.wikimedia.org/r/802206

gerritbot added a project: Patch-For-Review.Jun 1 2022, 9:35 PM

matmarex moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Jun 1 2022, 9:35 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

Change 802206 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ve.ui.MWLinkAnnotationInspector: Prevent long sitenames from messing up the layout

https://gerrit.wikimedia.org/r/802206

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2022, 1:30 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jun 2 2022, 1:36 PM

matmarex added a project: Editing QA.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jun 2 2022, 3:19 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 2 2022, 5:00 PM

Screenshot 2022-06-07 at 16.37.16.png (332×832 px, 40 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Jun 7 2022, 3:43 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Jun 7 2022, 5:05 PM

In T309443#7986335, @EAkinloose wrote:

That’s another thing, this task is not about the existing links’ popups, but the add/edit link ones. You can’t test that on beta cluster, because beta wikis have short wiki names, only on Patch Demo. For example, https://patchdemo.wmflabs.org/wikis/e7aeffdc28/wiki/Main_Page?veaction=edit:

Screenshot 2022-06-07 at 21-26-28 Editing Main Page - Patch demo (802877,6).png (351×535 px, 24 KB)

(fixed).

I better understand now. I was able to test on beta by editing the html

Screenshot 2022-06-07 at 22.54.16.png (1×2 px, 323 KB)

Screenshot 2022-06-07 at 22.54.37.png (586×1 px, 79 KB)

	F35216447: Screenshot 2022-06-07 at 22.55.31.png
	Jun 7 2022, 9:55 PM

	F35216445: Screenshot 2022-06-07 at 22.54.37.png
	Jun 7 2022, 9:55 PM

	F35216443: Screenshot 2022-06-07 at 22.54.16.png
	Jun 7 2022, 9:55 PM

	F35216108: Screenshot 2022-06-07 at 21-26-28 Editing Main Page - Patch demo (802877,6).png
	Jun 7 2022, 7:29 PM

	F35215634: Screenshot 2022-06-07 at 16.37.16.png
	Jun 7 2022, 3:43 PM

	F35185313: Screen_Shot_2022-05-13_at_9.40.25_AM.png
	May 28 2022, 4:23 PM

Horizontal scroll appears on add a link card when there's a long server name.Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Horizontal scroll appears on add a link card when there's a long server name.
Closed, ResolvedPublic
Actions

Related Objects
Search...