Mentioned in SAL (#wikimedia-operations) [2023-01-05T12:02:39Z] <hashar> gerrit: running copy-approvals script to prepare for Gerrit 3.6 upgrade (T309870): ssh -p 29418 gerrit.wikimedia.org gerrit copy-approvals --verbose

The script has completed with:

Labels copied for 2790 project(s) have impacted 19506 change(s)

I ran it a second time:

Labels copied for 2790 project(s) have impacted 0 change(s)

Success!

Note from https://www.gerritcodereview.com/2023-03-31-gerrit-3.8-release-plan.html#end-of-life-for-gerrit-35x

End of Life for Gerrit 3.5.x

Per the support policy mentioned on the project homepage, after 3.8.0 is released 3.5.x will reach end of life and will no longer be actively supported.

Support for 3.6.x and 3.7.x will continue as usual. Users of 3.5.x or earlier are recommended to upgrade to one of these versions.

Gerrit 3.8.0 has been released on May 20th and the 3.5 series has been formally archived this June 8th. Our Gerrit instances are thus running an end of life version.

I ran the copy approvals script again and it has migrated 30 changes!

Labels copied for 2855 project(s) have impacted 30 change(s)

Excluding any line finishing by "DONE":

Copying inferred approvals labels on all projects
> design/codex :   [design/codex,897904] updated
> machinelearning/liftwing/inference-services :   [machinelearning/liftwing/inference-services,883550] updated
> mediawiki/core :   [mediawiki/core,958470] updated
  [mediawiki/core,895366] updated
> mediawiki/extensions/CheckUser :   [mediawiki/extensions/CheckUser,940468] updated
  [mediawiki/extensions/CheckUser,880924] updated
> mediawiki/extensions/Wikibase :   [mediawiki/extensions/Wikibase,883139] updated
> operations/alerts :   [operations/alerts,962056] updated
> operations/deployment-charts :   [operations/deployment-charts,933618] updated
> operations/homer/public :   [operations/homer/public,973769] updated
> operations/mediawiki-config :   [operations/mediawiki-config,880533] updated
  [operations/mediawiki-config,912233] updated
  [operations/mediawiki-config,915041] updated
  [operations/mediawiki-config,934024] updated
  [operations/mediawiki-config,922921] updated
  [operations/mediawiki-config,879148] updated
  [operations/mediawiki-config,913965] updated
  [operations/mediawiki-config,940912] updated
  [operations/mediawiki-config,880989] updated
  [operations/mediawiki-config,890496] updated
> operations/puppet :   [operations/puppet,954316] updated
  [operations/puppet,904532] updated
  [operations/puppet,983135] updated
  [operations/puppet,974163] updated
  [operations/puppet,892948] updated
  [operations/puppet,964551] updated
  [operations/puppet,976954] updated
  [operations/puppet,951856] updated
  [operations/puppet,948581] updated
> operations/software/tools-webservice :   [operations/software/tools-webservice,917880] updated
Labels copied for 2855 project(s) have impacted 30 change(s)

Change 987438 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.6] Merge tag 'v3.6.8' into wmf/stable-3.6

https://gerrit.wikimedia.org/r/987438

Change 987498 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.6] Gerrit 3.6.8 and rebuild plugins

https://gerrit.wikimedia.org/r/987498

Change 987438 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.6] Merge tag 'v3.6.8' into wmf/stable-3.6

https://gerrit.wikimedia.org/r/987438

I have scheduled the upgrade for Thursday January 11st at 9am UTC and announced it on wikitech-l.

Change 987498 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.6] Gerrit 3.6.8 and rebuild plugins

https://gerrit.wikimedia.org/r/987498

Mentioned in SAL (#wikimedia-operations) [2024-01-11T09:10:08Z] <hashar> gerrit: ssh -p 29418 gerrit.wikimedia.org gerrit copy-approvals # T309870

Labels copied for 2856 project(s) have impacted 0 change(s)

Mentioned in SAL (#wikimedia-operations) [2024-01-11T09:21:47Z] <hashar@deploy2002> Started deploy [gerrit/gerrit@e099b0b]: Gerrit to version 3.6.8 # T309870

Mentioned in SAL (#wikimedia-operations) [2024-01-11T09:22:14Z] <hashar@deploy2002> Finished deploy [gerrit/gerrit@e099b0b]: Gerrit to version 3.6.8 # T309870 (duration: 00m 27s)

Mentioned in SAL (#wikimedia-operations) [2024-01-11T09:23:24Z] <hashar@deploy2002> Started deploy [gerrit/gerrit@e099b0b]: Gerrit to version 3.6.8 # T309870

Mentioned in SAL (#wikimedia-operations) [2024-01-11T09:23:31Z] <hashar@deploy2002> Finished deploy [gerrit/gerrit@e099b0b]: Gerrit to version 3.6.8 # T309870 (duration: 00m 07s)

Mentioned in SAL (#wikimedia-operations) [2024-01-11T09:33:35Z] <hashar> Gerrit restarted and its reindexing all changes T309870

The new UI caused significant regressions for the speed of the workflow of manually reviewing of i18n patches:

• No longer one click to open log for failing test, now forced additional click via the Checks tab
• Removal of vote is now hidden behind a popup that takes ~1s to appear after hover

The right side of patch lists looks a bit cluttered in the new version.

Using an ad blocker to block the HTML class named "block" cleans things up nicely.

@Nikerabbit @Novem_Linguae I am upgrading Gerrit to 3.7 next week ( T354885 ). That will bring more UI changes and might address the issue you have reported above.