Page MenuHomePhabricator

New comment: As a contributor, I want to be able to participate in discussion and reply to other contributors comments.
Closed, ResolvedPublic

Assigned To
Authored By
OTichonova
Jun 9 2022, 3:12 PM
Referenced Files
F35394779: Continue in thread.png
Aug 4 2022, 12:56 PM
F35394655: Keep editing.png
Aug 4 2022, 12:56 PM
F35394653: Discard reply_.png
Aug 4 2022, 12:56 PM
F35394651: New comment text.png
Aug 4 2022, 12:56 PM
F35394777: Reply to comment.png
Aug 4 2022, 12:56 PM
F35310141: Sever error while publishing a comment.png
Jul 6 2022, 11:37 PM
F35310139: No internet connection while publishing a comment.png
Jul 6 2022, 11:37 PM
F35294394: Screen Shot 2022-07-01 at 12.12.52 PM.png
Jul 1 2022, 6:52 PM
Tokens
"Love" token, awarded by JMinor.

Description

Why are we doing this?

To contributors and readers a simple way to reply to comments where they do not need to know wikisource and signing comments will be done automatically.

Audience story

As a contributor, I want to be able to participate in discussions and reply to other contributors' comments.

Relevant information

Access

  • Replying to a comment/topic comes from tapping the ‘reply’ button under each comment/topic. This triggers a reply card & keyboard.

Reply card & keyboard

  • The reply card and formating strip pop up together with the keyboard.

Contributors can continue scrolling the comments when the reply card is open.
Contributors can drag the card up and see more text (full card view).

Publishing a new reply

  • Any contributor logged in or logged out can publish a reply.
  • When a contributor is logged out and chooses to publish a reply an alert will appear that notifies them that they are not logged in.
    • Copy: ‘You are not logged in’
    • Next: Illustration
    • Next: ‘Your IP address will be publicly visible if you make any edits. If you log in or create an * account, your edits will be attributed to your username, along with other benefits.’
    • Next: Button ‘Edit without logging in’
    • Next: Button ‘Log in’
    • Next: Button ‘Sign up’
  • Once published the new reply and a snack bar will appear on the page.
    • Snack bar copy: icon-filled check mark
    • Next: ‘Your comment was published’

Deleting/canceling a reply

  • The reply card can be closed by tapping on the ‘x’ icon or by swiping the card all the way down.
    • If there is no text the card closes automatically
    • If there is a text, closing it will trigger an action sheet.
  • Action sheet
    • Copy: ’Are you sure you want to discard this new reply?’
    • Next: Button ‘Discard Reply’
    • Next: Button ‘Keep editing’
Empty replyFirst tapReply with text (half screen)Reply with text (full screen)Publishing when logged outComment publishedClosing/deleting unpublished reply
Reply to comment.png (812×375 px, 52 KB)
Tap text field to reply.png (812×375 px, 40 KB)
New comment text-1.png (812×375 px, 48 KB)
New comment text full modal-1.png (812×375 px, 27 KB)
New comment text full modal.png (812×375 px, 43 KB)
New comment added.png (824×375 px, 65 KB)
New comment text full modal-2.png (812×375 px, 20 KB)
Text styling and more

Audience story
As a contributor, I want to be able to stylize the text I am publishing on talk pages and add additional content, like images and links.

Relevant information

  • Text formating options include:
  • Bold - Similar behavior to ‘bold’ in article Wikisource editing, but here, leave out the quotation marks around the highlighted word.
  • Italic - Similar behavior to ‘italic’ in article Wikisource editing, but here, leave out the quotation marks around the highlighted word.
  • Add an image - Will have similar behavior to adding an image in the article wikisource editing. Is there a need to keep the ‘Media Settings’ page? Maybe for the ‘Alternative text’ description?
  • Add a link - Will it have similar behavior to adding a link in the article Wikisource editing or will one be able to just add the link and have the highlighted text turn blue?

See more information about the UI in the - Figma file ‘Talk pages screens & specs’

Additional research and resources

Event Timeline

LGoto triaged this task as Medium priority.Jun 13 2022, 6:40 PM

Just to follow-up on a comment I made previously during a meeting, the ability to have "half-sheet bottom modals" like in the Figma screenshots here, resizable with custom "detents" that they can be dragged to settle into, is only natively available on iOS 15. The default available behavior on iOS 14 is for modals to either just default to the full screen style on iPhone or the overlay style on iPad.

Hi @OTichonova! Something could fail when the user tries to post the new comment. Can you tell us what this should look like? I would categorize these into two situations: No internet connection and something messed up on the server side. Here's a screenshot of both cases in our current talk page:

No internet connection

Screen Shot 2022-07-01 at 12.14.38 PM.png (998×534 px, 157 KB)

Server-side issue:

Screen Shot 2022-07-01 at 12.12.52 PM.png (998×534 px, 170 KB)

Per planning yesterday: For v1, the plan is for the the reply formatting buttons to only insert the wikitext in the correct spots within the text field, but it will not reflect that formatting until it is posted and inserted in the reply thread. This is because live formatting dips into needing to parse wikitext and use CodeMirror, which is a complication that we don't want to add at this point.

Hi @OTichonova! Something could fail when the user tries to post the new comment. Can you tell us what this should look like? I would categorize these into two situations: No internet connection and something messed up on the server side. Here's a screenshot of both cases in our current talk page:
No internet connection
Server-side issue:

Hi @Tsevener ! Thanks, below are the mocks.

  1. No internet connection
No internet connection while publishing a comment.png (812×375 px, 49 KB)
  1. Server side issue
Sever error while publishing a comment.png (812×375 px, 51 KB)

Also found in T312314

Hi @Tsevener,
I am following up from Tuesday's meeting (in regards to replying to another comment in the thread when people are already writing a reply in a reply card)

  • Looking through different apps I saw that they allow people to jump from responding from one comment to another by keeping the reply card open and just highlighting the new comment they are replying to (I don't think we should do this) but this made me lean away from disabling the other reply buttons in the thread behind the card.
  • I would have people be able to scroll and tap on the other reply buttons -> this would trigger an action sheet asking whether they would like to discard their current reply or keep editing -> then the reply is either discarded or they keep editing.
  • I wonder if the contributor taps to reply to a different comment, and then chooses to discard their current reply, could we pop a new reply card with the new 'Reply to [new username of the new comment]' (this way they wouldn't have to return to the full thread and tap on the new reply again)
Start reply to DavidDavidAdd text to reply and then tap on to reply to another commentAction sheet pops upreply discardedreply card replaced with a new one, which is a reply to AlexisA
Reply to comment.png (812×375 px, 56 KB)
New comment text.png (812×375 px, 50 KB)
Discard reply_.png (812×375 px, 40 KB)
Keep editing.png (812×375 px, 50 KB)
Continue in thread.png (812×375 px, 57 KB)
Tsevener moved this task from Doing to Needs Code Review on the ios-app-v7.0 board.

Things remaining to develop:

  • Need fine print link handling
  • Logged out flow
  • Tapping another reply button flow (see Olga's previous comment)
  • Deleting/canceling a reply action sheet
Tsevener moved this task from Doing to Needs Code Review on the ios-app-v7.0 board.

Things remaining to develop:

Logged out flow

Tsevener moved this task from Doing to Needs Code Review on the ios-app-v7.0 board.

Things are looking good to me, thanks everyone!

ABorbaWMF subscribed.

Looks good from here as well on 7.0.0 (2007)

JMinor claimed this task.
JMinor awarded a token.