Page MenuHomePhabricator
Create Task
Maniphest T311069

Cleanup: Push sidebar down into TwoPaneTransclusionDialogLayout
Closed, ResolvedPublic
Actions

Description

  • Move templateDialog.sidebar down, but keep a reference to this object in templateDialog.
  • Move usages of sidebar down one at a time.
  • Delete reference to sidebar in TemplateDialog

Details

SubjectRepoBranchLines +/-
[WIP] Move outline control adjustment into two-pane layoutmediawiki/extensions/VisualEditormaster+7 -5
Move remove button toggle code to more appropriate placemediawiki/extensions/VisualEditormaster+17 -9
Move sidebar-related event handlers down into BookletLayout forkmediawiki/extensions/VisualEditormaster+41 -39
Move .addPromptedParameters() calls to more canonical placesmediawiki/extensions/VisualEditormaster+11 -20
Move template dialog sidebar clearing to more appropriate placemediawiki/extensions/VisualEditormaster+1 -3
Push parameter resize down into two-pane layoutmediawiki/extensions/VisualEditormaster+22 -22
Merge `set` handler into two-pane classmediawiki/extensions/VisualEditormaster+11 -16
Push ownership of the sidebar down into the two-pane layoutmediawiki/extensions/VisualEditormaster+3 -1
Remove inaccessible ARIA annotation from old sidebarmediawiki/extensions/VisualEditormaster+0 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jun 21 2022, 2:14 PM
awight claimed this task.Jun 22 2022, 6:40 AM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-08 board.
awight updated the task description. (Show Details)
gerritbot added a comment.Jun 22 2022, 6:41 AM

Change 807131 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Push ownership of the sidebar down into the two-pane layout

https://gerrit.wikimedia.org/r/807131

gerritbot added a project: Patch-For-Review.Jun 22 2022, 6:41 AM
gerritbot added a comment.Jun 22 2022, 7:04 AM

Change 807474 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Merge `set` handler into two-pane class

https://gerrit.wikimedia.org/r/807474

gerritbot added a comment.Jun 22 2022, 7:41 AM

Change 807476 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Push parameter resize down into two-pane layout

https://gerrit.wikimedia.org/r/807476

gerritbot added a comment.Jun 22 2022, 8:00 AM

Change 807481 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Move aria annotation into two-pane layout

https://gerrit.wikimedia.org/r/807481

gerritbot added a comment.Jun 22 2022, 8:02 AM

Change 807482 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Move outline control adjustment into two-pane layout

https://gerrit.wikimedia.org/r/807482

awight removed awight as the assignee of this task.Jun 22 2022, 8:08 AM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-06-22.Jun 22 2022, 8:12 AM
Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jun 22 2022, 8:16 AM
gerritbot added a comment.Jun 22 2022, 12:15 PM

Change 807481 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove inaccessible ARIA annotation from old sidebar

https://gerrit.wikimedia.org/r/807481

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 22 2022, 1:00 PM
gerritbot added a comment.Jun 23 2022, 12:20 PM

Change 807131 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Push ownership of the sidebar down into the two-pane layout

https://gerrit.wikimedia.org/r/807131

thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.Jun 24 2022, 8:08 AM
gerritbot added a comment.Jun 24 2022, 12:51 PM

Change 808232 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move remove button toggle code to more appropriate place

https://gerrit.wikimedia.org/r/808232

gerritbot added a comment.Jun 24 2022, 1:11 PM

Change 807474 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Merge `set` handler into two-pane class

https://gerrit.wikimedia.org/r/807474

gerritbot added a comment.Jun 24 2022, 1:25 PM

Change 808237 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move template dialog sidebar clearing to more appropriate place

https://gerrit.wikimedia.org/r/808237

gerritbot added a comment.Jun 24 2022, 1:33 PM

Change 808241 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move sidebar-related event handlers down into BookletLayout fork

https://gerrit.wikimedia.org/r/808241

thiemowmde claimed this task.Jun 24 2022, 1:34 PM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-22 board.
gerritbot added a comment.Jun 27 2022, 12:30 PM

Change 808880 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move .addPromptedParameters() calls to more canonical places

https://gerrit.wikimedia.org/r/808880

gerritbot added a comment.Jun 28 2022, 6:58 AM

Change 807476 abandoned by Awight:

[mediawiki/extensions/VisualEditor@master] Push parameter resize down into two-pane layout

Reason:

Tackle later.

https://gerrit.wikimedia.org/r/807476

gerritbot added a comment.Jun 28 2022, 6:59 AM

Change 808880 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move .addPromptedParameters() calls to more canonical places

https://gerrit.wikimedia.org/r/808880

gerritbot added a comment.Jun 28 2022, 7:13 AM

Change 808237 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move template dialog sidebar clearing to more appropriate place

https://gerrit.wikimedia.org/r/808237

gerritbot added a comment.Jun 28 2022, 12:54 PM

Change 808241 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move sidebar-related event handlers down into BookletLayout fork

https://gerrit.wikimedia.org/r/808241

awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.Jun 29 2022, 2:35 PM
gerritbot added a comment.Jun 29 2022, 2:48 PM

Change 808232 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move remove button toggle code to more appropriate place

https://gerrit.wikimedia.org/r/808232

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:28 PM
gerritbot added a comment.Jul 1 2022, 10:34 AM

Change 807482 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] [WIP] Move outline control adjustment into two-pane layout

Reason:

Nothing done in here seems still relevant.

https://gerrit.wikimedia.org/r/807482

WMDE-Fisch renamed this task from Push sidebar down into TwoPaneTransclusionDialogLayout to Cleanup: Push sidebar down into TwoPaneTransclusionDialogLayout.Jul 4 2022, 1:27 PM
awight closed this task as Resolved.Jul 4 2022, 1:56 PM
awight moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-06-22 board.
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 11 2022, 6:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits