Finishing touches on keyboard shortcuts in the new template dialog
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	thiemowmde
	Oct 28 2021, 8:17 AM

Description

This is split from T290262: Add keyboard shortcuts for VE template dialog.

T299487: Add link to keyboard shortcuts to ? support pop-up
T299490: Add shortcuts to hover tooltips on buttons in adv toolbar
~~Fix bugs~~ T296463: Fix VE Dialog shortcuts not working on some OS/Browser combos
Make sure screenreader users get the shortcuts explained when they are in the dialog, as explained in the note T290262#7457975.
Make sure move and delete options are explained to screenreader users. ( covered by T289653, specifically T291284 )
~~Re-think screenreader instructions to move / delete. An item does not need to be selected to use this keyboard functionality, having it focused is enough. See T295353#7513913.~~ Solved for now via T300971.
Discuss if it makes sense to read out delete options on single template transclusions to screen reader users (while this is not transparent to non screen reader users ) see T295353
T294905: Shortcut to add a template conflicts with existing VE RTL shortcut

List of shortcuts for reference

Shortcut	Action
`⌃`Ctrl/`⌘`Cmd + `⇧`Shift + `↑`/`↓`	Move a part in a multi-part template up/down, when selected in the sidebar
`⌃`Ctrl/`⌘`Cmd + `Del`	Deletes a part (wikitext or template), when selected in the sidebar
`⌃`Ctrl/`⌘`Cmd + `D`	Adds a template (possible if single or multi-part)
`⌃`Ctrl/`⌘`Cmd + `⇧`Shift + `Y`	Adds a wikitext part
`⌃`Ctrl/`⌘`Cmd + `⇧`Shift + `D`	Add undocumented parameter

Details

	Subject	Repo	Branch	Lines +/-
	Add template shortcuts to VisualEditor's keyboard help dialog	mediawiki/extensions/VisualEditor	master	+43 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T289653 Screenreader support for the new VisualEditor template editor sidebar
Resolved		thiemowmde	T290262 Add keyboard shortcuts for VE template dialog
Open		None	T294521 Finishing touches on keyboard shortcuts in the new template dialog
Resolved		thiemowmde	T294905 Shortcut to add a template conflicts with existing VE RTL shortcut
Invalid	BUG REPORT	None	T296463 Fix VE Dialog shortcuts not working on some OS/Browser combos
Duplicate		None	T299486 Shortcut for adding template has another use
Resolved		Andrew-WMDE	T299487 Add link to keyboard shortcuts to ? support pop-up
Resolved		WMDE-Fisch	T302004 Keyboard shortcut link should go to VE dialog section
Resolved		thiemowmde	T299490 Add shortcuts to hover tooltips on buttons in adv toolbar
Resolved		awight	T289049 Disconnect old sidebar from VE template dialog
Resolved		awight	T307188 Clean up feature flags except for new transclusion dialog sidebar
Resolved		WMDE-Fisch	T310859 Remove dead code outside the transclusionDialogNewSidebar flag
Resolved		awight	T310865 Temporarily fork the BookletLayout class
Resolved		awight	T310866 Remove outlineSelectWidget from forked BookletLayout
Resolved		awight	T311296 Decouple forked OutlineControlsWidget from OutlineSelectWidget and merge in our customizations
Resolved		lilients_WMDE	T311223 Fork OutlineControlsWidget
Resolved		awight	T310867 Cleanup: Hide knowledge about bookletLayout children
Resolved		thiemowmde	T310868 Rename template dialog "pocSidebar"
Invalid		None	T310869 Simplify sidebar panel layout
Resolved		thiemowmde	T311069 Cleanup: Push sidebar down into TwoPaneTransclusionDialogLayout

Event Timeline

thiemowmde created this task.Oct 28 2021, 8:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2021, 8:17 AM

thiemowmde added a parent task: T290262: Add keyboard shortcuts for VE template dialog.Oct 28 2021, 8:17 AM

thiemowmde mentioned this in T290262: Add keyboard shortcuts for VE template dialog.

Andrew-WMDE claimed this task.Oct 29 2021, 8:00 AM

Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-10-27 board.

Andrew-WMDE moved this task from Doing to UX/PM Review on the WMDE-TechWish-Sprint-2021-10-27 board.Oct 29 2021, 10:16 AM

Change 735592 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] [WIP] Add template shortcuts to VisualEditor's keyboard help dialog

https://gerrit.wikimedia.org/r/735592

gerritbot added a project: Patch-For-Review.Oct 29 2021, 10:25 AM

With the current WIP patch, changes would look like that on the current shortcut help screen ( when I'm not on a Mac ).

Template Shortcuts Help.png (909×936 px, 143 KB)

With the current WIP patch, changes would look like that on the current shortcut help screen ( when I'm not on a Mac ).

Thanks @WMDE-Fisch - this is very helpful! And definitely needs some design review before it's ready to get picked back up. Will take a look at it this week.

After discussion with @Lena_WMDE it was decided that updating the shortcut conflict is the only thing that needs to be done before deployment. The rest is important to do but it is not a blocker and needs additional design time. Shortcut conflict was split into a separate ticket and then took this one out of the sprint for now until it's ready.

awight updated the task description. (Show Details)Nov 3 2021, 1:34 PM

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Nov 4 2021, 3:41 PM

ECohen_WMDE updated the task description. (Show Details)Nov 25 2021, 9:24 AM

ECohen_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Nov 30 2021, 5:50 PM

WMDE-Fisch closed subtask T294905: Shortcut to add a template conflicts with existing VE RTL shortcut as Resolved.Dec 7 2021, 9:22 AM

WMDE-Fisch updated the task description. (Show Details)Dec 7 2021, 11:58 AM

WMDE-Fisch mentioned this in T295353: Skip irrelevant ARIA descriptions when editing single-part templates.

WMDE-Fisch removed Andrew-WMDE as the assignee of this task.Dec 7 2021, 12:04 PM

WMDE-Fisch added a project: WMDE-TechWish-Maintenance.

ECohen_WMDE added a subtask: T296463: Fix VE Dialog shortcuts not working on some OS/Browser combos.Jan 19 2022, 9:58 AM

ECohen_WMDE mentioned this in T299487: Add link to keyboard shortcuts to ? support pop-up.Jan 19 2022, 10:26 AM

ECohen_WMDE updated the task description. (Show Details)Jan 19 2022, 11:20 AM