Page MenuHomePhabricator

Topics: Subscribe / Unsubscribe
Closed, ResolvedPublic

Description

This task represents the subscribing and unsubscribing functionality to a talk page topic. Please see parent task for requirements.

API calls for this will be done as a part of T311071. This task represents hooking into it via the UI.

Additional note for QA
We had to change the layout logic across all banners of this kind, so please keep an eye out for any regressions around these banners in other areas of the app.

Event Timeline

LGoto triaged this task as Medium priority.Jul 18 2022, 6:42 PM
LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.
Tsevener moved this task from Needs Code Review to Needs Design Review on the ios-app-v7.0 board.
Tsevener moved this task from Needs Design Review to Needs QA on the ios-app-v7.0 board.
Tsevener moved this task from Needs QA to Needs Design Review on the ios-app-v7.0 board.
Tsevener added a subscriber: Mazevedo.

Hi @Tsevener,
I know we don't have much control over the snackbar but there are two minor things I found for the subscribe/unsubscribe.

  1. The padding around the bottom of the text is very thin, looks like the snackbar is cut off at the bottom. I was wondering if we could have the same padding above and below the text?
  2. The 'Title' of the snackbar (e.g. 'You have subscribed') is supposed to be a dark gray/black color, while currently in the app it is blue. I was wondering if we could change that?
Subscribe snackbar in appSubscribe snackbar in designs
IMG_9210.png (667×375 px, 64 KB)
Subscribed to topic.png (812×375 px, 70 KB)

Thanks!

Things remaining to develop:

Design review feedback in previous comment ^

Tsevener moved this task from Doing to Needs Code Review on the ios-app-v7.0 board.

Hi! It is looking good! The only issue is what has been mentioned here T312314#8369807 (in sepia the background color of the toast is incorrect). Waiting for this to be changed before moving this to QA.

ABorbaWMF subscribed.

Looks good to me on 7.0.0 (2007)

JMinor claimed this task.