Page MenuHomePhabricator
Create Task
Maniphest T312149

[1.40 release] Remove SkinTemplateNavigation and SkinTemplateNavigation::SpecialPage hooks
Open, HighPublicFeature
Actions

Description

In T255319 these hooks were deprecated. This ticket tracks removing the code.

https://codesearch.wmcloud.org/search/?q=SkinTemplateNavigation%22%3A&i=nope&files=&excludeFiles=&repos=

Also impacted:

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 5 2022, 6:11 PM
Restricted Application added a subscriber: Lens0021. · View Herald TranscriptJul 5 2022, 6:11 PM
Yaron_Koren removed a project: MediaWiki-extensions-Page_Forms.Jul 6 2022, 3:47 AM
Dreamy_Jazz subscribed.Jul 7 2022, 8:55 PM
This comment was removed by Dreamy_Jazz.
Dreamy_Jazz added a comment.Jul 7 2022, 9:01 PM
This comment was removed by Dreamy_Jazz.
Dreamy_Jazz added a comment.Jul 7 2022, 9:03 PM

For some reason the issues I was having have now fixed themselves. Maybe a cache issue.

Sebastian_Berlin-WMSE subscribed.Jul 8 2022, 2:48 PM

I'm having some trouble with this for Wikispeech. Codesniffer doesn't like the function name onSkinTemplateNavigation__Universal which is implemented from SkinTemplateNavigation__UniversalHook.

Full Jenkins log:

P30994 Jenkins log for CS error for onSkinTemplateNavigation__Universal
1Started by user unknown or anonymous
2Running as SYSTEM
3Building remotely on integration-agent-docker-1027 (pipelinelib Docker blubber) in workspace /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker
4[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins10606776843918457310.sh
5+ mkdir -m 2777 -p cache
6[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash /tmp/jenkins356463317631148967.sh
7+ set -o pipefail
8++ pwd
9+ exec docker run --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/cache:/cache --security-opt seccomp=unconfined --init --rm --label jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --label jenkins.build=162541 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/castor:0.2.6 load
10++ /usr/bin/env
11++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
12Defined: CASTOR_NAMESPACE="castor-mw-ext-and-skins/master/quibble-vendor-mysql-php72-noselenium-docker"
13Syncing...
14rsync: failed to set times on "/cache/.": Operation not permitted (1)
15rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1668) [generator=3.1.2]
16
17Done
18[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins8627336879981665063.sh
19+ set -eux
20+ mkdir -m 2777 -p log
21[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash /tmp/jenkins14810978237879327183.sh
22+ set -o pipefail
23+ exec docker run --entrypoint=/usr/bin/find --user=nobody --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker:/workspace --security-opt seccomp=unconfined --init --rm --label jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --label jenkins.build=162541 --env-file /dev/fd/63 docker-registry.wikimedia.org/buster:latest /workspace/log -mindepth 1 -delete
24++ /usr/bin/env
25++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
26[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins7868341659664963838.sh
27+ set -eux
28+ mkdir -m 2777 -p src
29[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash /tmp/jenkins1864859460190787341.sh
30+ set -o pipefail
31+ exec docker run --entrypoint=/usr/bin/find --user=nobody --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker:/workspace --security-opt seccomp=unconfined --init --rm --label jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --label jenkins.build=162541 --env-file /dev/fd/63 docker-registry.wikimedia.org/buster:latest /workspace/src -mindepth 1 -delete
32++ /usr/bin/env
33++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
34[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -eu /tmp/jenkins6970774065375995123.sh
35+ chmod 2777 src
36[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash /tmp/jenkins9999101630721265915.sh
37+ set -o pipefail
38++ pwd
39++ pwd
40++ pwd
41+ exec docker run --entrypoint=quibble-with-supervisord --tmpfs /workspace/db:size=320M --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/src:/workspace/src --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/cache:/cache --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/log:/workspace/log --volume /srv/git:/srv/git:ro --security-opt seccomp=unconfined --init --rm --label jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --label jenkins.build=162541 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/quibble-buster-php72:1.4.5-s1 --packages-source vendor --db mysql --db-dir /workspace/db --git-parallel=8 --skip selenium,npm-test,phpunit-standalone,api-testing
42++ /usr/bin/env
43++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
44+ /usr/bin/supervisord -c /etc/supervisor/supervisord.conf
452022-07-08 14:35:25,044 INFO Included extra file "/etc/supervisor/conf.d/supervisord.conf" during parsing
462022-07-08 14:35:25,057 INFO RPC interface 'supervisor' initialized
472022-07-08 14:35:25,057 CRIT Server 'unix_http_server' running without any HTTP authentication checking
482022-07-08 14:35:25,058 INFO daemonizing the supervisord process
492022-07-08 14:35:25,059 CRIT could not write pidfile /var/run/supervisord.pid
50+ exec /usr/local/bin/quibble --web-backend=external --web-url=http://127.0.0.1:9413 --packages-source vendor --db mysql --db-dir /workspace/db --git-parallel=8 --skip selenium,npm-test,phpunit-standalone,api-testing
51DEBUG:quibble.cmd:ZUUL_PROJECT=mediawiki/extensions/Wikispeech
52INFO:quibble.cmd:Adding mediawiki/vendor
53INFO:quibble.cmd:Projects: mediawiki/core, mediawiki/extensions/Wikispeech, mediawiki/skins/Vector, mediawiki/vendor
54INFO:zuul.CloneMapper:Workspace path set to: ./
55INFO:zuul.CloneMapper:Mapping projects to workspace...
56INFO:zuul.CloneMapper: mediawiki/extensions/Wikispeech -> extensions/Wikispeech
57INFO:zuul.CloneMapper:Expansion completed.
58DEBUG:quibble.cmd:Running stages: phpunit-unit, phpbench, phpunit, composer-test, qunit
59DEBUG:quibble.cmd:Execution plan:
60DEBUG:quibble.cmd:Report package versions
61DEBUG:quibble.cmd:Ensure we have the directory '/workspace/log'
62DEBUG:quibble.cmd:Zuul clone with parameters {"cache_dir": "/srv/git", "projects": ["mediawiki/core", "mediawiki/extensions/Wikispeech", "mediawiki/skins/Vector", "mediawiki/vendor"], "workers": 8, "workspace": "/workspace/src", "zuul_branch": "master", "zuul_project": "mediawiki/extensions/Wikispeech", "zuul_ref": "refs/zuul/master/Z5b4005d448f8458b84186aa94a55b0f7", "zuul_url": "git://contint2001.wikimedia.org"}
63DEBUG:quibble.cmd:Extension and skin submodule update under MediaWiki root /workspace/src
64DEBUG:quibble.cmd:Run npm and composer tests, if present in parallel (concurrency=1):
65* composer test in /workspace/src/extensions/Wikispeech
66DEBUG:quibble.cmd:Revert to git clean -xqdf in /workspace/src/extensions/Wikispeech
67DEBUG:quibble.cmd:Install composer dev-requires for vendor.git
68DEBUG:quibble.cmd:Start backends, <MySQL (no socket)>
69DEBUG:quibble.cmd:Run Post-dependency install, pre-database dependent steps in parallel (concurrency=3):
70* PHPUnit unit tests
71* Install MediaWiki, db=<MySQL (no socket)> vendor=True
72* npm install in /workspace/src
73DEBUG:quibble.cmd:PHPUnit extensions suite (without database or standalone)
74DEBUG:quibble.cmd:Run phpbench
75DEBUG:quibble.cmd:Start backends, <ExternalWebserver http://127.0.0.1:9413 /workspace/src> <Xvfb :94> <ChromeWebDriver :94>
76DEBUG:quibble.cmd:Run Qunit tests
77DEBUG:quibble.cmd:PHPUnit extensions suite (with database)
78INFO:quibble.commands:>>> Start: Report package versions
79INFO:quibble.commands:Python version: 3.7.3 (default, Jan 22 2021, 20:04:44)
80[GCC 8.3.0]
81INFO:quibble.commands:chromedriver --version: ChromeDriver 90.0.4430.212 (e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429})
82INFO:quibble.commands:chromium --version: Chromium 90.0.4430.212 built on Debian 10.9, running on Debian 10.10
83INFO:quibble.commands:composer --version: Composer version 2.3.3 2022-04-01 22:15:35
84INFO:quibble.commands:mysql --version: mysql Ver 15.1 Distrib 10.3.34-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
85INFO:quibble.commands:psql --version: psql (PostgreSQL) 11.14 (Debian 11.14-0+deb10u1)
86INFO:quibble.commands:node --version: v14.17.5
87INFO:quibble.commands:npm --version: 7.21.0
88INFO:quibble.commands:php --version: PHP 7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf5 (cli) (built: Dec 15 2021 23:28:21) ( NTS )
89INFO:quibble.commands:Copyright (c) 1997-2018 The PHP Group
90INFO:quibble.commands:Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
91INFO:quibble.commands: with Zend OPcache v7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf5, Copyright (c) 1999-2018, by Zend Technologies
92INFO:quibble.commands:<<< Finish: Report package versions, in 0.730 s
93INFO:quibble.commands:>>> Start: Ensure we have the directory '/workspace/log'
94INFO:quibble.commands:<<< Finish: Ensure we have the directory '/workspace/log', in 0.000 s
95INFO:quibble.commands:>>> Start: Zuul clone with parameters {"cache_dir": "/srv/git", "projects": ["mediawiki/core", "mediawiki/extensions/Wikispeech", "mediawiki/skins/Vector", "mediawiki/vendor"], "workers": 8, "workspace": "/workspace/src", "zuul_branch": "master", "zuul_project": "mediawiki/extensions/Wikispeech", "zuul_ref": "refs/zuul/master/Z5b4005d448f8458b84186aa94a55b0f7", "zuul_url": "git://contint2001.wikimedia.org"}
96INFO:zuul.CloneMapper:Workspace path set to: /workspace/src
97INFO:zuul.CloneMapper:Mapping projects to workspace...
98INFO:zuul.CloneMapper: mediawiki/core -> /workspace/src
99INFO:zuul.CloneMapper: mediawiki/extensions/Wikispeech -> /workspace/src/extensions/Wikispeech
100INFO:zuul.CloneMapper: mediawiki/skins/Vector -> /workspace/src/skins/Vector
101INFO:zuul.CloneMapper: mediawiki/vendor -> /workspace/src/vendor
102INFO:zuul.CloneMapper:Expansion completed.
103INFO:quibble.zuul.clone:Preparing 4 repositories with 8 workers
104INFO:quibble.zuul.clone:Cloning mediawiki/core first
105INFO:zuul.Cloner:Creating repo mediawiki/core from cache /srv/git/mediawiki/core.git
1062022-07-08 14:35:26,062 INFO spawned: 'apache' with pid 60
1072022-07-08 14:35:26,065 INFO spawned: 'php-fpm' with pid 61
1082022-07-08 14:35:26,068 INFO spawned: 'memcached' with pid 62
1092022-07-08 14:35:26,108 INFO success: php-fpm entered RUNNING state, process has stayed up for > than 0 seconds (startsecs)
1102022-07-08 14:35:27,137 INFO success: apache entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
1112022-07-08 14:35:27,138 INFO success: memcached entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
112INFO:zuul.Cloner:Updating origin remote in repo mediawiki/core to https://gerrit.wikimedia.org/r/mediawiki/core
113INFO:zuul.Cloner:upstream repo has branch master
114INFO:zuul.Cloner:Falling back to branch master
115INFO:zuul.Cloner:Prepared mediawiki/core repo with branch master at commit 99aad54ea856479fa29fcced81734dd0c17ddcbd
116INFO:zuul.Cloner.mediawiki/skins/Vector:Creating repo mediawiki/skins/Vector from cache /srv/git/mediawiki/skins/Vector.git
117INFO:zuul.Cloner.mediawiki/vendor:Creating repo mediawiki/vendor from cache /srv/git/mediawiki/vendor.git
118INFO:zuul.Cloner.mediawiki/extensions/Wikispeech:Creating repo mediawiki/extensions/Wikispeech from upstream https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikispeech
119INFO:zuul.Cloner.mediawiki/skins/Vector:Updating origin remote in repo mediawiki/skins/Vector to https://gerrit.wikimedia.org/r/mediawiki/skins/Vector
120INFO:zuul.Cloner.mediawiki/extensions/Wikispeech:upstream repo has branch master
121INFO:zuul.Cloner.mediawiki/extensions/Wikispeech:Prepared mediawiki/extensions/Wikispeech repo with commit 66475bbf73d7d20ed5e1a5e52dec57369369b314
122INFO:zuul.Cloner.mediawiki/skins/Vector:upstream repo has branch master
123INFO:zuul.Cloner.mediawiki/vendor:Updating origin remote in repo mediawiki/vendor to https://gerrit.wikimedia.org/r/mediawiki/vendor
124INFO:zuul.Cloner.mediawiki/skins/Vector:Falling back to branch master
125INFO:zuul.Cloner.mediawiki/skins/Vector:Prepared mediawiki/skins/Vector repo with branch master at commit 189b953096556d8c7524986de4318ee5b3969026
126INFO:zuul.Cloner.mediawiki/vendor:upstream repo has branch master
127INFO:zuul.Cloner.mediawiki/vendor:Falling back to branch master
128INFO:zuul.Cloner.mediawiki/vendor:Prepared mediawiki/vendor repo with branch master at commit 3f686eddfdf3348628226bf74fac2cca184f34e0
129INFO:quibble.zuul.clone:Prepared all repositories
130INFO:quibble.commands:<<< Finish: Zuul clone with parameters {"cache_dir": "/srv/git", "projects": ["mediawiki/core", "mediawiki/extensions/Wikispeech", "mediawiki/skins/Vector", "mediawiki/vendor"], "workers": 8, "workspace": "/workspace/src", "zuul_branch": "master", "zuul_project": "mediawiki/extensions/Wikispeech", "zuul_ref": "refs/zuul/master/Z5b4005d448f8458b84186aa94a55b0f7", "zuul_url": "git://contint2001.wikimedia.org"}, in 11.289 s
131INFO:quibble.commands:>>> Start: Extension and skin submodule update under MediaWiki root /workspace/src
132INFO:quibble.commands:Updating git submodules of extensions and skins
133INFO:quibble.commands:<<< Finish: Extension and skin submodule update under MediaWiki root /workspace/src, in 0.000 s
134INFO:quibble.commands:>>> Start: Run npm and composer tests, if present in parallel (concurrency=1):
135* composer test in /workspace/src/extensions/Wikispeech
136INFO:quibble.commands:>>> Start: composer test in /workspace/src/extensions/Wikispeech
137./composer.json is valid for simple usage with Composer but has
138strict errors that make it unable to be published as a package
139See https://getcomposer.org/doc/04-schema.md for details on the schema
140# General warnings
141- No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.
142# Publish warnings
143- name : The property name is required
144- description : The property description is required
145[8.4MiB/0.09s] No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
146[8.5MiB/0.09s] Loading composer repositories with package information
147[8.9MiB/0.20s] Info from https://repo.packagist.org: #StandWithUkraine
148[11.5MiB/1.69s] Updating dependencies
149[12.6MiB/1.70s] Dependency resolution completed in 0.001 seconds
150[12.2MiB/1.70s] Analyzed 248 packages to resolve dependencies
151[12.2MiB/1.70s] Analyzed 535 rules to resolve dependencies
152[11.7MiB/1.70s] Dependency resolution completed in 0.000 seconds
153[10.6MiB/1.70s] Lock file operations: 34 installs, 0 updates, 0 removals
154[10.6MiB/1.70s] Installs: composer/pcre:1.0.1, squizlabs/php_codesniffer:3.6.1, composer/spdx-licenses:1.5.7, composer/semver:3.3.2, symfony/polyfill-mbstring:v1.26.0, mediawiki/mediawiki-codesniffer:v38.0.0, tysonandre/var_representation_polyfill:0.1.1, symfony/polyfill-php80:v1.26.0, symfony/polyfill-intl-normalizer:v1.26.0, symfony/polyfill-intl-grapheme:v1.26.0, symfony/polyfill-ctype:v1.26.0, symfony/string:v5.4.10, symfony/deprecation-contracts:v2.5.2, psr/container:1.1.1, symfony/service-contracts:v2.5.2, symfony/polyfill-php73:v1.26.0, symfony/console:v5.4.10, sabre/event:5.1.4, netresearch/jsonmapper:v4.0.0, microsoft/tolerant-php-parser:v0.1.1, phpdocumentor/reflection-common:2.2.0, webmozart/assert:1.11.0, phpdocumentor/type-resolver:1.6.1, phpdocumentor/reflection-docblock:5.3.0, felixfbecker/advanced-json-rpc:v3.2.1, psr/log:1.1.4, composer/xdebug-handler:2.0.5, phan/phan:5.2.0, mediawiki/phan-taint-check-plugin:3.3.2, mediawiki/mediawiki-phan-config:0.11.0, mediawiki/minus-x:1.1.1, php-parallel-lint/php-console-color:v0.3, php-parallel-lint/php-console-highlighter:v0.5, php-parallel-lint/php-parallel-lint:v1.3.1
155[10.6MiB/1.70s] - Locking composer/pcre (1.0.1)
156[10.6MiB/1.70s] - Locking composer/semver (3.3.2)
157[10.6MiB/1.70s] - Locking composer/spdx-licenses (1.5.7)
158[10.6MiB/1.70s] - Locking composer/xdebug-handler (2.0.5)
159[10.6MiB/1.70s] - Locking felixfbecker/advanced-json-rpc (v3.2.1)
160[10.6MiB/1.70s] - Locking mediawiki/mediawiki-codesniffer (v38.0.0)
161[10.6MiB/1.70s] - Locking mediawiki/mediawiki-phan-config (0.11.0)
162[10.6MiB/1.70s] - Locking mediawiki/minus-x (1.1.1)
163[10.6MiB/1.70s] - Locking mediawiki/phan-taint-check-plugin (3.3.2)
164[10.6MiB/1.70s] - Locking microsoft/tolerant-php-parser (v0.1.1)
165[10.6MiB/1.70s] - Locking netresearch/jsonmapper (v4.0.0)
166[10.6MiB/1.70s] - Locking phan/phan (5.2.0)
167[10.6MiB/1.70s] - Locking php-parallel-lint/php-console-color (v0.3)
168[10.6MiB/1.70s] - Locking php-parallel-lint/php-console-highlighter (v0.5)
169[10.6MiB/1.70s] - Locking php-parallel-lint/php-parallel-lint (v1.3.1)
170[10.6MiB/1.70s] - Locking phpdocumentor/reflection-common (2.2.0)
171[10.6MiB/1.70s] - Locking phpdocumentor/reflection-docblock (5.3.0)
172[10.6MiB/1.70s] - Locking phpdocumentor/type-resolver (1.6.1)
173[10.6MiB/1.70s] - Locking psr/container (1.1.1)
174[10.6MiB/1.70s] - Locking psr/log (1.1.4)
175[10.6MiB/1.70s] - Locking sabre/event (5.1.4)
176[10.6MiB/1.70s] - Locking squizlabs/php_codesniffer (3.6.1)
177[10.6MiB/1.70s] - Locking symfony/console (v5.4.10)
178[10.6MiB/1.70s] - Locking symfony/deprecation-contracts (v2.5.2)
179[10.6MiB/1.70s] - Locking symfony/polyfill-ctype (v1.26.0)
180[10.6MiB/1.70s] - Locking symfony/polyfill-intl-grapheme (v1.26.0)
181[10.6MiB/1.70s] - Locking symfony/polyfill-intl-normalizer (v1.26.0)
182[10.6MiB/1.70s] - Locking symfony/polyfill-mbstring (v1.26.0)
183[10.6MiB/1.70s] - Locking symfony/polyfill-php73 (v1.26.0)
184[10.6MiB/1.70s] - Locking symfony/polyfill-php80 (v1.26.0)
185[10.6MiB/1.70s] - Locking symfony/service-contracts (v2.5.2)
186[10.6MiB/1.70s] - Locking symfony/string (v5.4.10)
187[10.6MiB/1.70s] - Locking tysonandre/var_representation_polyfill (0.1.1)
188[10.6MiB/1.70s] - Locking webmozart/assert (1.11.0)
189[10.6MiB/1.70s] Writing lock file
190[10.6MiB/1.70s] Installing dependencies from lock file (including require-dev)
191[11.0MiB/1.71s] Package operations: 34 installs, 0 updates, 0 removals
192[11.1MiB/1.71s] Installs: composer/pcre:1.0.1, squizlabs/php_codesniffer:3.6.1, symfony/polyfill-mbstring:v1.26.0, composer/spdx-licenses:1.5.7, composer/semver:3.3.2, mediawiki/mediawiki-codesniffer:v38.0.0, tysonandre/var_representation_polyfill:0.1.1, symfony/polyfill-php80:v1.26.0, symfony/polyfill-intl-normalizer:v1.26.0, symfony/polyfill-intl-grapheme:v1.26.0, symfony/polyfill-ctype:v1.26.0, symfony/string:v5.4.10, symfony/deprecation-contracts:v2.5.2, psr/container:1.1.1, symfony/service-contracts:v2.5.2, symfony/polyfill-php73:v1.26.0, symfony/console:v5.4.10, sabre/event:5.1.4, netresearch/jsonmapper:v4.0.0, microsoft/tolerant-php-parser:v0.1.1, webmozart/assert:1.11.0, phpdocumentor/reflection-common:2.2.0, phpdocumentor/type-resolver:1.6.1, phpdocumentor/reflection-docblock:5.3.0, felixfbecker/advanced-json-rpc:v3.2.1, psr/log:1.1.4, composer/xdebug-handler:2.0.5, phan/phan:5.2.0, mediawiki/phan-taint-check-plugin:3.3.2, mediawiki/mediawiki-phan-config:0.11.0, mediawiki/minus-x:1.1.1, php-parallel-lint/php-console-color:v0.3, php-parallel-lint/php-console-highlighter:v0.5, php-parallel-lint/php-parallel-lint:v1.3.1
193[11.1MiB/1.71s] - Downloading symfony/polyfill-mbstring (v1.26.0)
194[11.1MiB/1.71s] - Downloading composer/spdx-licenses (1.5.7)
195[11.1MiB/1.71s] - Downloading composer/semver (3.3.2)
196[11.2MiB/1.71s] - Downloading symfony/polyfill-php80 (v1.26.0)
197[11.2MiB/1.71s] - Downloading symfony/polyfill-intl-normalizer (v1.26.0)
198[11.3MiB/1.71s] - Downloading symfony/polyfill-intl-grapheme (v1.26.0)
199[11.3MiB/1.71s] - Downloading symfony/polyfill-ctype (v1.26.0)
200[11.3MiB/1.71s] - Downloading symfony/string (v5.4.10)
201[11.4MiB/1.71s] - Downloading symfony/deprecation-contracts (v2.5.2)
202[11.4MiB/1.71s] - Downloading symfony/service-contracts (v2.5.2)
203[11.4MiB/1.71s] - Downloading symfony/polyfill-php73 (v1.26.0)
204[11.5MiB/1.72s] - Downloading symfony/console (v5.4.10)
205[11.5MiB/1.72s] - Downloading webmozart/assert (1.11.0)
206[11.3MiB/2.03s] - Installing composer/pcre (1.0.1): Extracting archive
207[11.5MiB/2.04s] - Installing squizlabs/php_codesniffer (3.6.1): Extracting archive
208[11.5MiB/2.04s] - Installing symfony/polyfill-mbstring (v1.26.0): Extracting archive
209[11.6MiB/2.05s] - Installing composer/spdx-licenses (1.5.7): Extracting archive
210[11.6MiB/2.05s] - Installing composer/semver (3.3.2): Extracting archive
211[11.6MiB/2.06s] - Installing mediawiki/mediawiki-codesniffer (v38.0.0): Extracting archive
212[11.7MiB/2.07s] - Installing tysonandre/var_representation_polyfill (0.1.1): Extracting archive
213[11.7MiB/2.07s] - Installing symfony/polyfill-php80 (v1.26.0): Extracting archive
214[11.8MiB/2.07s] - Installing symfony/polyfill-intl-normalizer (v1.26.0): Extracting archive
215[11.8MiB/2.08s] - Installing symfony/polyfill-intl-grapheme (v1.26.0): Extracting archive
216[11.9MiB/2.08s] - Installing symfony/polyfill-ctype (v1.26.0): Extracting archive
217[11.9MiB/2.08s] - Installing symfony/string (v5.4.10): Extracting archive
218[11.9MiB/2.08s] - Installing symfony/deprecation-contracts (v2.5.2): Extracting archive
219[12.0MiB/2.08s] - Installing psr/container (1.1.1): Extracting archive
220[12.0MiB/2.08s] - Installing symfony/service-contracts (v2.5.2): Extracting archive
221[12.1MiB/2.08s] - Installing symfony/polyfill-php73 (v1.26.0): Extracting archive
222[12.1MiB/2.08s] - Installing symfony/console (v5.4.10): Extracting archive
223[12.1MiB/2.08s] - Installing sabre/event (5.1.4): Extracting archive
224[12.2MiB/2.09s] - Installing netresearch/jsonmapper (v4.0.0): Extracting archive
225[12.2MiB/2.09s] - Installing microsoft/tolerant-php-parser (v0.1.1): Extracting archive
226[12.2MiB/2.09s] - Installing webmozart/assert (1.11.0): Extracting archive
227[12.3MiB/2.09s] - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
228[12.3MiB/2.09s] - Installing phpdocumentor/type-resolver (1.6.1): Extracting archive
229[12.4MiB/2.09s] - Installing phpdocumentor/reflection-docblock (5.3.0): Extracting archive
230[12.4MiB/2.09s] - Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
231[12.4MiB/2.09s] - Installing psr/log (1.1.4): Extracting archive
232[12.5MiB/2.09s] - Installing composer/xdebug-handler (2.0.5): Extracting archive
233[12.5MiB/2.09s] - Installing phan/phan (5.2.0): Extracting archive
234[12.5MiB/2.09s] - Installing mediawiki/phan-taint-check-plugin (3.3.2): Extracting archive
235[12.6MiB/2.09s] - Installing mediawiki/mediawiki-phan-config (0.11.0): Extracting archive
236[12.6MiB/2.09s] - Installing mediawiki/minus-x (1.1.1): Extracting archive
237[12.6MiB/2.09s] - Installing php-parallel-lint/php-console-color (v0.3): Extracting archive
238[12.7MiB/2.09s] - Installing php-parallel-lint/php-console-highlighter (v0.5): Extracting archive
239[12.7MiB/2.09s] - Installing php-parallel-lint/php-parallel-lint (v1.3.1): Extracting archive
240[11.2MiB/4.75s] 7 package suggestions were added by new dependencies, use `composer suggest` to see details.
241[11.3MiB/4.75s] Generating autoload files
242[11.5MiB/4.77s] 14 packages you are using are looking for funding.
243[11.5MiB/4.77s] Use the `composer fund` command to find out more!
244[11.4MiB/4.77s] Memory usage: 11.45MiB (peak: 15.19MiB), time: 4.77s
245> parallel-lint . --exclude vendor --exclude node_modules
246PHP 7.2.34 | 10 parallel jobs
247............................................................ 60/107 (56 %)
248............................................... 107/107 (100 %)
249
250
251Checked 107 files in 0.3 seconds
252No syntax error found
253> phpcs -sp --cache
254............................................................ 60 / 107 (56%)
255...........................................E... 107 / 107 (100%)
256
257
258
259FILE: /workspace/src/extensions/Wikispeech/includes/Hooks/ApiHooks.php
260----------------------------------------------------------------------
261FOUND 1 ERROR AFFECTING 1 LINE
262----------------------------------------------------------------------
263 455 | ERROR | Function name "onSkinTemplateNavigation__Universal"
264 | | should use lower camel case.
265 | | (MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName)
266----------------------------------------------------------------------
267
268Time: 1.55 secs; Memory: 18MB
269
270Script phpcs -sp --cache handling the phpcs event returned with error code 1
271Script @phpcs was called via test
272INFO:quibble.commands:<<< Finish: composer test in /workspace/src/extensions/Wikispeech, in 7.408 s
273INFO:quibble.commands:<<< Finish: Run npm and composer tests, if present in parallel (concurrency=1):
274* composer test in /workspace/src/extensions/Wikispeech, in 7.409 s
275Traceback (most recent call last):
276 File "/usr/local/bin/quibble", line 10, in <module>
277 sys.exit(main())
278 File "/usr/local/lib/python3.7/dist-packages/quibble/cmd.py", line 783, in main
279 cmd.execute(plan, dry_run=args.dry_run)
280 File "/usr/local/lib/python3.7/dist-packages/quibble/cmd.py", line 512, in execute
281 quibble.commands.execute_command(command)
282 File "/usr/local/lib/python3.7/dist-packages/quibble/commands.py", line 26, in execute_command
283 command.execute()
284 File "/usr/local/lib/python3.7/dist-packages/quibble/commands.py", line 993, in execute
285 return execute_command(self.steps[0])
286 File "/usr/local/lib/python3.7/dist-packages/quibble/commands.py", line 26, in execute_command
287 command.execute()
288 File "/usr/local/lib/python3.7/dist-packages/quibble/commands.py", line 291, in execute
289 subprocess.check_call(cmd, cwd=self.directory)
290 File "/usr/lib/python3.7/subprocess.py", line 347, in check_call
291 raise CalledProcessError(retcode, cmd)
292subprocess.CalledProcessError: Command '['composer', '--ansi', 'test']' returned non-zero exit status 1.
293Build step 'Execute shell' marked build as failure
294[PostBuildScript] - [INFO] Executing post build scripts.
295[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins10389989475705858491.sh
296+ find log/ -name 'junit*.xml' -exec gzip '{}' +
297[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash /tmp/jenkins13918247223115944641.sh
298+ set -o pipefail
299++ pwd
300+ exec docker run --entrypoint=/bin/rm --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/log:/log --security-opt seccomp=unconfined --init --rm --label jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --label jenkins.build=162541 --env-file /dev/fd/63 docker-registry.wikimedia.org/buster:latest -fR /log/rawSeleniumVideoGrabs
301++ /usr/bin/env
302++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
303[PostBuildScript] - [INFO] Executing post build scripts.
304[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins13319280809241872881.sh
305+ find log/ -name 'mw-debug-*.log' -exec gzip '{}' +
306Archiving artifacts
307[PostBuildScript] - [INFO] Executing post build scripts.
308[PostBuildScript] - [INFO] Build does not have any of the results [SUCCESS]. Did not execute build step #0.
309[PostBuildScript] - [INFO] Executing post build scripts.
310[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins14595082334576601781.sh
311+ echo 'Clearing /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/cache'
312Clearing /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/cache
313[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash /tmp/jenkins4131363825806358674.sh
314+ set -o pipefail
315++ pwd
316+ exec docker run --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker/cache:/cache --security-opt seccomp=unconfined --init --rm --label jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --label jenkins.build=162541 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/castor:0.2.6 clear
317++ /usr/bin/env
318++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
319[PostBuildScript] - [INFO] Executing post build scripts.
320[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins12137139544459185196.sh
321+ set -euxo pipefail
322+ docker ps -q --filter label=jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --filter label=jenkins.build=162541
323+ xargs --no-run-if-empty docker stop
324[PostBuildScript] - [INFO] Executing post build scripts.
325[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash /tmp/jenkins14495910996214305149.sh
326+ set -o pipefail
327+ exec docker run --entrypoint=/usr/bin/find --user=root --volume /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker:/workspace --security-opt seccomp=unconfined --init --rm --label jenkins.job=quibble-vendor-mysql-php72-noselenium-docker --label jenkins.build=162541 --env-file /dev/fd/63 docker-registry.wikimedia.org/buster:latest /workspace -mindepth 1 -delete
328++ /usr/bin/env
329++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
330[quibble-vendor-mysql-php72-noselenium-docker] $ /bin/bash -xe /tmp/jenkins1169709164204022633.sh
331+ set -u
332+ rmdir /srv/jenkins/workspace/quibble-vendor-mysql-php72-noselenium-docker
333Finished: FAILURE

Dreamy_Jazz unsubscribed.Jul 8 2022, 2:50 PM
Lens0021 added a comment.Jul 8 2022, 3:40 PM
In T312149#8065546, @Sebastian_Berlin-WMSE wrote:

I'm having some trouble with this for Wikispeech. Codesniffer doesn't like the function name onSkinTemplateNavigation__Universal which is implemented from SkinTemplateNavigation__UniversalHook.

As a third-party developer, I've applied // phpcs:disable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName in the file scope. I am also curious if this is the best.

Jdlrobson added a comment.Jul 8 2022, 4:04 PM

That's annoying. I wonder if it makes sense to rename the core class and add an alias?

Jdlrobson moved this task from Backlog to Deprecations and removals on the MediaWiki-Core-Skin-Architecture board.Jul 11 2022, 4:18 PM
gerritbot added a comment.Jul 11 2022, 7:50 PM

Change 812946 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/FlexDiagrams@master] Replace SkinTemplateNavigation w/ SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/812946

gerritbot added a project: Patch-For-Review.Jul 11 2022, 7:51 PM
gerritbot added a comment.Jul 11 2022, 7:57 PM

Change 812946 merged by jenkins-bot:

[mediawiki/extensions/FlexDiagrams@master] Replace SkinTemplateNavigation w/ SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/812946

Yaron_Koren mentioned this in rEFLD6bf919177639: Replace SkinTemplateNavigation w/ SkinTemplateNavigation::Universal.Jul 11 2022, 7:58 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 11 2022, 8:30 PM
gerritbot added a comment.Jul 11 2022, 11:01 PM

Change 812947 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/MintyDocs@master] Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/812947

gerritbot added a project: Patch-For-Review.Jul 11 2022, 11:01 PM
gerritbot added a comment.Jul 11 2022, 11:12 PM

Change 812947 merged by jenkins-bot:

[mediawiki/extensions/MintyDocs@master] Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/812947

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2022, 11:30 PM
Yaron_Koren mentioned this in rEMDO38f5e0f98039: Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal.Jul 12 2022, 12:08 AM
Lens0021 updated the task description. (Show Details)Jul 12 2022, 1:03 PM
gerritbot added a comment.Jul 12 2022, 7:45 PM

Change 813300 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/ApprovedRevs@master] Deprecate SkinTemplateNavigation hook in favour of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/813300

gerritbot added a project: Patch-For-Review.Jul 12 2022, 7:45 PM
gerritbot added a comment.Jul 12 2022, 7:48 PM

Change 813301 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/PageSchemas@master] Deprecate SkinTemplateNavigation hook in favour of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/813301

gerritbot added a comment.Jul 12 2022, 7:55 PM

Change 813300 merged by jenkins-bot:

[mediawiki/extensions/ApprovedRevs@master] Deprecate SkinTemplateNavigation hook in favour of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/813300

Lens0021 unsubscribed.Jul 12 2022, 7:56 PM
gerritbot added a comment.Jul 12 2022, 7:58 PM

Change 813301 merged by jenkins-bot:

[mediawiki/extensions/PageSchemas@master] Deprecate SkinTemplateNavigation hook in favour of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/813301

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2022, 8:30 PM
Yaron_Koren updated the task description. (Show Details)Jul 28 2022, 6:29 PM
Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture (Menus 2.0); removed MediaWiki-Core-Skin-Architecture.Aug 15 2022, 10:46 AM
Jdlrobson moved this task from Backlog to Migrate the things on the MediaWiki-Core-Skin-Architecture (Menus 2.0) board.Aug 18 2022, 9:31 PM
Jdlrobson moved this task from Menus 2.0 to Deprecations/removals on the MediaWiki-Core-Skin-Architecture board.Nov 15 2022, 4:51 PM
Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture; removed MediaWiki-Core-Skin-Architecture (Menus 2.0).
Kghbln subscribed.Dec 11 2022, 6:42 PM

The issue for the Purge extension was also reported on GitHub - issue 33.

gerritbot added a comment.Jan 10 2023, 2:01 AM

Change 877292 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):

[mediawiki/extensions/UserProtect@master] Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/877292

gerritbot added a project: Patch-For-Review.Jan 10 2023, 2:01 AM
gerritbot added a comment.Jan 11 2023, 5:45 PM

Change 877292 merged by Jdlrobson:

[mediawiki/extensions/UserProtect@master] Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/877292

Bawolff mentioned this in rEUSP303a22f38a40: Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal.Jan 11 2023, 5:47 PM
gerritbot added a comment.Jan 25 2023, 4:44 PM

Change 883611 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):

[mediawiki/extensions/UserProtect@REL1_39] Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/883611

gerritbot added a comment.Jan 25 2023, 4:47 PM

Change 883611 merged by Brian Wolff:

[mediawiki/extensions/UserProtect@REL1_39] Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/883611

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2023, 5:31 PM
Bawolff mentioned this in rEUSP309e4b9341df: Replace SkinTemplateNavigation with SkinTemplateNavigation::Universal.Jan 25 2023, 5:54 PM
adrelanos subscribed.Jan 30 2023, 10:03 PM
In T312149#8459063, @Kghbln wrote:

The issue for the Purge extension was also reported on GitHub - issue 33.

Opened a pull request. It silences the warning for me.
https://github.com/Hutchy68/Purge/pull/34

Yaron_Koren moved this task from Backlog to Already fixed for AR on the MediaWiki-extensions-Approved-Revs board.Feb 1 2023, 6:42 PM
Jdlrobson added a project: MW-1.40-release.Feb 23 2023, 5:27 PM
Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.40-release board.Mar 2 2023, 1:52 PM
gerritbot added a comment.May 13 2023, 12:10 PM

Change 919436 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Favorites@master] Replace deprecated PersonalUrls and SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919436

gerritbot added a project: Patch-For-Review.May 13 2023, 12:10 PM

Change 919444 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FileAnnotations@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919444

gerritbot added a comment.May 13 2023, 12:14 PM

Change 919445 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CollaborationKit@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919445

gerritbot added a comment.May 13 2023, 12:18 PM

Change 919446 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SafeDelete@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919446

Umherirrender updated the task description. (Show Details)May 13 2023, 12:18 PM
gerritbot added a comment.May 13 2023, 12:23 PM

Change 919447 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/HelpCommons@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919447

gerritbot added a comment.May 13 2023, 12:25 PM

Change 919448 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiLexicalData@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919448

gerritbot added a comment.May 16 2023, 9:13 AM

Change 919445 merged by Jforrester:

[mediawiki/extensions/CollaborationKit@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919445

gerritbot added a comment.May 16 2023, 9:13 AM

Change 919444 merged by Jforrester:

[mediawiki/extensions/FileAnnotations@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919444

gerritbot added a comment.May 16 2023, 9:26 AM

Change 919446 merged by jenkins-bot:

[mediawiki/extensions/SafeDelete@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919446

gerritbot added a comment.May 16 2023, 9:26 AM

Change 919447 merged by jenkins-bot:

[mediawiki/extensions/HelpCommons@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919447

gerritbot added a comment.May 16 2023, 9:26 AM

Change 919448 merged by jenkins-bot:

[mediawiki/extensions/WikiLexicalData@master] Replace deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919448

gerritbot added a comment.May 16 2023, 9:26 AM

Change 919436 merged by jenkins-bot:

[mediawiki/extensions/Favorites@master] Replace deprecated PersonalUrls and SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/919436

Jdlrobson added projects: patch-welcome, good first task, MW-1.41-release.Jun 14 2023, 9:21 PM
Jdlrobson triaged this task as High priority.Jun 14 2023, 9:25 PM
Kghbln added a comment.EditedJun 19 2023, 7:55 AM

The extension Purge was forked an updated in the meantime. The code is at https://github.com/AlPha5130/mediawiki-extensions-Purge/ When searching for SkinTemplateNavigation no result was shown. @Jdlrobson Will be nice if you could do a second check to confirm. However, marking this one as done already.

Created a pull to add it to code search: https://github.com/MWStake/nonwmf-extensions/pull/53

Kghbln updated the task description. (Show Details)Jun 19 2023, 7:56 AM
gerritbot added a comment.Jun 20 2023, 8:47 PM

Change 931688 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/examples@master] Remove deprecated hook

https://gerrit.wikimedia.org/r/931688

Jdlrobson removed projects: MediaWiki-Core-Skin-Architecture, Wikispeech, MediaWiki-extensions-UserProtect, MediaWiki-extensions-PageSchemas, MediaWiki-extensions-MintyDocs, FileAnnotations, MediaWiki-extensions-CollaborationKit, MediaWiki-extensions-Approved-Revs.Jun 20 2023, 9:05 PM

Thanks @Kghbln !

Seems like remaining issues are with Wikifab code (https://github.com/MWStake/nonwmf-skins/issues/14) so I'm re-tagging this accordingly.

Jdlrobson mentioned this in T339969: Remove SkinTemplateNavigation and SkinTemplateNavigation::SpecialPage hooks.Jun 20 2023, 9:07 PM
gerritbot added a comment.Jul 7 2023, 9:06 PM

Change 931688 merged by jenkins-bot:

[mediawiki/extensions/examples@master] Remove deprecated hook

https://gerrit.wikimedia.org/r/931688

Jdlrobson updated the task description. (Show Details)Jul 7 2023, 9:08 PM
Reedy moved this task from Blocker to To deprecate or remove on the MW-1.41-release board.Aug 26 2023, 6:32 PM
Jdforrester-WMF removed projects: MW-1.41-release, Patch-For-Review, MW-1.40-release, MediaWiki-extensions-PdfBook.Sep 21 2023, 6:33 PM
gerritbot added a comment.Jun 5 2024, 12:16 AM

Change #1038829 had a related patch set uploaded (by Bartosz Dziewoński; author: Jdlrobson):

[mediawiki/extensions/examples@REL1_39] Remove deprecated hook

https://gerrit.wikimedia.org/r/1038829

gerritbot added a project: Patch-For-Review.Jun 5 2024, 12:16 AM

Change #1038830 had a related patch set uploaded (by Bartosz Dziewoński; author: Jdlrobson):

[mediawiki/extensions/examples@REL1_40] Remove deprecated hook

https://gerrit.wikimedia.org/r/1038830

gerritbot added a comment.Jun 5 2024, 12:18 AM

Change #1038830 merged by jenkins-bot:

[mediawiki/extensions/examples@REL1_40] Remove deprecated hook

https://gerrit.wikimedia.org/r/1038830

gerritbot added a comment.Jun 5 2024, 12:18 AM

Change #1038829 merged by jenkins-bot:

[mediawiki/extensions/examples@REL1_39] Remove deprecated hook

https://gerrit.wikimedia.org/r/1038829

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits