Structured mentor list should validate the maximum length of a mentor message
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Jul 7 2022, 5:09 PM

Description

The Growth-Team is working on a structured mentor list as part of T264343. One of the goals for this project is to make it easy to validate the mentor list content when a mentor signs up or changes their details (such as, message). It turns out we don't validate the maximum message length in Special:EnrollAsMentor (at least, I didn't check the message change dialog yet).

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:GrowthMentors.json&diff=552390&oldid=552389 is an example of a change that should not be possible.

Ticket origin: @KStoller-WMF's comment at T312102#8058414.

Acceptance criteria

When structured mentor list is enabled, Special:EnrollAsMentor does not let soon-to-be mentors to enter an introduction message that's longer than the prescribed limit (as of today, 240 characters)
When structured mentor list is enabled, mentors are not able to set a longer introduction message than 240 characters via Special:MentorDashboard.

Details

	Subject	Repo	Branch	Lines +/-
	Enforce maximum message length in StructuredMentorWriter	mediawiki/extensions/GrowthExperiments	master	+86 -15

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Urbanecm_WMF	T272376 Make it possible for admin to remove a mentor when they quit/are blocked
Resolved		Urbanecm_WMF	T264343 Have a special page for mentors to sign up
Resolved		Urbanecm_WMF	T312576 Structured mentor list should validate the maximum length of a mentor message
Resolved	BUG REPORT	Urbanecm_WMF	T314691 [betalabs] Mentorship pages issues

Event Timeline

Urbanecm_WMF created this task.Jul 7 2022, 5:09 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 7 2022, 5:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Urbanecm_WMF added a parent task: T264343: Have a special page for mentors to sign up.Jul 7 2022, 5:11 PM

Release blocker for T264343.

Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 7 2022, 5:19 PM

Change 814763 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Enforce maximum message length in StructuredMentorWriter

https://gerrit.wikimedia.org/r/814763

gerritbot added a project: Patch-For-Review.Jul 18 2022, 11:23 AM

Urbanecm_WMF mentioned this in T312575: Add a character counter to Special:EnrollAsMentor.Aug 1 2022, 5:53 PM

Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 2 2022, 9:53 AM

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.Aug 2 2022, 10:13 AM

Change 814763 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Enforce maximum message length in StructuredMentorWriter

https://gerrit.wikimedia.org/r/814763

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2022, 3:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 3 2022, 4:00 AM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 3 2022, 4:06 AM

Etonkovidova added a subtask: T314691: [betalabs] Mentorship pages issues.Aug 5 2022, 10:13 PM

@Urbanecm_WMF - I checked on cswiki betalabs - there is no limit on accepted message's length for "Introduction message" on Special:EnrollAsMentor. Another issue with the entered message is on enwiki betalabs - filed as T314691: [betalabs] Mentorship pages issues.

In T312576#8134813, @Etonkovidova wrote:

@Urbanecm_WMF - I checked on cswiki betalabs - there is no limit on accepted message's length for "Introduction message" on Special:EnrollAsMentor.

Thanks for checking this. I double-checked the behavior, and I didn't manage to enter more than 240 characters (the input textbox for the message stops accepting new characters after reaching the limit). If I change limit in the maxlength="240" HTML attribute to a higher limit, and submit the dialog that way, the following error message appears:

Granted, the fact I reached the limit is not super-clear (typing just stops writing), and a counter would be useful (covered by T312575). If that makes things more clear, we can remove the HTML maxlength attribute and rely on the server-side rejection.

Can you please have another look?

Another issue with the entered message is on enwiki betalabs - filed as T314691: [betalabs] Mentorship pages issues.

Thanks! I'll check that as well.

MShilova_WMF moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Aug 9 2022, 3:25 PM

Urbanecm_WMF removed a project: User-Urbanecm_WMF (Engineering).Aug 11 2022, 10:38 AM

Urbanecm_WMF changed the status of subtask T314691: [betalabs] Mentorship pages issues from Open to In Progress.Aug 11 2022, 11:05 AM

Urbanecm_WMF mentioned this in T314691: [betalabs] Mentorship pages issues.Aug 11 2022, 11:14 AM

Urbanecm_WMF changed the status of subtask T314691: [betalabs] Mentorship pages issues from In Progress to Open.Aug 16 2022, 6:08 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2022, 8:54 PM

In T312576#8137033, @Urbanecm_WMF wrote:

In T312576#8134813, @Etonkovidova wrote:

@Urbanecm_WMF - I checked on cswiki betalabs - there is no limit on accepted message's length for "Introduction message" on Special:EnrollAsMentor.

Thanks for checking this. I double-checked the behavior, and I didn't manage to enter more than 240 characters (the input textbox for the message stops accepting new characters after reaching the limit). If I change limit in the maxlength="240" HTML attribute to a higher limit, and submit the dialog that way, the following error message appears:

Granted, the fact I reached the limit is not super-clear (typing just stops writing), and a counter would be useful (covered by T312575). If that makes things more clear, we can remove the HTML maxlength attribute and rely on the server-side rejection.

Can you please have another look?

I checked cswiki betalabs and testwiki wmf.25 - works as expected: on Special:EnrollAsMentor messages longer than 240 characters cannot be entered and the sufficient warning is presented to users.

Etonkovidova updated the task description. (Show Details)Aug 17 2022, 12:44 AM

Urbanecm_WMF mentioned this in T315399: [testwiki-wmf.25] Special:MentorDashboard - cannot update "Message to your mentees".Aug 17 2022, 10:35 AM

Urbanecm_WMF changed the status of subtask T314691: [betalabs] Mentorship pages issues from Open to In Progress.Aug 29 2022, 7:21 AM

Urbanecm_WMF changed the status of subtask T314691: [betalabs] Mentorship pages issues from In Progress to Open.Sep 17 2022, 1:39 PM

Etonkovidova closed subtask T314691: [betalabs] Mentorship pages issues as Resolved.Oct 19 2022, 12:21 AM

Urbanecm_WMF mentioned this in T359193: Community configuration: Decide whether the schema PHP classes need support for `required`.Mar 25 2024, 9:41 AM

Sgs mentioned this in T360921: Support required properties in schemas.Mar 25 2024, 4:56 PM

	F35407724: image.png
	Aug 8 2022, 11:32 AM

Structured mentor list should validate the maximum length of a mentor messageClosed, ResolvedPublicActions