Page MenuHomePhabricator

[Config Change] Enable Topic Containers as beta feature at partner wikis (desktop)
Closed, ResolvedPublic

Description

This task represents the work with enabling Topic Containers as a feature within the existing Discussion tools Beta Feature.

Deployment Timing

Wednesday 20 July 2022

Deployment wikis

  • ar.wiki
  • cs.wiki
  • hu.wiki

Requirements

  • People who meet the criteria below will see Topic Containers when visiting any Article or User talk pages on desktop:
    • People who have the Discussion tools beta feature enabled
    • People who have the Show discussion activity setting within Special:Preferences#mw-prefsection-editing enabled
    • People accessing ar.wiki, cs.wiki, or hu.wiki using the desktop version of the site

Minimum test case

  1. At the wikis listed in Deployment wikis above, visit Special:Preferences#mw-prefsection-betafeatures
  2. Ensure the Discussion tools Beta Feature is enabled and the Show metadata about each discussion and enable a new page layout. list item appears within it
  3. Visit a User or Article talk page
  4. Verify that all section headings are styled in the way we defined in T310914
  5. Verify that all sections that contain signed comments contain metadata in the way we defined in T310914
  6. Verify that all sections that do NOT contain signed comments do NOT contain any metadata
  7. Verify that the metadata contained within each Topic Container is accurate
  8. Visit a talk page that is NOT in the User or Article talk namespace and verify that Topic Containers do NOT appear. Read: talk page sections should continue being styled as they had before today's deployment.

Done

  • Requirements are implemented and verified as having been implemented

Event Timeline

ppelberg added a project: Goal.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

Change 815359 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable DiscussionTools visualenhancements as beta feature on partner wikis

https://gerrit.wikimedia.org/r/815359

Change 815359 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable DiscussionTools visualenhancements as beta feature on partner wikis

https://gerrit.wikimedia.org/r/815359

Mentioned in SAL (#wikimedia-operations) [2022-07-20T20:11:21Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:815359|Enable DiscussionTools visualenhancements as beta feature on partner wikis (T312670)]] (duration: 03m 10s)

Mentioned in SAL (#wikimedia-operations) [2022-07-20T20:27:30Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:815359|Enable DiscussionTools visualenhancements as beta feature on partner wikis (T312670)]] (duration: 03m 26s)

Testing on ar.wiki
Discussion tools Beta Feature is enabled and the Show metadata about each discussion and enable a new page layout list item appears within it

Screenshot 2022-07-21 at 15.38.13.png (1×2 px, 210 KB)

✅ Verify that all section headings are styled in the way we defined in T310914
✅ Verify that all sections that contain signed comments contain metadata in the way we defined in T310914

Screenshot 2022-07-21 at 15.20.11.png (604×2 px, 104 KB)

Screenshot 2022-07-21 at 15.27.57.png (380×2 px, 65 KB)

Screenshot 2022-07-21 at 15.28.59.png (320×2 px, 55 KB)

✅ Verify that all sections that do NOT contain signed comments do NOT contain any metadata

Screenshot 2022-07-21 at 15.31.55.png (732×2 px, 148 KB)

✅ Verify that the metadata contained within each Topic Container is accurate

Screenshot 2022-07-21 at 15.42.08.png (936×1 px, 154 KB)

✅ Visit a talk page that is NOT in the User or Article talk namespace and verify that Topic Containers do NOT appear.

Screenshot 2022-07-21 at 15.35.34.png (860×1 px, 190 KB)

@matmarex Other Observations:
hu.wiki:

  • hu.wiki does not have Show metadata about each discussion and enable a new page layout explicitly listed under Discussion Tools

I’ve updated the translation yesterday, should be available next week. (If it’s very important, it could in theory be backported, but I’ve never seen translations being backported.)

It’s only Google Translate, nothing’s wrong with DiscussionTools. See wikt:test#Hungarian.

Yes, both of these look as expected to me. Thank you both for checking :)

For a moment I was worried that Google Translate was translating the text that you were writing, which would be bad (at best that just messes up your text, since you're probably not writing in Hungarian while using translation from Hungarian; at worst it might cause the editor to stop working), and which has happened in the past with other translation plugins: T267747: VisualEditor replaces templates with code, adds strange font tags. But it looks like the text you typed was actually saved correctly (see e.g. this diff), and it's just getting translated when shown, which seems normal.