Page MenuHomePhabricator

Ensure Topic Container metadata and section heading styling appear simultaneously
Closed, ResolvedPublic

Description

This task involves the work with ensuring that at the moment people gain access to Topic Containers, they see both talk page == H2 == section headings restyled and metadata about the discussion contained within said sections.

Note: "gain access to Topic Containers" in this context means people enabling the feature themselves in Beta Features or visiting a talk page where Topic Containers have been made available by default

Background

This task is a response to @Whatamidoing-WMF noticing how shortly after the deployment of T312670, the restyled section headings on this hu.wiki user talk page were accompanied by metadata, whereas the restyled section headings on this hu.wiki user talk page were NOT accompanied by metadata.

Requirements

Meta

  • Skins: See T306730
  • Platform(s): Desktop + Mobile

UX

  • The moment someone arrives on a talk page at a wiki where Topic Containers have been enabled, they should see ==H2 == sections styled in the way we defined in TICKET and metadata appearing beneath each of the newly-restyled section headings
    • In this context, "Topic Containers have been enabled" could mean either: A) people enabling the feature themselves in Beta Features or B) visiting a talk page where Topic Containers have been made available by default

Open questions

  • 1. How will we decide when we are confident there are no major issues with Topic Containers that would cause us to delay silently turning them on on all wikis, but without people being able to enable the feature?

Approaches

  • Approach #1: Silently turn on the feature now on all wikis, but without the ability for people to enable it
    • Considerations
      • This approach will take 10 days to take full effect
  • Approach #2: Avoid applying the CSS if we detect the HTML hasn't been updated yet

Done

  • Answers to all Open questions are documented
  • Requirements are implemented

Event Timeline

(Adding Approaches @Esanders shared in Slack (private))

Esanders updated the task description. (Show Details)

Change 817819 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Add topic containers HTML to parser cache even when feature is disabled

https://gerrit.wikimedia.org/r/817819

Change 817819 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add topic containers HTML to parser cache even when feature is disabled

https://gerrit.wikimedia.org/r/817819

Testing

This will ride the train next week, so on each day of the train (Group 0/1/2 Tue/Wed/Thu) we should do some sanity checking on a few wikis in each group, where we look at the main page and some random talk pages.

On each page you test you should append ?action=purge to ensure you get the new HTML.