Page MenuHomePhabricator
Create Task
Maniphest T314230

Adding a wikilink in basic reference shows overlay error
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Click "Cite"
  • Click "Manual"
  • Click "Basic"
  • Type some text
  • Mark some text
  • Click the link icon (or Strg K)

What happens?:

Input field more or less unreachable due to an error in the overlay

basic ref overlay.JPG (468×592 px, 56 KB)

What should have happened instead?:

Input field and drop down menu should be shown normally

Other information (browser name/version, screenshots, etc.):
Firefox 103.0 on Windows 8.1 and Firefox 102.0.1 on MacOS

Details

SubjectRepoBranchLines +/-
ve.ui.MWTargetWidget: Suppress the stacking context established by .vector-bodymediawiki/extensions/VisualEditormaster+21 -0
Revert "Add 'vector-body' hack to TargetWidgets"mediawiki/extensions/VisualEditormaster+1 -8
Customize query in gerrit

Related Objects

Event Timeline

Raymond created this task.Jul 30 2022, 5:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2022, 5:57 PM
Maintenance_bot added a project: VisualEditor.Jul 30 2022, 6:29 PM
matmarex added subscribers: Esanders, matmarex.Aug 1 2022, 2:32 PM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/814804

Raymond added a project: Regression.Aug 1 2022, 5:29 PM
matmarex merged a task: T314685: The "alternative text" field overlaps the wikilink search when inserting an illustration/gallery.Aug 8 2022, 10:10 PM
matmarex added subscribers: AramilFeraxa, Urbanecm, Jcubic.
gerritbot added a comment.Aug 8 2022, 10:11 PM

Change 821333 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Revert "Add 'vector-body' hack to TargetWidgets"

https://gerrit.wikimedia.org/r/821333

gerritbot added a project: Patch-For-Review.Aug 8 2022, 10:11 PM
matmarex claimed this task.Aug 8 2022, 10:12 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex mentioned this in T313221: Line height too low on VE target widgets.
gerritbot added a comment.Aug 10 2022, 11:48 PM

Change 822188 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] ve.ui.MWTargetWidget: Suppress the stacking context established by .vector-body

https://gerrit.wikimedia.org/r/822188

gerritbot added a comment.Aug 10 2022, 11:48 PM

Change 821333 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/VisualEditor@master] Revert "Add 'vector-body' hack to TargetWidgets"

Reason:

Alternative patch: https://gerrit.wikimedia.org/r/822188

https://gerrit.wikimedia.org/r/821333

gerritbot added a comment.Aug 11 2022, 1:41 PM

Change 822188 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ve.ui.MWTargetWidget: Suppress the stacking context established by .vector-body

https://gerrit.wikimedia.org/r/822188

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 11 2022, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 11 2022, 2:30 PM
Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Aug 11 2022, 2:39 PM
Esanders added a project: Editing QA.
Reedy mentioned this in T314730: Broken popup in add new link inside edit footnote edit in Visual Editor.Aug 12 2022, 5:08 PM
EAkinloose edited projects, added Verified; removed Editing QA.Aug 17 2022, 9:45 AM
EAkinloose subscribed.

✅ Adding a wikilink in basic reference should not show an overlay error

Screenshot 2022-08-17 at 10.45.09.png (934×1 px, 164 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 17 2022, 9:46 AM
• ppelberg closed this task as Resolved.Aug 18 2022, 12:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL