Page MenuHomePhabricator

[Visual refinements] Decrease height of sticky header
Open, LowPublic3 Estimated Story Points

Description

Description

The sticky header is a bit taller than it should be, mainly due to the oversized icon-buttons within it.

Blockers

To-do

  • Decrease font-size of .vector-sticky-header-context-bar-primary from 24px to 22px
  • Decrease top & bottom padding of .vector-sticky-header from 6px to 2px
  • Decrease height of .vector-sticky-header from 50px to 40px
  • Update mw-sticky-header-element to account for new sticky header height

Designs

Prototype: https://di-collapsible-menus.web.app/Moss

beforeafter
Screen Shot 2022-08-01 at 2.33.02 PM.png (984×1 px, 589 KB)
Screen Shot 2022-08-01 at 2.33.10 PM.png (984×1 px, 589 KB)

Event Timeline

ovasileva triaged this task as Medium priority.Aug 4 2022, 9:16 AM
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.
ovasileva added a subscriber: Mabualruz.

class mw-sticky-header-element might need to be adjusted to accommodate the new size

ovasileva set the point value for this task to 3.Aug 23 2022, 5:37 PM

Not a blocker for deployment, moving to backlog for time being

Jdrewniak lowered the priority of this task from Medium to Low.Mon, May 27, 6:22 PM
Jdrewniak moved this task from Incoming to Groomed on the Web-Team-Backlog board.

Just adding that we should stick to Codex size values for these changes, but these changes seem small and non-controversial.

Jdlrobson added a subscriber: Jdrewniak.

Justin, does this change still make sense?