Page MenuHomePhabricator
Create Task
Maniphest T315620

Going to an #Anchor link, viewport jumps back to top of page (all wikis, all skins)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Scroll jumps to correct section, then jumps back to top

What should have happened instead?:

  • Scroll jumps to correct section and stays

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Tested on vector, vector-2022, monobook, Timeless, Cologne Blue, Minerva (web), Modern

Details

SubjectRepoBranchLines +/-
Revert "Set initial-zoom via JavaScript to avoid font-scaling issue in iPad"mediawiki/coremaster+2 -25
Customize query in gerrit

Related Objects
Search...

Event Timeline

Novem_Linguae created this task.Aug 18 2022, 9:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2022, 9:53 PM
Frostly updated the task description. (Show Details)Aug 18 2022, 9:57 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptAug 18 2022, 9:57 PM
Sideswipe9th added a comment.Aug 18 2022, 10:01 PM

From my own testing using Firefox 103.0.2, Chrome 104.0.5112.102, and Edge 104.0.1293.54 on Windows 10, it appears as though the page is initially loading and locating correctly to the anchor link, and then once page load completes the browser jumps back to the top of the page.

Frostly added a comment.Aug 18 2022, 10:02 PM

Same experience.

Pppery subscribed.Aug 18 2022, 10:02 PM
Novem_Linguae updated the task description. (Show Details)Aug 18 2022, 10:02 PM
NightWolf1223 subscribed.Aug 18 2022, 10:05 PM
Novem_Linguae added a project: MediaWiki-User-Interface.Aug 18 2022, 10:05 PM
Sideswipe9th added a comment.EditedAug 18 2022, 10:08 PM

Did some more testing, seems to be JavaScript related, as disabling all scripts via NoScript results in the expected behaviour. Unfortunately I can't dig any deeper to find a culprit script, as I've not done any webdev in a hot minute and my skills are a bit rusty. However as it seems to be occurring in safemode, it suggests that its one of the scripts that come from MediaWiki core and not a userscript.

Reedy triaged this task as Unbreak Now! priority.Aug 18 2022, 10:19 PM
Reedy added a parent task: T314186: 1.39.0-wmf.25 deployment blockers.
Aklapper renamed this task from #Anchors in links appear to be broken on all wikis, all skins to Going to an #Anchor link, viewport jumps back to top of page (all wikis, all skins).Aug 18 2022, 10:23 PM
Aklapper lowered the priority of this task from Unbreak Now! to Needs Triage.
Aklapper triaged this task as Unbreak Now! priority.
Aklapper added a project: Regression.
Stashbot added a comment.Aug 18 2022, 10:25 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-18T22:25:44Z] <dancy> Rolling the train back to group1 due to T315620

Legoktm subscribed.EditedAug 18 2022, 10:27 PM

e794fdd90eb9fb62d7d47a6d8e016e59dbbccff4 (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/822328) seems suspicious, especially the window.scrollTo( 0, 0 ); line. It was backported an hour-ish ago: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/824433

Iniquity awarded a token.Aug 18 2022, 10:28 PM
Iniquity subscribed.
dancy subscribed.Aug 18 2022, 10:36 PM

Thanks @Legoktm I'm going to revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/824433

Novem_Linguae mentioned this in T311795: [Bug] Safari doesn't allow font-size scaling on iPad for users viewing legacy and modern Vector.Aug 18 2022, 10:37 PM
Agusbou2015 subscribed.Aug 18 2022, 10:52 PM
Iniquity added a comment.Aug 18 2022, 11:01 PM

I think it is also affect on this one T315597#8167039.

Jdforrester-WMF subscribed.Aug 18 2022, 11:14 PM

Reverted in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/824573 but this task wasn't tagged.

TheresNoTime subscribed.Aug 19 2022, 12:21 AM
Novem_Linguae added a comment.Aug 19 2022, 1:54 AM

The issue appears to be fixed in production.

Was the fix https://gerrit.wikimedia.org/r/c/mediawiki/core/+/824573 or something else?

If the fix was 824573, we may want to revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/822328/. We've only reverted the backport so far I think. Reverting 822328 would take care of reverting the master branch.

gerritbot added a comment.Aug 19 2022, 2:58 AM

Change 824435 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] Revert "Set initial-zoom via JavaScript to avoid font-scaling issue in iPad"

https://gerrit.wikimedia.org/r/824435

gerritbot added a project: Patch-For-Review.Aug 19 2022, 2:58 AM
gerritbot added a comment.Aug 19 2022, 3:18 AM

Change 824435 merged by jenkins-bot:

[mediawiki/core@master] Revert "Set initial-zoom via JavaScript to avoid font-scaling issue in iPad"

https://gerrit.wikimedia.org/r/824435

Legoktm closed this task as Resolved.Aug 19 2022, 3:23 AM
Legoktm claimed this task.

Reverted out of master now too. Thanks @dancy for fixing production. Presumably future discussion of this issue can take place on the original task, T311795: [Bug] Safari doesn't allow font-size scaling on iPad for users viewing legacy and modern Vector.

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2022, 3:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 19 2022, 4:00 AM
Pppery unsubscribed.Aug 19 2022, 4:07 AM
gerritbot added a comment.Aug 22 2022, 7:31 AM

Change 824437 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Set initial-zoom via JavaScript to avoid font-scaling issue in iPad (take 2)

https://gerrit.wikimedia.org/r/824437

gerritbot added a project: Patch-For-Review.Aug 22 2022, 7:31 AM
PatchDemoBot added a comment.Aug 22 2022, 7:33 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/3778e08640/w

PatchDemoBot added a comment.Feb 3 2023, 3:41 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/3778e08640/w/

dancy unsubscribed.Feb 3 2023, 3:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL