Update, tag and release makizushi 4.0.0
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

None

Authored By

	WMDE-Fisch
	Aug 24 2022, 11:26 AM

Description

Should be done as new package @wikimedia/makizushi. Includes updating Maps (Kartotherian) to use the new version.

Note: We probably want to wait for T315226: Handle missing or invalid marker icons to be resolved. At least as an MVP version.

Details

	Subject	Repo	Branch	Lines +/-
	Use @wikimedia/makizushi version 4.0.0	mediawiki/services/kartotherian	master	+407 -538

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T153369 Static maps service crashes on broken images (used in icons)
Resolved	awight	T141304 Only a part of MAKI symbols is available (previously map icon "castle" broken)
Stalled	None	T141335 Add maps support for marks with 3 digits
Resolved	awight	T145475 Update to latest maki
Resolved	None	T302861 Actually update the Maki icons
Resolved	awight	T316779 Deploy updated Maki icons to production
Resolved	None	T315646 Deploy new Maki icons to the beta cluster
Resolved	None	T316106 Update, tag and release makizushi 4.0.0

Event Timeline

WMDE-Fisch created this task.Aug 24 2022, 11:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2022, 11:26 AM

WMDE-Fisch set the point value for this task to 2.Aug 24 2022, 11:27 AM

WMDE-Fisch updated the task description. (Show Details)Aug 24 2022, 11:53 AM

Is this correct? https://www.npmjs.com/package/@wikimedia/makizushi

Change 826499 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/services/kartotherian@master] Use @wikimedia/makizushi version 4.0.0

https://gerrit.wikimedia.org/r/826499

gerritbot added a project: Patch-For-Review.Aug 25 2022, 8:25 AM

In T316106#8184116, @thiemowmde wrote:

Is this correct? https://www.npmjs.com/package/@wikimedia/makizushi

Looks right. I'll try to validate. :-D

I also just changed the repo settings to require 2FA.

The new package downloads correctly for me. However, @kartotherian/geojson-mapnikify still depends on the old version @kartotherian/makizushi so we may want to update that dependency as well.

In T316106#8184203, @awight wrote:

The new package downloads correctly for me. However, @kartotherian/geojson-mapnikify still depends on the old version @kartotherian/makizushi so we may want to update that dependency as well.

Same, downloads correctly, but it's not working yet. So I guess this is related to the geojson-mapnikify dependency.

WMDE-Fisch moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Aug 25 2022, 11:09 AM

Change 826499 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Use @wikimedia/makizushi version 4.0.0

https://gerrit.wikimedia.org/r/826499

WMDE-Fisch mentioned this in rMSKAe3f385480492: Use @wikimedia/makizushi version 4.0.0.Aug 26 2022, 1:02 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2022, 1:30 PM

WMDE-Fisch closed this task as Resolved.Aug 30 2022, 8:44 AM