Here are the new numeric markers--at the moment, I haven't replicated the feature where the font size is decreased for two-digit numbers:

@awight It looks like you created a new implementation for numbers and letters. Does this open up the option of 3-digit numbers too?

In T302861#8161900, @ECohen_WMDE wrote:

Here are the new numeric markers--at the moment, I haven't replicated the feature where the font size is decreased for two-digit numbers:

@awight It looks like you created a new implementation for numbers and letters. Does this open up the option of 3-digit numbers too?

It would be possible with the current technique, but probably inadvisable. Each extra digit will take an order of magnitude more disk and memory because we're pre-rendering every possible number. It would be possible to go up to 199 with only 2x the storage, maybe that's good enough for now?

There's also a more radical approach we could look into, of dynamically rendering. But let's keep that discussion on a separate ticket perhaps.

It would be possible with the current technique, but probably inadvisable. Each extra digit will take an order of magnitude more disk and memory because we're pre-rendering every possible number. It would be possible to go up to 199 with only 2x the storage, maybe that's good enough for now?

Even increasing to 199 would be a big improvement. This was a very requested feature and if we are able to do it, I think that would be great.

There's also a more radical approach we could look into, of dynamically rendering. But let's keep that discussion on a separate ticket perhaps.

Maybe a good topic for story time?

@ECohen_WMDE Thiemo found something important during review, that Maki has dropped the outlines on symbol icons, so we should consider doing the same for the alphanumeric markers we're generating in our code. Here's what that would look like:

(Also note that all of these outline-less icons become hard to see on light-colored pin backgrounds.)

Examples of the outline-less markers with light backgrounds:

Perhaps we should flip the color scheme when using a light background? The PNG is actually a black numeral, so the current renderer is "xor"-ing or inverting the icon. We could flip to additive rendering when the color is light. For example:

We've included a bit of code that flips color when a relative luminance of 0.5 is crossed, using this WCAG formula: https://www.w3.org/TR/WCAG20/#relativeluminancedef

L = 0.2126 * R + 0.7152 * G + 0.0722 * B

Resulting icons look like:

Update: I've combined the WCAG recommendations for color contrast and corrected the relative luminance formula. This gives a threshold of about L=0.179 for a contrast ratio of 4.5:1 against both black and white. Here are icons around the threshold, using the updated software thresholds to decide which symbol color to use:

@awight Thanks for all the notes! I think dropping outlines is a an improvement for readability, especially at small sizes (for both icons and letters/numbers). So that seems great, and it seems like you have come up with a solid solution to deal with the primary downside.

Update: I've combined the WCAG recommendations for color contrast and corrected the relative luminance formula. This gives a threshold of about L=0.179 for a contrast ratio of 4.5:1 against both black and white. Here are icons around the threshold, using the updated software thresholds to decide which symbol color to use:

In this example are you showing icons with almost the exact same color but slightly different to essentially demonstrate the "break point" of switching from black to white?

My only comment is that instead of black, we should use a dark grey. Maybe then the calculation has to be adjusted (or maybe this will happen automatically?). Can you use Base10 (#202122) instead of black for the dark icon version? Also for the dark letters and numbers.

In T302861#8172742, @ECohen_WMDE wrote:

In this example are you showing icons with almost the exact same color but slightly different to essentially demonstrate the "break point" of switching from black to white?

Yes, sorry I forgot to explain what these murky snapshots were all about ;-)

My only comment is that instead of black, we should use a dark grey. Maybe then the calculation has to be adjusted (or maybe this will happen automatically?). Can you use Base10 (#202122) instead of black for the dark icon version? Also for the dark letters and numbers.

Sure, lemme try this. Yes and good point that the threshold would have to be adjusted! Actually, making that automatic feels like a big maintenance improvement since the next time I look at this code to adjust colors I'll have forgotten everything I learned last week...

Yes, sorry I forgot to explain what these murky snapshots were all about ;-)

Ok cool, thanks for the confirmation. Based on eye alone it seems like it might be switching to black too soon. But I'll also trust your contrast calculations if this is technically the right place for the switch to happen.

Sure, lemme try this. Yes and good point that the threshold would have to be adjusted! Actually, making that automatic feels like a big maintenance improvement since the next time I look at this code to adjust colors I'll have forgotten everything I learned last week...

Great thanks!

For reference: I wrote a little demo to play around with possible black vs. white thresholds. The numbers in the image are the contrast ratios according to WCAG. Higher numbers = better. When we use Wikimedia base10 as the dark icon color instead of pure black I ended with 0.25 as the best threshold in my experiments. This favors white icons a little more while still being as close as possible to the curve where the numbers left and right of the black vs. white curve are close to 4.5, which is what's required to pass AA.

<style>
body {
	background: #000;
	color: #fff;
	font-family: sans-serif;
	font-size: 12px;
}
.grid {
	border-collapse: collapse
}
.grid td {
	font-size: 12px;
	height: 40px;
	text-align: center;
	vertical-align: middle;
	margin: 0;
	padding: 0 0.5em;
}
</style>

<table class="grid"></table>
<p>Ramps: <span>…</span></p>

<script>

function luminanceFrom8BitRgb( r8Bit, g8Bit, b8Bit ) {
	var R = luminanceValueFrom8BitRgb( r8Bit ),
		G = luminanceValueFrom8BitRgb( g8Bit ),
		B = luminanceValueFrom8BitRgb( b8Bit );
	return 0.2126 * R + 0.7152 * G + 0.0722 * B;
}

function luminanceValueFrom8BitRgb( value8Bit ) {
	var valueSrgb = value8Bit / 255;
	return valueSrgb <= 0.03928 ?
		valueSrgb / 12.92 :
		Math.pow( ( valueSrgb + 0.055 ) / 1.055, 2.4 );
}

var colorRamps = [
	0,
	0,
	0,
	0,
	0,
	127,
	255
];
var numberOfRamps = colorRamps.length,
	rChannelRamp = ( Math.random() * numberOfRamps ) | 0,
	gChannelRamp = ( Math.random() * numberOfRamps ) | 0,
	bChannelRamp = ( Math.random() * numberOfRamps ) | 0;
document.getElementsByTagName( 'span' )[0].firstChild.data = rChannelRamp + ', ' + gChannelRamp + ', ' + bChannelRamp;
// rChannelRamp = 5; gChannelRamp = 1; bChannelRamp = 2;

var table = document.getElementsByClassName( 'grid' )[0];
var step = 16;

for ( var x = 0; x < 256; x += step ) {
	var tr = document.createElement( 'tr' );
	for ( var y = 0; y < 256; y += step ) {
		colorRamps[0] = x;
		colorRamps[1] = y;
		colorRamps[2] = 255 - x;
		colorRamps[3] = 255 - y;
		var r = colorRamps[rChannelRamp],
			g = colorRamps[gChannelRamp],
			b = colorRamps[bChannelRamp];

		var backgroundLuminance = luminanceFrom8BitRgb( r, g, b );
		var threshold = 0.25;
		var useDarkIcons = backgroundLuminance > threshold;

		// @wmui-color-base10: #202122;
		var iconLuminance = luminanceFrom8BitRgb(
			parseInt( useDarkIcons ? '20' : 'ff', 16 ),
			parseInt( useDarkIcons ? '21' : 'ff', 16 ),
			parseInt( useDarkIcons ? '22' : 'ff', 16 )
		);
		var wcagContrastRatio = useDarkIcons ?
			( ( backgroundLuminance + 0.05 ) / ( iconLuminance + 0.05 ) ) :
			( ( iconLuminance + 0.05 ) / ( backgroundLuminance + 0.05 ) );

		var td = document.createElement( 'td' );
		td.style.backgroundColor = 'rgb( ' + r + ', ' + g + ', ' + b + ' )';
		td.style.color = useDarkIcons ? '#222' : '#fff';
		td.append( document.createTextNode( wcagContrastRatio.toFixed( 2 ) ) );
		tr.append( td );
	}
	table.append( tr );
}

</script>

@ECohen_WMDE Here are some pins with Base10 as the dark symbol color. The backgrounds cross the break point, 7e7e7e and 7f7f7f.

In T302861#8173398, @thiemowmde wrote:

When we use Wikimedia base10 as the dark icon color instead of pure black I ended with 0.25 as the best threshold in my experiments.

I don't have a preference about whether we use the theoretically "correct" threshold or one that looks better on our screens. FWIW, I did run the resulting colors through online contrast checkers and they report that the calculated threshold gives equal contrasts against the light and dark background.

With Base10 as the dark color, the calculated threshold is L = 0.211

With my experimental approach I can confirm 0.211 is also a great threshold. My suggestion to go up to 0.25 is because of what @ECohen_WMDE wrote: "it seems like it might be switching to black too soon". Personally I agree with that.

My suggestion to go up to 0.25 is because of what @ECohen_WMDE wrote: "it seems like it might be switching to black too soon". Personally I agree with that.

Yes this sounds great. With the updated screen shots I still think it should stay white for a bit longer.

Thanks for all the investigation and explanation!

In T302861#8176869, @ECohen_WMDE wrote:

My suggestion to go up to 0.25 is because of what @ECohen_WMDE wrote: "it seems like it might be switching to black too soon". Personally I agree with that.

Yes this sounds great. With the updated screen shots I still think it should stay white for a bit longer.

This would be fine with me, of course! I agree that the white symbol would probably be better at the break point, on my specific screen. That makes the achromatic break point roughly #898989, giving a calculated contrast of 3.5 vs. white, and 6 vs. black, so in theory the white symbol will fail the WCAG guideline of a minimum contrast of 4.5. It looks slightly better to my simple eye, but at the same time it's a very subtle change. We could also consider more extreme approaches such as tweaking the alpha mask so that the marker background fades towards the center.

Here are renders around the breakpoint, at #898989 and #8a8a8a

I'm seeing very different results if we use the ACPA formula (online calculator). Encouragingly, this argues that WCAG far overestimates black contrast and points towards moving our break point to a much lighter color. I'll check where the balance point is using these numbers.

It was difficult to solve the APCA equation theoretically so I found the balance point just by playing with the online calculator. It's around #a7a7a7 or a relative luminance of 0.386 . Icons to either side look like this, with backgrounds of #a7a7a7 and #a6a6a6. Looks quite good to me!

We noticed some small variations between the different outputs we've created. The source of the variation is that the Maki 7.1 release doesn't correspond to a git tag (should have been v7.1.0), so we've used slightly different versions of the source for these various tasks. We think the 7.1 release matches commit ed764be51d9f70c51c69b650fcfd93d48f671037 .

Here's how files correspond to specific versions of Maki:

• List of Maki 7 icon names, for example in Lua module -> Maki v7.2
• SVG images we uploaded to Commons -> Maki v7.1
• makizushi package.json -> Maki v7.1
• PNG renders commited into makizushi -> Maki v7.2

We'll discuss the best way to align all versions, either downgrading the PNGs or upgrading the other two outputs.

@awight, I think this is not correct: "List of Maki 7 icon names → 7.1". The list I see in https://www.mediawiki.org/wiki/Module:Maki_icon_overview is from Maki 7.2, as proven by the new icons, e.g. tunnel.

In T302861#8198369, @thiemowmde wrote:

The list I see in https://www.mediawiki.org/wiki/Module:Maki_icon_overview is from Maki 7.2, as proven by the new icons, e.g. tunnel.

Thanks, you're right--I've edited the comment above.

@awight Is there a test page to see the new markers, numbers and letters live on beta - in addition to the images in the task description? I'd like to review the sizing and placement of the icons.

Currently it looks like the letters and numbers still have outlines. Can these be removed to match the icons?

We noticed and removed the outlines already. Here is a live example: https://maps-beta.wmflabs.org/v4/marker/pin-m-29+0a0@2x.png.

We noticed and removed the outlines already. Here is a live example: https://maps-beta.wmflabs.org/v4/marker/pin-m-29+0a0@2x.png.

Glad to hear that.

I'd still like to see all of them at once. Is there a page where this is already possible? Maybe the ones used to generate all those screenshots?

In T302861#8202175, @ECohen_WMDE wrote:

I'd still like to see all of them at once. Is there a page where this is already possible? Maybe the ones used to generate all those screenshots?

Here's a quick one to start with: https://de.wikipedia.beta.wmflabs.org/wiki/Hilfe:Extension:Kartographer/Icons/Alphanumeric

We found that snapshots included a mix of Maki 0.5 and 7.2 icons, and after some digging discovered that geojson-mapnikify keeps its own cache of markers, in node's os.tmpdir()/geojson-mapnikify-<md5>.png. In order to refresh the snapshot icons, it's necessary to shut down the server, remove these files, and restart.

In T302861#8168121, @awight wrote:

Thiemo found /.../ Maki has dropped the outlines on symbol icons

https://labs.mapbox.com/maki-icons/editor/ suggests that outline (stroke) is just optional and it can be added.

I notice that due to colour flip, which as I understand is a workaround to missing outlines, icons have turned black in some Wikipedia articles. I'd assume in these articles users had chosen pin colours on which light icon generally looked fine before, whereas thick black icons may add unneeded contrast to light-coloured map as a whole. Different colours on maps also generally convey different meanings, as outlined in map legend. If different pin colours are used for different types of features then now there may be different icon colours as well (e.g. see last example here), and if user wants to harmonize icon colours then it's difficult to do so as it's difficult to hit colour flip boundaries.

Maybe you can consider restoring icon outlines after all, as an alternative to colour flip? I think these outlines generally made sense for our use case where any pin/background colour is allowed.

In T302861#8267781, @Pikne wrote:

https://labs.mapbox.com/maki-icons/editor/ suggests that outline (stroke) is just optional and it can be added.

...

Maybe you can consider restoring icon outlines after all, as an alternative to colour flip? I think these outlines generally made sense for our use case where any pin/background colour is allowed.

Thank you for finding this helpful detail! Dropping the outline was accidental from our perspective, so I think everyone is still open to restoring it. I've put the question on my team's TODO list and we'll get back to you shortly.

@Pikne: The Technical Wishes team talked about this proposal to restore icon outlines, and we identified two obstacles. The biggest issue is that the light-colored icon on a light background is less visually accessible even with the outline, and so the software should discourage or avoid this combination. The other is that quick experiments show that the outline seems to damage the icon readability. The outer stroke isn't carefully designed into the icons, it's just an effect applied to existing graphics. Comparing with and without the outline (in the maki icon editor, which renders slightly differently than our maps service):

The shapes with an outline are smaller and harder to discern against a dark background.

Your concern about the choice of black vs white icons apparently carrying information is certainly valid, but maybe you can post some examples here if you come across them. Happy to look at it again!