As mentioned in T141304#2876711 when using an invalid marker type (one not in our supported set of icons or a typo) the static map service will not generate an image. It crashes. :) :(
Perhaps we should validate them?
Here's screenshots....
CKoerner_WMF | |
Dec 15 2016, 10:16 PM |
F5063236: bad-icon-name_broken-dynamic-map.png | |
Dec 15 2016, 10:23 PM |
F5063233: bad-icon-name_doesnt_show_static_map.png | |
Dec 15 2016, 10:23 PM |
As mentioned in T141304#2876711 when using an invalid marker type (one not in our supported set of icons or a typo) the static map service will not generate an image. It crashes. :) :(
Perhaps we should validate them?
Here's screenshots....
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Duplicate | None | T153369 Static maps service crashes on broken images (used in icons) | |||
Resolved | awight | T141304 Only a part of MAKI symbols is available (previously map icon "castle" broken) | |||
Resolved | awight | T145475 Update to latest maki | |||
Resolved | None | T302861 Actually update the Maki icons | |||
Resolved | thiemowmde | T300040 Investigation: update Maki icons | |||
Resolved | None | T312752 Update mw:Help:Extension:Kartographer/Icons with maki 7.0.0 | |||
Resolved | None | T315228 Upload new Maki icons to Wikimedia Commons | |||
Resolved | None | T315226 Handle missing or invalid marker icons | |||
Resolved | WMDE-Fisch | T315638 Maki symbol icons could be cached | |||
Resolved | awight | T316779 Deploy updated Maki icons to production | |||
Resolved | None | T315646 Deploy new Maki icons to the beta cluster | |||
Resolved | None | T316106 Update, tag and release makizushi 4.0.0 | |||
Invalid | None | T317622 429 Too Many Requests when first expanding icon help map | |||
Resolved | Pnorman | T187963 Investigate T141304 and, at minimum, document issue |
Example:
https://www.mediawiki.org/w/index.php?title=User:CKoerner_(WMF)/sandbox&oldid=2313964
The first map preview works as intended (rocket). The second (castle) does not display an image.
We could hardcode the list of all available markers in php, and update it when maki package changes. The list so far: this regex: /^(-number.*|-letter.*|\d\d?|[a-z])$/, or one of these constants:
aerialway, airfield, airport, alcohol-shop, america-football, art-gallery, bakery, bank, bar, baseball, basketball, beer, bicycle, building, bus, cafe, camera, campsite, car, cemetery, chemist, cinema, circle, circle-stroked, city, clothing-store, college, commercial, cricket, cross, dam, danger, dentist, disability, dog-park, embassy, emergency-telephone, entrance, farm, fast-food, ferry, fire-station, fuel, garden, gift, golf, grocery, hairdresser, harbor, heart, heliport, hospital, ice-cream, industrial, land-use, laundry, library, lighthouse, lodging, logging, london-underground, marker, marker-stroked, minefield, mobilephone, monument, museum, music, oil-well, park, park2, parking, parking-garage, pharmacy, pitch, place-of-worship, playground, police, polling-place, post, prison, rail, rail-above, rail-light, rail-metro, rail-underground, religious-christian, religious-jewish, religious-muslim, restaurant, roadblock, rocket, school, scooter, shop, skiing, slaughterhouse, soccer, square, square-stroked, star, star-stroked, suitcase, swimming, telephone, tennis, theatre, toilets, town, town-hall, triangle, triangle-stroked, village, warehouse, waste-basket, water, wetland, zoo
Moving off the sprint board - the Discovery team won't be able to finish this work at this time.