Page MenuHomePhabricator

Impact module: Create mobile summary view
Closed, ResolvedPublic

Description

Description

Included are some changes to the Mobile preview of the impact module:

  • Mobile preview will be updated with a new header label to indicate the specified recent activity and pageview timeperiod.
  • Total cumulative pageviews count displayed updated per mock.
  • New cumulative pageview trendchart that takes the full width of the card. Visual design TBC but will be the same style as the spark line chart. NOTE: This chart can be re-used as a new part of the impact module.
  • New recent activity scorecards in a two-column layout will be shown here. NOTE: This content block can be re-used as a new part of the impact module.
  • Total recent edits count will be moved into the first “recent activity stats” section.

image.png (444×1 px, 56 KB)

Figma Design

Acceptance Criteria

  1. When visiting Special:Homepage on mobile, should be able to see the redesigned summary view
Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

I think that screenshot is representative of the current design, but that is a link to the older Figma design I believe. @KieranMcCann - can you confirm which link is correct? Thank you!

@KieranMcCann Do we need to make a slight adjustment to how this mobile summary view looks now that we changed how we display Last editing and Best streak data? Will we use the new "card" style in the mobile summary as well?

Screen Shot 2022-10-14 at 9.36.18 AM.png (110×580 px, 23 KB)

@KStoller-WMF I noticed this last week and had considered updating the design to the new summary style but decided against it as it would likely involve the copy being truncated. I think the current design with the simple text styling works better as a summary view personally, so happy to go with the current design for this.

Any thoughts @RHo?

@KStoller-WMF I noticed this last week and had considered updating the design to the new summary style but decided against it as it would likely involve the copy being truncated. I think the current design with the simple text styling works better as a summary view personally, so happy to go with the current design for this.

Any thoughts @RHo?

Thanks for the ping! Agree that keeping current design with no background colour is better for the mobile summary.

Sgs changed the task status from Open to In Progress.Oct 18 2022, 4:46 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 835617 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: add pageviews chart to the mobile summary

https://gerrit.wikimedia.org/r/835617

@RHo @KStoller-WMF sorry, I am a bit lost in Figma. The patch that @Sgs wrote implements this display:

image.png (1×830 px, 125 KB)

which does not match the mockup here (probably outdated) nor in the Figma link which seems to just show article view trends, but not the other score cards?

Could you please clarify if what Sergio's implemented here is correct?

@RHo @KStoller-WMF sorry, I am a bit lost in Figma. The patch that @Sgs wrote implements this display:

image.png (1×830 px, 125 KB)

which does not match the mockup here (probably outdated) nor in the Figma link which seems to just show article view trends, but not the other score cards?

Could you please clarify if what Sergio's implemented here is correct?

Hi @kostajh - apologies I think there was a bit of post review updates that did not make Phab. I've updated with the latest mock from Kieran and content-wise it looks right.

Change 835617 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: add pageviews chart to the mobile summary

https://gerrit.wikimedia.org/r/835617

Sgs changed the task status from In Progress to Open.Nov 7 2022, 9:58 AM
Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 853940 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: create separate layouts for each view of the module

https://gerrit.wikimedia.org/r/853940

Change 853940 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: create separate layouts for each view of the module

https://gerrit.wikimedia.org/r/853940

Etonkovidova subscribed.

@RHo @KStoller-WMF sorry, I am a bit lost in Figma. The patch that @Sgs wrote implements this display:

image.png (1×830 px, 125 KB)

which does not match the mockup here (probably outdated) nor in the Figma link which seems to just show article view trends, but not the other score cards?

Could you please clarify if what Sergio's implemented here is correct?

Hi @kostajh - apologies I think there was a bit of post review updates that did not make Phab. I've updated with the latest mock from Kieran and content-wise it looks right.

Based on the above, closing as Resolved after verifying in beta cluster and production testwiki (wmf.13):

Screen Shot 2022-12-09 at 5.10.58 PM.png (468×688 px, 43 KB)