Maniphest T320448

Consider adding Translations and Uploaded media icons to the sticky header
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

Authored By

	Patafisik
	Oct 10 2022, 8:11 PM

Description

Steps to replicate the issue (include links if applicable):

enable Vector 2022
go to a page on en.wiki and open the User menu
look at the "Translations" and "Uploaded media" icons
then scroll down and open the User menu in the sticky header

What happens?:

"Translations" and "Uploaded media" have no icons

What should have happened instead?:

All links should have icons in in the sticky header

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Screenshot 2022-10-10 at 22-03-17 Honbice - Wikipedia.png (382×585 px, 116 KB)

Screenshot 2022-10-10 at 22-03-06 Honbice - Wikipedia.png (386×526 px, 45 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Remove translation entry point from sticky header temporarily	mediawiki/extensions/ContentTranslation	master	+4 -6
	contributionsmenu entrypoint: Use unique ids for portlet links in sticky header	mediawiki/extensions/ContentTranslation	master	+8 -3

Customize query in gerrit

Related Objects

Mentioned Here: T322740: Contribute entry point
T333327: Remove the contribution options exposed in user/contributions menu
T330611: Structure the links within the user-links-dropdown menu
T327369: Gadget support: Review and improve addPortletLink functionality and tests

Event Timeline

Patafisik created this task.Oct 10 2022, 8:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2022, 8:11 PM

Jdlrobson added a project: ContentTranslation.Oct 17 2022, 5:45 PM

I did a quick git bisect and the problem originated from this commit: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/836254

Jdlrobson moved this task from Incoming to Work with other teams on the Desktop Improvements (Vector 2022) board.Oct 18 2022, 5:28 PM

• Nikerabbit merged a task: T321143: Icons from translate extension not appearing in sticky header user menu.Oct 24 2022, 11:19 AM

• Nikerabbit moved this task from Needs Triage to Upstream/Other teams on the ContentTranslation board.

• Nikerabbit added a subscriber: ovasileva.

The issue here is the duplicate elements with ID cx-language. In 836254 we added some code that limited icon addition by element ID.

Presumably the two lines here: https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/20e0f6c2364254ff91df1d98b27ca21e6916aec9/modules/entrypoints/ext.cx.entrypoints.contributionsmenu.js#143 need to be changed to use a unique ID e.g. cx-language-sticky (and then your CSS needs updating to make sure that ID is associated with the icon since currently there is no icon parameter in mw.util.addPortletLink and the icon class is derived from ID.

• Nikerabbit moved this task from Upstream/Other teams to Bugs on the ContentTranslation board.Oct 25 2022, 7:00 AM

In T320448#8338896, @Jdlrobson wrote:

The issue here is the duplicate elements with ID cx-language. In 836254 we added some code that limited icon addition by element ID.

Presumably the two lines here: https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/20e0f6c2364254ff91df1d98b27ca21e6916aec9/modules/entrypoints/ext.cx.entrypoints.contributionsmenu.js#143 need to be changed to use a unique ID e.g. cx-language-sticky (and then your CSS needs updating to make sure that ID is associated with the icon since currently there is no icon parameter in mw.util.addPortletLink and the icon class is derived from ID.

Thanks for the context, Jon. Adding it to our quarter board.

Pginer-WMF moved this task from Quarter Backlog to Priority: Unified Content & Section Translation on the Language-Team (Language-2022-October-December) board.Oct 28 2022, 9:19 AM

santhosh claimed this task.Nov 7 2022, 9:14 AM

Change 853920 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] contributionsmenu entrypoint: Use unique ids for portlet links in sticky header

https://gerrit.wikimedia.org/r/853920

gerritbot added a project: Patch-For-Review.Nov 7 2022, 9:14 AM

After fix:

santhosh moved this task from Priority: Unified Content & Section Translation to In Review on the Language-Team (Language-2022-October-December) board.Nov 7 2022, 10:19 AM

Change 853920 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] contributionsmenu entrypoint: Use unique ids for portlet links in sticky header

https://gerrit.wikimedia.org/r/853920

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2022, 7:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 7 2022, 8:00 PM

• Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2022-October-December) board.Nov 10 2022, 7:25 AM

Jdlrobson merged a task: T323288: Missing icons in sticky header.Nov 18 2022, 3:21 PM

Jdlrobson added a subscriber: XanonymusX.

• Nikerabbit moved this task from Check after deployment to Needs QA on the Language-Team (Language-2022-October-December) board.Nov 30 2022, 9:49 AM

Test status: QA PASS

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-October-December) board.Dec 8 2022, 4:51 AM

Pginer-WMF closed this task as Resolved.Dec 9 2022, 10:17 AM

@Pginer-WMF are you sure is it resolved? I'm being testing the user menu in the sticky header in 3 different browsers, and still no icons for "Translations and "Uploaded media" for me.

@Patafisik I tested the browsers: Chrome, Safari and Firefox and I am able to see the icons for "Translations and "Uploaded media". Would there be anything you are doing different? I would like to try that

@EChukwukere-WMF you are testing the wrong menu in T320448#8453137. You need to scroll down the page to show the sticky header. See T320448#8373601. it will also not work on the main page.

It appears broken still for me on https://en.wikipedia.org/wiki/Nadezhda_Alliluyeva
Hope that helps!

Yes, still broken on dewiki too.

@XanonymusX and @Jdlrobson thanks for the clarification of workflow. Yes you both are right and I am able to verify this.

@santhosh pls see the video below on how I was able to verify this. Lets move this back into the in-progress column

EChukwukere-WMF reopened this task as In Progress.Dec 10 2022, 6:28 AM

EChukwukere-WMF moved this task from Done to In Progress on the Language-Team (Language-2022-October-December) board.

Change 867124 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Remove translation entry point from sticky header temporarily

https://gerrit.wikimedia.org/r/867124

gerritbot added a project: Patch-For-Review.Dec 12 2022, 10:51 AM

I just removed these menus from sticky header for now. Will revisit later(or even remove them permanently as persistant entry point for translations is ready)

Change 867124 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Remove translation entry point from sticky header temporarily

https://gerrit.wikimedia.org/r/867124

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2022, 11:30 AM

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Dec 12 2022, 12:01 PM

Pginer-WMF edited projects, added Language-Team (Language-2023-January-March); removed Language-Team (Language-2022-October-December).Jan 9 2023, 11:37 AM

Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-January-March) board.

In T320448#8459838, @santhosh wrote:

I just removed these menus from sticky header for now. Will revisit later(or even remove them permanently as persistant entry point for translations is ready)

Hi @santhosh, just FYI here a user is confused by this change.

We are waiting for a better API that avoids these problems.

This should be fixable now. In T327369 we made the sticky header support icons but possibly better to focus on the Special:Contribute endpoint and possibly retiring those menu links? See T330611 for concern about hierarchy.

In T320448#8664519, @Jdlrobson wrote:

This should be fixable now. In T327369 we made the sticky header support icons but possibly better to focus on the Special:Contribute endpoint and possibly retiring those menu links? See T330611 for concern about hierarchy.

Yes. Once the Contribute entry point is widely available, we can remove these options from the menu. I created a ticket to capture this: T333327: Remove the contribution options exposed in user/contributions menu

Should we decline this ticket, then?

In T320448#8735686, @Jdlrobson wrote:

Should we decline this ticket, then?

Sounds good to me.

Declining this since these actions are planned to be removed from both, sticky and top header, menus (T333327) once the contribution options are consolidated around the persistent entry point to contribute (T322740). So it is probably to spend efforts elsewhere, but feel free to reopen if there is any other aspect to consider on this.

	F35561345: Screenshot 2022-10-10 at 22-03-06 Honbice - Wikipedia.png
	Oct 10 2022, 8:11 PM

	F35561346: Screenshot 2022-10-10 at 22-03-17 Honbice - Wikipedia.png
	Oct 10 2022, 8:11 PM

	F35845457: icons.webm
	Dec 8 2022, 4:51 AM

	F35713464: image.png
	Nov 7 2022, 10:19 AM

Consider adding Translations and Uploaded media icons to the sticky headerClosed, DeclinedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Consider adding Translations and Uploaded media icons to the sticky header
Closed, DeclinedPublicBUG REPORT
Actions