Page MenuHomePhabricator
Create Task
Maniphest T321348

[S] [minor] "Show thumbnails in Special:Search" option is available on mobile
Closed, ResolvedPublic
Actions

Assigned To
vadim-kovalenko
Authored By
Etonkovidova
Oct 20 2022, 7:53 PM
Tags
Referenced Files
F36510894: Screen Shot 2023-01-25 at 1.46.26 PM.png
Jan 25 2023, 9:48 PM
F35889079: Screen Shot 2022-12-22 at 4.54.42 PM.png
Dec 23 2022, 12:56 AM
F35605515: Screen Shot 2022-10-20 at 12.29.51 PM.png
Oct 20 2022, 7:53 PM
F35605512: Screen Shot 2022-10-20 at 12.29.34 PM.png
Oct 20 2022, 7:53 PM
Subscribers
Aklapper
CBogen
Etonkovidova
matthiasmullie
SimoneThisDot
Sneha
vadim-kovalenko

Description

Currently, thumbnails are not available on mobile, however the Preference "Show thumbnails in Special:Search" is displayed in Preferences on mobile.

Steps to reproduce:

  1. On mobile type Special:Search in the search field or click on Settings - enable Advanced mode - click on Open preferences
Screen Shot 2022-10-20 at 12.29.34 PM.png (1×732 px, 154 KB)
  1. The option "Show thumbnails in Special:Search" is present and clickable. Clicking on it won't have any effect on mobile Search experience - CORRECT behavior.

Screen Shot 2022-10-20 at 12.29.51 PM.png (1×794 px, 189 KB)

Notes:
(1) Having an option that doesn't do anything might be confusing for users. Changing the option's status will affect desktop experience which can add to the users confusion.
(2) This case (the option that doesn't do anything on mobile) is not unique to "Show thumbnails in Special:Search". Another example is Watchlist -"Use non-JavaScript interface".

Acceptance Criteria

  • Change the copy of the preference title and subtitle/help text to the following:

    Title: Show thumbnails in Special:Search on Desktop

    Subtitle: Displays thumbnails for [Article] namespace results on special:search page

Details

SubjectRepoBranchLines +/-
"Show thumbnails in Special:Search" option is available on mobilemediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Oct 20 2022, 7:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2022, 7:53 PM
CBogen added a subscriber: Sneha.Oct 20 2022, 7:56 PM

@Sneha I wonder if an easy solution could be to just say "Show thumbnails in Special:Search on desktop" as the preference text?

CBogen added a project: SDAW-Search-Improvements (Milestone 1: CSS changes to all wikis).Oct 20 2022, 7:57 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 24 2022, 5:00 PM
CBogen moved this task from Incoming to Needs Design on the Structured-Data-Backlog (Current Work) board.
Sneha added a comment.Oct 28 2022, 8:01 PM

@CBogen Are we not able to hide that setting if we detect a mobile skin? If not we can say on Desktop.

However, the copy of the setting needs to be updated. The way it is written right now is a bit confusing and lengthy.

Here is my suggestion for copy:
Title: Show thumbnails
OR
Title: Show thumbnails on desktop

Subtitle: Displays thumbnails for article namespace results on special:search page"

CBogen added a subscriber: matthiasmullie.Oct 28 2022, 8:03 PM
In T321348#8353882, @Sneha wrote:

@CBogen Are we not able to hide that setting if we detect a mobile skin? If not we can say on Desktop.

However, the copy of the setting needs to be updated. The way it is written right now is a bit confusing and lengthy.

Here is my suggestion for copy:
Title: Show thumbnails
OR
Title: Show thumbnails on desktop

Subtitle: Displays thumbnails for article namespace results on special:search page"

I'm not sure. @matthiasmullie do you know?

Sneha moved this task from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Dec 5 2022, 5:27 PM
SimoneThisDot subscribed.Dec 14 2022, 12:20 PM

I have done some small research and there is no native way to disable the config on mobile. We could do some work to prevent the Config to be created if on mobile skin, but it is not currently done from what I can see. (I used this reference for all available properties on the config type:https://www.mediawiki.org/wiki/HTMLForm)

I have also done some investigation on the mobile config and other config that are skin dependent and they seem to specify where something will work, for example this is from the mobile config: "Optimize and simplify special pages when on mobile (recommended)" and this "Adapt layout to screen size on mobile."

Sneha added a comment.Dec 14 2022, 3:25 PM

Hmm okay then we can change the copy (as shown below) to make things more clear. Also the title is getting long already so reduced the help text under it. Since we are clearly saying this for article namespace we don't have to mention files.

Title: Show thumbnails in Special:Search on Desktop
Subtitle: Displays thumbnails for article namespace results on special:search page"

CBogen updated the task description. (Show Details)Dec 14 2022, 3:32 PM
CBogen updated the task description. (Show Details)
CBogen renamed this task from [minor] "Show thumbnails in Special:Search" option is available on mobile to [S] [minor] "Show thumbnails in Special:Search" option is available on mobile.Dec 14 2022, 5:27 PM
CBogen updated the task description. (Show Details)
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.
vadim-kovalenko claimed this task.Dec 15 2022, 1:14 PM
vadim-kovalenko moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Dec 15 2022, 2:43 PM

Change 868119 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/core@master] "Show thumbnails in Special:Search" option is available on mobile

https://gerrit.wikimedia.org/r/868119

gerritbot added a project: Patch-For-Review.Dec 15 2022, 2:44 PM
vadim-kovalenko moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Dec 15 2022, 3:12 PM
gerritbot added a comment.Dec 16 2022, 9:13 AM

Change 868119 merged by jenkins-bot:

[mediawiki/core@master] "Show thumbnails in Special:Search" option is available on mobile

https://gerrit.wikimedia.org/r/868119

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 16 2022, 10:00 AM
Etonkovidova mentioned this in T314963: [S] Ensure that mobile search results are not affected by desktop QuickView.Dec 16 2022, 10:54 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 16 2022, 11:30 PM
vadim-kovalenko moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 21 2022, 1:52 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Dec 23 2022, 12:56 AM

Checked in betalabs - the text has been changed accordingly:

Screen Shot 2022-12-22 at 4.54.42 PM.png (1×818 px, 133 KB)

Etonkovidova closed this task as Resolved.Jan 25 2023, 9:48 PM

Checked in testwiki wmf.20 - the text is correct:

Screen Shot 2023-01-25 at 1.46.26 PM.png (1×820 px, 144 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL