Page MenuHomePhabricator
Create Task
Maniphest T321350

Phabricator translations can no more be received due to decommissioning of git-ssh
Closed, ResolvedPublic
Actions

Description

T296022 has removed the SSH git-ssh.wikimedia.org endpoint which was used to push to Phabricator repository. @Nikerabbit mentioned that broke publishing of TranslateWiki translations and their system only support ssh for authentication.

It pushed to ssh://vcs@git-ssh.wikimedia.org/source/phabricator-translations.git

The repository is a submodule of Phabricator deployment repository: https://gerrit.wikimedia.org/r/plugins/gitiles/phabricator/deployment/+/refs/heads/wmf/stable/.gitmodules

Given the deployment repo is on Gerrit and other submodules are on Gerrit, we should migrate ssh://vcs@git-ssh.wikimedia.org/source/phabricator-translations.git to Gerrit with push rights granted to whatever user TranslateWiki is using (l10n-bot?).

(*) https://www.mediawiki.org/wiki/Git/Creating_new_repositories#Importing_from_an_existing_repository

Details

SubjectRepoBranchLines +/-
Add l10n-bot to phabricator/translationsintegration/configmaster+6 -0
Grant l10n bot rightsphabricator/translationsrefs/meta/config+6 -0
Add auto-merge for phabricatortranslatewikimaster+1 -0
Update repository for phabricator translationtranslatewikimaster+3 -3
.gitmodules: translations migrated to Gerritphabricator/deploymentwmf/stable+1 -1
Allow L10n-bot to push to wmf/stable branchphabricator/translationsrefs/meta/config+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Oct 20 2022, 8:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2022, 8:07 PM
hashar added projects: translatewiki.net, Release-Engineering-Team.Oct 20 2022, 8:08 PM
Nikerabbit added a subscriber: abi_.Oct 20 2022, 8:08 PM
hashar updated the task description. (Show Details)Oct 20 2022, 8:12 PM
hashar updated the task description. (Show Details)
Dzahn added a parent task: T296022: Deprecate git-ssh service on phabricator.wikimedia.org.Oct 20 2022, 8:14 PM
Dzahn added a comment.Oct 20 2022, 8:18 PM

git-ssh had been deactivated for at least a week but what happened today additionally is that I actively set the "URI" under "manage repository" in DIffusion to "no I/O" and deleted the service from DNS.

This changed it from "time out" to a new more active error which made it more visible.

I imported the repo into gitlab but hashar voiced a preference for having it on Gerrit together with other Phabricator repos.

hashar added a comment.Oct 20 2022, 8:51 PM

No worries, I will create the repo, add L10N-bot sync up with @Nikerabbit to confirm the sync up works again and also normalize the URLs.

Dzahn awarded a token.Oct 20 2022, 8:59 PM
gerritbot added a comment.Oct 21 2022, 8:45 AM

Change 845019 had a related patch set uploaded (by Hashar; author: Hashar):

[phabricator/translations@refs/meta/config] Allow L10n-bot to push to wmf/stable branch

https://gerrit.wikimedia.org/r/845019

gerritbot added a project: Patch-For-Review.Oct 21 2022, 8:45 AM

Change 845019 merged by Hashar:

[phabricator/translations@refs/meta/config] Allow L10n-bot to push to wmf/stable branch

https://gerrit.wikimedia.org/r/845019

Stashbot added a comment.Oct 21 2022, 8:46 AM

Mentioned in SAL (#wikimedia-releng) [2022-10-21T08:46:24Z] <hashar> Created https://gerrit.wikimedia.org/r/admin/repos/phabricator/translations # T321350

Nikerabbit added a comment.Oct 21 2022, 8:58 AM

FYI L10n-bot gerrit docs are in https://www.mediawiki.org/wiki/Gerrit/L10n-bot.

hashar mentioned this in rPHTR Phabricator Translations.Oct 21 2022, 9:01 AM

I have imported the repository to Gerrit following the documentation at https://www.mediawiki.org/wiki/Git/Creating_new_repositories#Importing_from_an_existing_repository

$ git clone --mirror https://phabricator.wikimedia.org/source/phabricator-translations.git
Cloning into bare repository 'phabricator-translations.git'...
remote: Enumerating objects: 14057, done.
remote: Counting objects: 100% (14057/14057), done.
remote: Compressing objects: 100% (8194/8194), done.
remote: Total 14057 (delta 10527), reused 9057 (delta 5859)
Receiving objects: 100% (14057/14057), 13.52 MiB | 1.56 MiB/s, done.
Resolving deltas: 100% (10527/10527), done.

$ cd phabricator-translations.git

phabricator-translations.git(BARE:wmf/stable)$ git remote add gerrit ssh://gerrit.wikimedia.org:29418/phabricator/translations
phabricator-translations.git(BARE:wmf/stable)$ git push --mirror gerrit

I had to further adjust permissions cause I missed a few to do the import and eventually everything got pushed with the exception of refs/meta/config which the Gerrit repository configuration

phabricator-translations.git(BARE:wmf/stable)$ git push --mirror gerrit
remote: error: branch refs/meta/config:
remote: Cannot delete project configuration from 'refs/meta/config'
remote: error: branch refs/meta/config:
remote: You need 'Delete Reference' rights or 'Push' rights with the 
remote: 'Force Push' flag set to delete references.
remote: User: hashar
remote: Contact an administrator to fix the permissions
remote: Processing changes: refs: 1, done    
To ssh://gerrit.wikimedia.org:29418/phabricator/translations
 ! [remote rejected] refs/meta/config (prohibited by Gerrit: not permitted: delete)
error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/phabricator/translations'

I have deactivated the Phabricator repository https://phabricator.wikimedia.org/source/phabricator-translations/manage/ .

Nikerabbit added projects: Language-Team (Language-2022-October-December), Unplanned-Sprint-Work.Oct 21 2022, 9:05 AM
Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-October-December) board.
gerritbot added a comment.Oct 21 2022, 9:06 AM

Change 845459 had a related patch set uploaded (by Hashar; author: Hashar):

[phabricator/deployment@wmf/stable] .gitmodules: translations migrated to Gerrit

https://gerrit.wikimedia.org/r/845459

hashar added a comment.Oct 21 2022, 9:07 AM

@Nikerabbit the new repository is https://gerrit.wikimedia.org/r/phabricator/translations. The L10n bot has been granted [[ https://gerrit.wikimedia.org/r/admin/repos/phabricator/translations,access | permission to push to the wmf/stable branch ]].

You should thus be able to adjust the TranslateWiki configuration to push to ssh://gerrit.wikimedia.org:29418/phabricator/translations

hashar updated the task description. (Show Details)Oct 21 2022, 10:01 AM
hashar mentioned this in T321380: Move phabricator/deployments repository from Diffusion to GitLab/Gerrit.
gerritbot added a comment.Oct 21 2022, 5:07 PM

Change 845459 merged by Brennen Bearnes:

[phabricator/deployment@wmf/stable] .gitmodules: translations migrated to Gerrit

https://gerrit.wikimedia.org/r/845459

hashar mentioned this in rPHDEPa09b626abcb4: .gitmodules: translations migrated to Gerrit.Oct 21 2022, 7:26 PM
Dzahn mentioned this in T191182: Migrate active repositories in Phabricator Differential to GitLab.Oct 21 2022, 10:22 PM
Nikerabbit triaged this task as Medium priority.Oct 27 2022, 8:19 AM
Nikerabbit moved this task from Backlog to Configuration changes on the translatewiki.net board.Nov 3 2022, 11:55 AM
gerritbot added a comment.Nov 18 2022, 5:17 PM

Change 858629 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Update repository for phabricator translation

https://gerrit.wikimedia.org/r/858629

abi_ changed the task status from Open to In Progress.Nov 28 2022, 5:19 AM
abi_ assigned this task to hashar.
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2022-October-December) board.
gerritbot added a comment.Nov 29 2022, 8:10 AM

Change 858629 merged by jenkins-bot:

[translatewiki@master] Update repository for phabricator translation

https://gerrit.wikimedia.org/r/858629

gerritbot added a comment.Nov 29 2022, 12:32 PM

Change 861836 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Add auto-merge for phabricator

https://gerrit.wikimedia.org/r/861836

gerritbot added a comment.Nov 29 2022, 2:23 PM

Change 861836 merged by jenkins-bot:

[translatewiki@master] Add auto-merge for phabricator

https://gerrit.wikimedia.org/r/861836

Aklapper added a parent task: T318763: Work out how to bring in new Phabricator translations again.Nov 30 2022, 9:17 AM
Nikerabbit removed a project: Patch-For-Review.Nov 30 2022, 9:53 AM
Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2022-October-December) board.
Nikerabbit added a comment.Dec 1 2022, 1:07 PM

L10n-bot doesn't do a direct push in Gerrit, so we would need the default l10n-bot(-watcher) permissions and i18n-check on this repo.

We could also look into making it into a direct push, but I think former is preferable.

Nikerabbit moved this task from Check after deployment to Blocked on the Language-Team (Language-2022-October-December) board.Dec 1 2022, 1:08 PM
Dzahn added a parent task: T191182: Migrate active repositories in Phabricator Differential to GitLab.Dec 2 2022, 11:07 PM
gerritbot added a comment.Dec 4 2022, 9:20 AM

Change 863356 had a related patch set uploaded (by Hashar; author: Hashar):

[phabricator/translations@refs/meta/config] Grant l10n bot rights

https://gerrit.wikimedia.org/r/863356

gerritbot added a project: Patch-For-Review.Dec 4 2022, 9:20 AM
gerritbot added a comment.Dec 4 2022, 9:27 AM

Change 863804 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Add l10n-bot to phabricator/translations

https://gerrit.wikimedia.org/r/863804

hashar added a comment.Dec 4 2022, 9:32 AM
In T321350#8435239, @Nikerabbit wrote:

L10n-bot doesn't do a direct push in Gerrit, so we would need the default l10n-bot(-watcher) permissions and i18n-check on this repo.

We could also look into making it into a direct push, but I think former is preferable.

I have completely missed l10n-bot needed some extra permissions and a job to be triggered. Proposals:

Can we pair together to deploy those changes, trigger the l10n-bot and verify it is working properly?

gerritbot added a comment.Dec 8 2022, 12:30 PM

Change 863356 merged by Hashar:

[phabricator/translations@refs/meta/config] Grant l10n bot rights

https://gerrit.wikimedia.org/r/863356

gerritbot added a comment.Dec 8 2022, 12:33 PM

Change 863804 merged by jenkins-bot:

[integration/config@master] Add l10n-bot to phabricator/translations

https://gerrit.wikimedia.org/r/863804

Nikerabbit closed this task as Resolved.Dec 8 2022, 12:44 PM
Nikerabbit moved this task from Blocked to Done on the Language-Team (Language-2022-October-December) board.

Proof: https://gerrit.wikimedia.org/r/c/phabricator/translations/+/866358

gerritbot added a comment.Dec 8 2022, 10:36 PM

Related commit a09b626a pushed by brennen (author: Antoine Musso):

[ repos/phabricator/deployment@wmf/stable ] .gitmodules: translations migrated to Gerrit

hashar mentioned this in T228507: Disable "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/.Dec 14 2022, 4:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL