Page MenuHomePhabricator
Create Task
Maniphest T321639

Names.php: Language codes in SVG should use BCP 47 codes, but some language names won't show when they are only defined in MediaWiki internal codes
Open, Needs TriagePublicBUG REPORT
Actions

Description

Names.php : Language codes in SVG should use BCP 47 codes, but some language names won't show when they are only defined in MediaWiki internal codes.

Steps to replicate the issue (include links if applicable):

What happens?:

  • The BCP 47 codes cannot show their language names

What should have happened instead?:

  • The BCP 47 codes should able to show their language names

Software version:

  • Wikimedia Commons, MediaWiki 1.40.0-wmf.6 ( bb4c5db )

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Winston_Sung created this task.Oct 26 2022, 2:18 AM
gerritbot added a comment.Oct 26 2022, 2:18 AM

Change 805351 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] i18n: Add missing BCP 47 codes in Names.php and LanguageCode.php

https://gerrit.wikimedia.org/r/805351

gerritbot added a project: Patch-For-Review.Oct 26 2022, 2:18 AM
Winston_Sung changed the task status from Open to In Progress.Oct 26 2022, 2:48 AM
Winston_Sung moved this task from Untriaged to Language data and databases on the I18n board.
Nikki subscribed.Oct 26 2022, 6:21 AM

I don't think they need adding to Names.php for that. The dropdown is showing translated names. They will need adding to LocalNamesEn.php to add the English names and LocalNamesEn.php overrides names from Names.php (see azb in the list on https://commons.wikimedia.org/wiki/File:SystemLanguage.svg?uselang=zh, for example).

Winston_Sung added a comment.Oct 26 2022, 9:01 AM

Do we consider fix the issue in {{#language: parser function?

Winston_Sung added a comment.Oct 26 2022, 9:44 AM

By the way, the label will find the names in CLDR extension first (if installed) THEN Names.php . So we should add them in both files.

Winston_Sung added a comment.Oct 26 2022, 9:44 AM

↑ CC @Nikki

• Moleke4477 removed subscribers: Nikki, Nikerabbit, Aklapper, Winston_Sung.Oct 31 2022, 6:06 PM
Cyberpower678 added subscribers: Nikki, Nikerabbit, Aklapper, Winston_Sung.Oct 31 2022, 6:13 PM
Pginer-WMF edited projects, added SVG, Language-Team (Language-2022-October-December); removed Language-Team.Nov 21 2022, 11:25 AM
Winston_Sung added a subscriber: Amire80.Nov 25 2022, 10:29 AM
gerritbot added a comment.Jan 9 2023, 1:45 AM

Change 876305 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code cbk (Zamboanga Chavacano) to Names.php

https://gerrit.wikimedia.org/r/876305

gerritbot added a comment.Jan 9 2023, 1:48 AM

Change 876406 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code cdo-* (Eastern Min) to Names.php

https://gerrit.wikimedia.org/r/876406

gerritbot added a comment.Jan 9 2023, 1:52 AM

Change 876407 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add cpx / cpx-* (Pu-xian Min) to Names.php

https://gerrit.wikimedia.org/r/876407

gerritbot added a comment.Jan 9 2023, 1:55 AM

Change 876408 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code de-x-formal (German - formal address ("Sie")) to Names.php

https://gerrit.wikimedia.org/r/876408

gerritbot added a comment.Jan 9 2023, 1:56 AM

Change 876409 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code en-simple (Simple English) to Names.php

https://gerrit.wikimedia.org/r/876409

gerritbot added a comment.Jan 9 2023, 1:58 AM

Change 876410 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code es-x-formal (Spanish formal address) to Names.php

https://gerrit.wikimedia.org/r/876410

gerritbot added a comment.Jan 9 2023, 2:00 AM

Change 876411 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add hak-* (Hakka) to Names.php

https://gerrit.wikimedia.org/r/876411

gerritbot added a comment.Jan 9 2023, 4:38 AM

Change 876413 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code hsn-* (Xiang) to Names.php

https://gerrit.wikimedia.org/r/876413

gerritbot added a comment.Jan 9 2023, 4:50 AM

Change 876414 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code hu-x-formal (Hungarian formal address) to Names.php

https://gerrit.wikimedia.org/r/876414

gerritbot added a comment.Jan 9 2023, 8:00 AM

Change 876415 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code jv-x-bms (map-bms, Banyumasan) to Names.php

https://gerrit.wikimedia.org/r/876415

gerritbot added a comment.Jan 9 2023, 9:00 AM

Change 876416 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add mnc / mnc-* (Manchu) to Names.php

https://gerrit.wikimedia.org/r/876416

gerritbot added a comment.Jan 9 2023, 9:03 AM

Change 876417 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code nan-* (Southern Min) to Names.php

https://gerrit.wikimedia.org/r/876417

gerritbot added a comment.Jan 9 2023, 9:11 AM

Change 876418 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code nap-x-tara (Tarantino) to Names.php

https://gerrit.wikimedia.org/r/876418

gerritbot added a comment.Jan 9 2023, 9:18 AM

Change 876419 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code nl-x-informal (Dutch (informal address ("je"))) to Names.php

https://gerrit.wikimedia.org/r/876419

gerritbot added a comment.Jan 9 2023, 9:29 AM

Change 876420 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code nrf (nrm, Norman) to Names.php

https://gerrit.wikimedia.org/r/876420

gerritbot added a comment.Jan 9 2023, 9:38 AM

Change 876424 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code wuu-* (Wu) to Names.php

https://gerrit.wikimedia.org/r/876424

Raymond subscribed.Jan 9 2023, 3:04 PM
gerritbot added a comment.Jan 12 2023, 10:34 AM

Change 879402 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code zh-*-* ((Mandarin) Chinese) to Names.php

https://gerrit.wikimedia.org/r/879402

gerritbot added a comment.Jan 12 2023, 10:38 AM

Change 879403 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code kk-*-* (Kazakh) to Names.php

https://gerrit.wikimedia.org/r/879403

gerritbot added a comment.Jan 12 2023, 10:43 AM

Change 879404 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] Add missing BCP 47 code ro-cyrl-md (mo, Moldovan) to Names.php

https://gerrit.wikimedia.org/r/879404

cscott subscribed.Jan 31 2023, 7:34 PM

I don't think this is the right solution. We have good support for Bcp47Code in core now. We should more-carefully distinguish between "BCP-47 codes" (used in web standards, such as HTML, HTTP, and SVG) and "MediaWiki internal codes", and carefully convert between them (using the functions available both in core and client-side) where needed. We shouldn't need to add redundant entries to Names.php.

gerritbot added a comment.Jan 31 2023, 7:54 PM

Change 805351 merged by jenkins-bot:

[mediawiki/core@master] Minor adjustments for Names.php and LanguageCode.php

https://gerrit.wikimedia.org/r/805351

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Jan 31 2023, 8:00 PM
Winston_Sung added a comment.EditedFeb 1 2023, 4:26 AM
In T321639#8575952, @cscott wrote:

I don't think this is the right solution. We have good support for Bcp47Code in core now. We should more-carefully distinguish between "BCP-47 codes" (used in web standards, such as HTML, HTTP, and SVG) and "MediaWiki internal codes", and carefully convert between them (using the functions available both in core and client-side) where needed. We shouldn't need to add redundant entries to Names.php.

Then there are 2 solutions:

  • Use BCP 47 codes in Names.php
    • LanguageCode::bcp47
    • Pros:
      • Language code follow BCP 47 mapping
      • We can have the actual als code in Names.php
    • Cons:
      • Names.php does not use MediaWiki internal codes
  • Map BCP 47 back to MediaWiki internal codes in the SVG lang menu
    • LanguageCode::bcp47ToInternal()

Any opinions?

Winston_Sung added a comment.Feb 6 2023, 11:25 AM

Any opinions / thoughts for the solutions?

CC:
@Nikerabbit
@Amire80
@cscott

gerritbot added a comment.Feb 26 2023, 3:18 AM

Change 876420 abandoned by Winston Sung:

[mediawiki/core@master] Add nrf (nrm, Norman) to Names.php

Reason:

Replaced-by Ib8d3c344ebe082e4d3e5ec12b3815c5845f4797e

https://gerrit.wikimedia.org/r/876420

Glrx subscribed.Jun 6 2023, 1:34 AM
Winston_Sung moved this task from Language data and databases to Language names and codes on the I18n board.Aug 10 2023, 9:06 AM
gerritbot added a comment.Nov 17 2023, 5:21 PM

Change 879402 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code zh-*-* ((Mandarin) Chinese) to Names.php

Reason:

https://gerrit.wikimedia.org/r/879402

gerritbot added a comment.Nov 17 2023, 5:21 PM

Change 876414 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code hu-x-formal (Hungarian formal address) to Names.php

Reason:

https://gerrit.wikimedia.org/r/876414

gerritbot added a comment.Nov 17 2023, 5:21 PM

Change 876410 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code es-x-formal (Spanish formal address) to Names.php

Reason:

https://gerrit.wikimedia.org/r/876410

gerritbot added a comment.Nov 17 2023, 5:22 PM

Change 876419 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code nl-x-informal (Dutch (informal address ("je"))) to Names.php

Reason:

https://gerrit.wikimedia.org/r/876419

gerritbot added a comment.Nov 17 2023, 5:22 PM

Change 879403 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code kk-*-* (Kazakh) to Names.php

Reason:

https://gerrit.wikimedia.org/r/879403

gerritbot added a comment.Jan 12 2024, 11:46 AM

Change 876415 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code jv-x-bms (map-bms, Banyumasan) to Names.php

Reason:

https://gerrit.wikimedia.org/r/876415

gerritbot added a comment.Jan 12 2024, 11:46 AM

Change 876408 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code de-x-formal (German - formal address ("Sie")) to Names.php

Reason:

https://gerrit.wikimedia.org/r/876408

gerritbot added a comment.Jan 12 2024, 11:46 AM

Change 876418 abandoned by Winston Sung:

[mediawiki/core@master] Add missing BCP 47 code nap-x-tara (Tarantino) to Names.php

Reason:

https://gerrit.wikimedia.org/r/876418

Pppery changed the task status from In Progress to Open.Sat, Jun 15, 3:29 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL