Page MenuHomePhabricator
Create Task
Maniphest T323098

Limited discovery: What is needed to implement language fallback on mobile termbox?
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Problem 1:
The new mul language code functionality depends on a reliable language fallback chain. So far, the Mobile version seems to follow a different language fallback chain than we follow on Desktop:

Mobile IP experience

  • Heading: English (likely uselang, but cannot be changed) *without* language fallback
  • In more languages: English (in the heading), German, French, Bavarian (unclear where this comes from, it is different to desktop)
  • All entered languages: All entered languages
  • https://m.wikidata.org/wiki/Q444444?uselang=en-gb (please log out)

Desktop IP experience

  • Heading: Uselang (can be changed) *with* language fallback
  • In more languages: English, German, Uselang, Russian (unclear where this comes from, it is different to mobile)
  • All entered languages: All entered languages
  • https://www.wikidata.org/wiki/Q444444?uselang=en-gb (please log out)

Mobile logged-in experience

  • Heading: uselang (can also be set via uselang=) *without* language fallback
  • In more languages: 1. Uselang (in the heading), 2. Based on Babels
  • All entered languages: All entered languages
  • https://m.wikidata.org/wiki/Q444444?uselang=en-gb (please log in)

Desktop logged-in experience

Problem 2:
If you edit using the mobile termbox, you can edit the heading directly.

image.png (580×774 px, 25 KB)

This workflow makes the mobile termbox incompatible with language fallback.

To enable language fallback on the mobile termbox, we would need to modify the editing workflow. It is currently unclear to us, how much of that work would survive a later refactoring of the front end (to make full use of the new design system). This information would help us to better plan what changes we want to make now and what changes we can make at a later point in time (with greater overall effectiveness).

Acceptance criteria:
Problem 1:

  • We understand where the differences between Mobile and Desktop come from.
  • We understand what will be needed to make the Mobile language fallback the same as on the Desktop.

Problems 1 & 2:

  • We understand, how much of the work is still useful after we replace the frontend (in favor of a new design system-powered version).

Related Objects
Search...

Event Timeline

Manuel created this task.Nov 15 2022, 10:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2022, 10:38 AM
Manuel added parent tasks: T313024: [Milestone] v0.3 of the `mul` language code (test.wikidata.org), T322258: [EPIC] Change the workflow of mobile termbox to replicate the workflow of desktop termbox .Nov 15 2022, 10:39 AM
Manuel mentioned this in T312097: [EPIC] MUL - Default values for labels and aliases .
Manuel mentioned this in T322258: [EPIC] Change the workflow of mobile termbox to replicate the workflow of desktop termbox .
Manuel removed a parent task: T313024: [Milestone] v0.3 of the `mul` language code (test.wikidata.org).Nov 15 2022, 10:42 AM
Maintenance_bot added a project: Wikidata.Nov 15 2022, 10:45 AM
Lucas_Werkmeister_WMDE added a comment.Nov 17 2022, 3:20 PM

It seems to be taking the Babel into account on my end:

image.png (617×1 px, 79 KB)

Also, “English, German, French, Bavarian” is based on the visitor’s approximate geographical information.

Manuel updated the task description. (Show Details)Nov 17 2022, 3:27 PM
Manuel updated the task description. (Show Details)Nov 17 2022, 3:30 PM
Manuel moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Manuel added a project: Wikidata Dev Team.
Manuel moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Nov 17 2022, 3:33 PM
Lydia_Pintscher moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Nov 22 2022, 10:57 AM
Manuel updated the task description. (Show Details)Nov 23 2022, 11:56 AM
Manuel renamed this task from Limited discovery: What is the current state of language handling on mobile termbox? to Limited discovery: What is needed to make mobile termbox ready for MUL?.Nov 23 2022, 8:23 PM
Manuel renamed this task from Limited discovery: What is needed to make mobile termbox ready for MUL? to Limited discovery: What is needed to implement language fallback on mobile termbox?.
Manuel updated the task description. (Show Details)
Manuel added subscribers: ItamarWMDE, Michael.Nov 23 2022, 8:29 PM
karapayneWMDE subscribed.Nov 29 2022, 10:10 AM

timebox of : 1 day (8 hours)

karapayneWMDE set the point value for this task to 1.Nov 29 2022, 10:10 AM
karapayneWMDE moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
noarave moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Nov 29 2022, 1:03 PM
HasanAkgun_WMDE claimed this task.Dec 5 2022, 9:16 AM
HasanAkgun_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
HasanAkgun_WMDE added a comment.Dec 21 2022, 2:42 PM

I couldn't reproduce the order in "In more languages" section (desktop and mobile has the same order of items, both logged out). After talking with @ItamarWMDE, we decided to take a deeper look into fallback algorithm and terms. Then we can talk about edit mechanism in mobile termbox.

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptDec 21 2022, 2:42 PM
HasanAkgun_WMDE added a comment.Jan 5 2023, 9:11 AM

It seems like difference between desktop and mobile was because of the order and content of language codes array sent to Termbox renderer and right now it's already solved. Editing workflow on mobile can be changed within a day, IMO.

HasanAkgun_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Jan 5 2023, 9:12 AM
Manuel added a comment.Jan 31 2023, 5:04 PM

This is great news! Thank you, Hasan!

I can confirm that all differences between mobile and desktop seem to now only come from the missing fallback in the heading on mobile (apart from some diverging geolocation results).

This is a description of the status quo:

Screenshot 2023-01-31 172626.png (316×636 px, 33 KB)

Manuel closed this task as Resolved.Jan 31 2023, 5:04 PM
karapayneWMDE moved this task from Peer Review to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.Feb 6 2023, 3:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL