thumbnail is always null in https://en.wikipedia.beta.wmflabs.org/w/rest.php/v1/search/title?q=Dog%20do&limit=10 but https://en.wikipedia.beta.wmflabs.org/wiki/Dog?action=info has an associated page image.

I have a wild guess that public function getThumbnails( array $pageIdentities, ?int $size = 60 ): array { I added is incorrect and should be public function getThumbnails( array $pageIdentities, int $size = 60 ): array { instead (removing the question mark in typehint). But haven't had time to test it in beta cluster.

@Cparle could this relate to T320661 ? (Just trying to identify changes in the associated codebases)

In T323152#8397368, @Ladsgroup wrote:

I have a wild guess that public function getThumbnails( array $pageIdentities, ?int $size = 60 ): array { I added is incorrect and should be public function getThumbnails( array $pageIdentities, int $size = 60 ): array { instead (removing the question mark in typehint). But haven't had time to test it in beta cluster.

Your code should be fine, I think.

In T323152#8397398, @Jdforrester-WMF wrote:

In T323152#8397368, @Ladsgroup wrote:

I have a wild guess that public function getThumbnails( array $pageIdentities, ?int $size = 60 ): array { I added is incorrect and should be public function getThumbnails( array $pageIdentities, int $size = 60 ): array { instead (removing the question mark in typehint). But haven't had time to test it in beta cluster.

Your code should be fine, I think.

you're right, I pulled the patch in mwdebug1001 and checked https://en.wikipedia.org/w/rest.php/v1/search/title?q=S&limit=10 and it was returning 60px thumbs and it wasn't broken. It can be the fair use case that break it then.

Yeah, this is probably a Beta Cluster Commons issue; the code is working fine e.g. on Meta, using wmf.10:

I propose we detach this from blocking the train, and either Decline it or someone debugs what's different about Beta Cluster this week and fixes that.

Maybe related to T321654

It's related to T320661 - fix incoming.

Change 857416 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/PageImages@master] Ensure array is passed to getProperties

https://gerrit.wikimedia.org/r/857416

Change 857426 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/PageImages@wmf/1.40.0-wmf.10] Ensure array is passed to getProperties

https://gerrit.wikimedia.org/r/857426

Change 857416 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Ensure array is passed to getProperties

https://gerrit.wikimedia.org/r/857416

Thumbnails are back on beta. Will backport to wmf.10 later today.

Change 857426 merged by jenkins-bot:

[mediawiki/extensions/PageImages@wmf/1.40.0-wmf.10] Ensure array is passed to getProperties

https://gerrit.wikimedia.org/r/857426

Mentioned in SAL (#wikimedia-operations) [2022-11-16T14:15:22Z] <mlitn@deploy1002> Started scap: Backport for [[gerrit:857426|Ensure array is passed to getProperties (T323152)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-16T14:15:49Z] <mlitn@deploy1002> mlitn and mlitn: Backport for [[gerrit:857426|Ensure array is passed to getProperties (T323152)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-16T14:24:57Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:857426|Ensure array is passed to getProperties (T323152)]] (duration: 09m 34s)

Backport complete. Thanks for noticing this!

Thanks @matthiasmullie for the swift fix :)