Page MenuHomePhabricator

CodeMirror should not use jQuery.UI
Closed, ResolvedPublicBUG REPORT

Description

jQuery UI has been deprecated since 2017 and is now end of life.
https://gerrit.wikimedia.org/g/mediawiki/extensions/CodeMirror/+/d6983e8a535b83f75249050ece84745ffca62150/extension.json#40

Please help us migrate away from it by working out the migration path for this code.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I'm not sure what other bits of jQuery UI are used in CodeMirror, but one thing is resizable. It's not used if $wgWikiEditorRealtimePreview is true (and that's already the default on almost all Wikimedia wikis; T313420 will resolve the last one). So one way to get rid of jQuery UI resizable would be to change the default value of that configuration variable.

Based on this change it looks like resizable is probably the only bit of jQuery UI used in CodeMirror (or at least it was in Nov 2019, and I can't imagine we would have added new uses since then).

We've put this in our engineering backlog for now, but I'll note we'll very likely remove all remnants of jQuery UI anyway for T259059: Upgrade to CodeMirror 6 which we hope to tackle in Q1 2023.

Change 901505 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: enable by default

https://gerrit.wikimedia.org/r/901505

Change 901505 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: enable by default

https://gerrit.wikimedia.org/r/901505

Change 1012449 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/CodeMirror@master] Remove depndency on jquery.ui from CodeMirror

https://gerrit.wikimedia.org/r/1012449

Change 1012449 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Remove dependency on jquery.ui from CodeMirror

https://gerrit.wikimedia.org/r/1012449

MusikAnimal assigned this task to TheDJ.
MusikAnimal moved this task from CodeMirror 6 to Done on the MediaWiki-extensions-CodeMirror board.