Page MenuHomePhabricator
Create Task
Maniphest T323639

Talk page banners are not collapsible in mobile DiscussionTools
Closed, ResolvedPublic
Actions

Description

Talk page banners are not collapsible in mobile DiscussionTools.

To reproduce: Visit https://en.m.wikipedia.org/wiki/Talk:The_Fighting_Temeraire?dtenable=1 and click "Learn more about this page":

image.png (2×3 px, 563 KB)

Compare to desktop at https://en.wikipedia.org/wiki/Talk:The_Fighting_Temeraire?dtenable=1:

image.png (2×3 px, 572 KB)

Details

SubjectRepoBranchLines +/-
Remove jquery.makeCollapsible workarounds for mobilemediawiki/extensions/DiscussionToolsmaster+4 -21
Allow collapsible content in Minervamediawiki/skins/MinervaNeuemaster+4 -3
Enable collapsible content in mobile talk page lede contentmediawiki/extensions/DiscussionToolsmaster+22 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Nov 22 2022, 7:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2022, 7:22 PM
gerritbot added a comment.Nov 22 2022, 7:29 PM

Change 859605 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Allow collapsible content in Minerva

https://gerrit.wikimedia.org/r/859605

gerritbot added a project: Patch-For-Review.Nov 22 2022, 7:29 PM
matmarex claimed this task.Nov 22 2022, 7:33 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.

(There are some other problems with the rendering of these boxes, particularly at narrower sizes – I plan to propose changes on-wiki to resolve them after this issue is fixed.)

Tacsipacsi added a subtask: T111565: Enable collapsible templates (including infoboxes) on mobile.Nov 22 2022, 10:18 PM
Tacsipacsi subscribed.
ppelberg subscribed.Nov 23 2022, 7:29 PM
ppelberg edited projects, added Editing-team; removed Editing-team (Kanban Board).Dec 1 2022, 4:18 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
ppelberg moved this task from Untriaged to Needs Discussion / Investigation on the Editing-team board.
gerritbot added a comment.Dec 8 2022, 10:29 PM

Change 859605 abandoned by Bartosz Dziewoński:

[mediawiki/skins/MinervaNeue@master] Allow collapsible content in Minerva

Reason:

I will submit a specific patch for T323639 (collapsible mobile talk page banners), since everyone else wants a more complex solution for T111565 (collapsible content on mobile in general).

https://gerrit.wikimedia.org/r/859605

matmarex removed a subtask: T111565: Enable collapsible templates (including infoboxes) on mobile.Dec 8 2022, 10:30 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 8 2022, 10:30 PM
gerritbot added a comment.Dec 8 2022, 10:55 PM

Change 866516 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Enable collapsible content in mobile talk page lede content

https://gerrit.wikimedia.org/r/866516

gerritbot added a project: Patch-For-Review.Dec 8 2022, 10:55 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.Dec 8 2022, 10:55 PM
matmarex moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.
Izno subscribed.Dec 8 2022, 11:14 PM
gerritbot added a comment.Jan 10 2023, 4:37 PM

Change 866516 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Enable collapsible content in mobile talk page lede content

https://gerrit.wikimedia.org/r/866516

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 10 2023, 5:00 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 10 2023, 5:21 PM
matmarex added a project: Editing QA.
Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 5:30 PM
EAkinloose edited projects, added Verified; removed Editing QA.Jan 20 2023, 7:40 AM
EAkinloose subscribed.

✅ Talk page banners are collapsible in mobile DiscussionTools

IMG_D2094E38B8D7-1.jpeg (2×1 px, 1 MB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 20 2023, 7:40 AM
matmarex added a comment.Jan 20 2023, 10:49 AM
In T323639#8414731, @matmarex wrote:

(There are some other problems with the rendering of these boxes, particularly at narrower sizes – I plan to propose changes on-wiki to resolve them after this issue is fixed.)

https://en.wikipedia.org/w/index.php?title=Special%3AContributions&target=Matma+Rex&namespace=10&wpfilters%5B%5D=associated&tagfilter=&start=2023-01-20&end=2023-01-20&limit=50

ppelberg closed this task as Resolved.Jan 21 2023, 12:15 AM
Tacsipacsi mentioned this in T327599: Toggling collapsible talk page banners on DT-enhanced mobile talk pages causes scrolling.Jan 22 2023, 12:32 PM
gerritbot added a comment.May 30 2024, 7:45 PM

Change #859605 restored by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Allow collapsible content in Minerva

https://gerrit.wikimedia.org/r/859605

gerritbot added a project: Patch-For-Review.May 30 2024, 7:45 PM
gerritbot added a comment.May 30 2024, 11:33 PM

Change #859605 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Allow collapsible content in Minerva

https://gerrit.wikimedia.org/r/859605

Tacsipacsi removed a project: Patch-For-Review.May 31 2024, 11:51 AM
gerritbot added a comment.Jun 3 2024, 10:57 PM

Change #1038446 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove jquery.makeCollapsible workarounds for mobile

https://gerrit.wikimedia.org/r/1038446

gerritbot added a project: Patch-For-Review.Jun 3 2024, 10:57 PM
gerritbot added a comment.Jun 10 2024, 7:29 PM

Change #1038446 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove jquery.makeCollapsible workarounds for mobile

https://gerrit.wikimedia.org/r/1038446

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 10 2024, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits